New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --frontend-server-starter-path
option to flutter run
and flutter test
#135038
Add --frontend-server-starter-path
option to flutter run
and flutter test
#135038
Conversation
9c5ae44
to
bf1e3c1
Compare
bf1e3c1
to
79a4e64
Compare
argParser.addOption( | ||
FlutterOptions.kFrontendServerStarterPath, | ||
help: 'When this value is provided, the frontend server will be started ' | ||
'in JIT mode from the specified file, instead of from the AOT ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a dart source entrypoint, a JIT snapshot, or either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only considering the case of it being a Dart source entrypoint, but you're right that the AppJIT snapshot case is also supported. I've updated the help message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
--frontend-server-starter-path
option to flutter run
and flutter test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (verified this worked for me locally on linux)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
…` and `flutter test` (flutter/flutter#135038)
No description provided.