Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a TextSpan test #135187

Merged
merged 1 commit into from Sep 21, 2023
Merged

Fix a TextSpan test #135187

merged 1 commit into from Sep 21, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

TextSpan.toStringDeep() returns a string that contains a lengthy diagnostic message instead of the plain string.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 21, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review September 21, 2023 01:15
chunhtai
chunhtai reviewed Sep 21, 2023
View reviewed changes
packages/flutter/test/rendering/paragraph_test.dart
final List<ui.TextBox> boxes = <ui.TextBox>[
for (int i = 0; i < text.length; ++i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode to be 4? Should it use textSpan.toPlainText instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The span tree looks pretty straightforward and we use equals(4) below anyway. If you prefer toPlainText I can switch to that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's switch back to use toPlainText. If this hardcode to 4 the below equals(4) expect is obsolete I think.

chunhtai
chunhtai approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2023
@auto-submit auto-submit bot merged commit 45e4a0e into flutter:master Sep 21, 2023
67 checks passed
@LongCatIsLooong LongCatIsLooong deleted the fix-paragraph-test branch September 21, 2023 19:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
e4806ea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
87fcee6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
b3de1b3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
059dbf6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
fb0df3d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
4be8af0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
b9cd378
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
7ef1db1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
c18f746
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
35a1c19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
5feb2bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
74b66a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
b01dbb7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
821c18d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
6ca04ba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
0ab283f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
bba1e96
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
c743b99
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
baee761
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
e1a8a4a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
0c471aa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
9aa0f9e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
ef2e843
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@LongCatIsLooong @Mairramer
Fix a TextSpan test (flutter#135187)
e570ce0 
`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
45e4a0e52 Fix a TextSpan test (flutter/flutter#135187)
3db4a7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LongCatIsLooong @chunhtai