Add RestorationManager disposals in test/services/restoration_test.dart. #135218

ksokolovskyi · 2023-09-21T13:06:47Z

This PR adds RestorationManager objects disposal in test/services/restoration_test.dart.

Description

Fixes Restauration manager not disposed #134831.

Tests

Updates test/services/restoration_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

polina-c · 2023-09-21T14:53:16Z

packages/flutter/.vscode/settings.json

@@ -0,0 +1,3 @@
+{


Can you remove this?

Sorry 🤦‍♂️, fixed.

I think you wanted to delete your edit, but not the entire file :)

It was my local VSCode settings file, so I just deleted it.
Now all is fine :)

…on_test.dart. (flutter/flutter#135218)

…rt. (flutter#135218)

…on_test.dart. (flutter/flutter#135218)

Fix test/services/restoration_test.dart

c774e01

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 21, 2023

polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023

polina-c requested changes Sep 21, 2023

View reviewed changes

ksokolovskyi added 3 commits September 21, 2023 17:18

Removed vscode files

8223a27

One more fix

2105ffe

.

81f7c0c

ksokolovskyi requested a review from polina-c September 21, 2023 15:23

polina-c approved these changes Sep 21, 2023

View reviewed changes

polina-c merged commit 4204f07 into flutter:master Sep 21, 2023
65 of 66 checks passed

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Roll Flutter from 893650416352 to 4204f07d76ec (60 revisions) flutter/packages#4968

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

5ff07a8

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Roll Flutter from 893650416352 to 203ec67c6596 (62 revisions) flutter/packages#4970

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

832cbab

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Roll Flutter from 893650416352 to da1f801fd5b9 (63 revisions) flutter/packages#4971

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

9c11781

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Roll Flutter from 893650416352 to c627dbfbc640 (64 revisions) flutter/packages#4972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

9e15e18

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Roll Flutter from 893650416352 to 30a9f99bc80b (65 revisions) flutter/packages#4973

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

ac664f2

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 21, 2023

Manual roll Flutter from 893650416352 to daea6e00bfc0 (69 revisions) flutter/packages#4975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

bcdfa36

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to f58163447f3b (86 revisions) flutter/packages#4978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

0b5eac6

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 06780cb1d069 (87 revisions) flutter/packages#4979

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

0996164

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 74c6693170e1 (88 revisions) flutter/packages#4980

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

3a154e1

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to dbe0ccd8853d (89 revisions) flutter/packages#4981

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

7e83c8c

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 76a938bfa6d1 (90 revisions) flutter/packages#4983

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

f9e338e

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

40b86ec

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

029d377

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

6e720a6

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

7c053f4

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

2d7c130

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

7604f02

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

ab0b7cd

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

6e8cb98

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

5cb234f

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

0a5efdb

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

0e0b599

…on_test.dart. (flutter/flutter#135218)

HansMuller mentioned this pull request Sep 28, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

7525cab

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

a81fbea

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

34883d0

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

0b62e5b

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

6634d7c

…on_test.dart. (flutter/flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

2d26cdc

…on_test.dart. (flutter/flutter#135218)

Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023

Add RestorationManager disposals in test/services/restoration_test.da…

cd6c1f6

…rt. (flutter#135218)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

4204f07d7 Add RestorationManager disposals in test/services/restorati…

c389c1d

…on_test.dart. (flutter/flutter#135218)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RestorationManager disposals in test/services/restoration_test.dart. #135218

Add RestorationManager disposals in test/services/restoration_test.dart. #135218

ksokolovskyi commented Sep 21, 2023

polina-c Sep 21, 2023

ksokolovskyi Sep 21, 2023

polina-c Sep 21, 2023

ksokolovskyi Sep 21, 2023 •

edited

Add RestorationManager disposals in test/services/restoration_test.dart. #135218

Add RestorationManager disposals in test/services/restoration_test.dart. #135218

Conversation

ksokolovskyi commented Sep 21, 2023

Description

Tests

Pre-launch Checklist

polina-c Sep 21, 2023

Choose a reason for hiding this comment

ksokolovskyi Sep 21, 2023

Choose a reason for hiding this comment

polina-c Sep 21, 2023

Choose a reason for hiding this comment

ksokolovskyi Sep 21, 2023 • edited

Choose a reason for hiding this comment

ksokolovskyi Sep 21, 2023 •

edited