Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leak track tab_scaffold_test.dart #135309

Merged
merged 1 commit into from Oct 2, 2023
Merged

leak track tab_scaffold_test.dart #135309

merged 1 commit into from Oct 2, 2023

Conversation

NobodyForNothing
Copy link
Contributor

Adds leak tracking to tab_scaffold_test.dart and fixes leaks in the file. (#134).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 22, 2023
@NobodyForNothing
Copy link
Contributor Author

@polina-c, would you take a look at this PR, please?

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 2, 2023
@polina-c polina-c merged commit 397da06 into flutter:master Oct 2, 2023
66 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
397da0649 leak track tab_scaffold_test.dart (flutter/flutter#135309)
8066ce6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
397da0649 leak track tab_scaffold_test.dart (flutter/flutter#135309)
79dedd3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
397da0649 leak track tab_scaffold_test.dart (flutter/flutter#135309)
d125d5b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
397da0649 leak track tab_scaffold_test.dart (flutter/flutter#135309)
2e3d36a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
397da0649 leak track tab_scaffold_test.dart (flutter/flutter#135309)
4a1cf18
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 3, 2023
@engine-flutter-autoroll
Roll Flutter from 57ed72417780 to 512299113fa0 (21 revisions) (#5067)
434b348 
flutter/flutter@57ed724...5122991

2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff02c71f1451 to 74f4d3fc3179 (1 revision) (flutter/flutter#135913)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b758503b57 to ff02c71f1451 (1 revision) (flutter/flutter#135911)
2023-10-03 engine-flutter-autoroll@skia.org Roll Packages from e2ac440 to c7008cf (4 revisions) (flutter/flutter#135907)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from c11e7cdd5de5 to 28b758503b57 (3 revisions) (flutter/flutter#135906)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a60a1d89664 to c11e7cdd5de5 (1 revision) (flutter/flutter#135894)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef86c9d84745 to 0a60a1d89664 (3 revisions) (flutter/flutter#135893)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1549d58b6ed5 to ef86c9d84745 (1 revision) (flutter/flutter#135889)
2023-10-03 linxunfeng@yeah.net Fix the character field of RawKeyEvent is always null on iOS (flutter/flutter#135100)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5bc3ab514546 to 1549d58b6ed5 (2 revisions) (flutter/flutter#135887)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0956ef53590a to 5bc3ab514546 (1 revision) (flutter/flutter#135880)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com Cover some cupertino tests with leak tracking (flutter/flutter#135230)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com leak track tab_scaffold_test.dart (flutter/flutter#135309)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6aa04dca7589 to 0956ef53590a (1 revision) (flutter/flutter#135878)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aa990133ebc to 6aa04dca7589 (1 revision) (flutter/flutter#135872)
2023-10-02 sokolovskyi.konstantin@gmail.com Fix a couple of CupertinoTextField tests to avoid leak-tracking test failures. (flutter/flutter#135851)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a92cb0c4da to 9aa990133ebc (1 revision) (flutter/flutter#135871)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b97818f301ba to f3a92cb0c4da (3 revisions) (flutter/flutter#135869)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from c0cf135b1199 to b97818f301ba (1 revision) (flutter/flutter#135862)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39819e6d306b to c0cf135b1199 (2 revisions) (flutter/flutter#135860)
2023-10-02 engine-flutter-autoroll@skia.org Roll Packages from d0e9a0e to e2ac440 (12 revisions) (flutter/flutter#135859)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 321139f5821e to 39819e6d306b (1 revision) (flutter/flutter#135857)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@NobodyForNothing @Mairramer
leak track tab_scaffold_test.dart (flutter#135309)
41788b3
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Open
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 57ed72417780 to 512299113fa0 (21 revisions) (flutte…
13de57e 
…r#5067)

flutter/flutter@57ed724...5122991

2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff02c71f1451 to 74f4d3fc3179 (1 revision) (flutter/flutter#135913)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b758503b57 to ff02c71f1451 (1 revision) (flutter/flutter#135911)
2023-10-03 engine-flutter-autoroll@skia.org Roll Packages from e2ac440 to c7008cf (4 revisions) (flutter/flutter#135907)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from c11e7cdd5de5 to 28b758503b57 (3 revisions) (flutter/flutter#135906)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a60a1d89664 to c11e7cdd5de5 (1 revision) (flutter/flutter#135894)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef86c9d84745 to 0a60a1d89664 (3 revisions) (flutter/flutter#135893)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1549d58b6ed5 to ef86c9d84745 (1 revision) (flutter/flutter#135889)
2023-10-03 linxunfeng@yeah.net Fix the character field of RawKeyEvent is always null on iOS (flutter/flutter#135100)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5bc3ab514546 to 1549d58b6ed5 (2 revisions) (flutter/flutter#135887)
2023-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0956ef53590a to 5bc3ab514546 (1 revision) (flutter/flutter#135880)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com Cover some cupertino tests with leak tracking (flutter/flutter#135230)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com leak track tab_scaffold_test.dart (flutter/flutter#135309)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6aa04dca7589 to 0956ef53590a (1 revision) (flutter/flutter#135878)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aa990133ebc to 6aa04dca7589 (1 revision) (flutter/flutter#135872)
2023-10-02 sokolovskyi.konstantin@gmail.com Fix a couple of CupertinoTextField tests to avoid leak-tracking test failures. (flutter/flutter#135851)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a92cb0c4da to 9aa990133ebc (1 revision) (flutter/flutter#135871)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b97818f301ba to f3a92cb0c4da (3 revisions) (flutter/flutter#135869)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from c0cf135b1199 to b97818f301ba (1 revision) (flutter/flutter#135862)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39819e6d306b to c0cf135b1199 (2 revisions) (flutter/flutter#135860)
2023-10-02 engine-flutter-autoroll@skia.org Roll Packages from d0e9a0e to e2ac440 (12 revisions) (flutter/flutter#135859)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 321139f5821e to 39819e6d306b (1 revision) (flutter/flutter#135857)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyForNothing @polina-c