Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add Arm64 benchmarks #135514

Merged
merged 3 commits into from Oct 11, 2023
Merged

[Windows] Add Arm64 benchmarks #135514

merged 3 commits into from Oct 11, 2023

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Sep 26, 2023 •
edited

Part of: #129806

Test runs kicked off using led:

/cc @pbo-linaro

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma added the a: desktop Running on desktop label Sep 26, 2023
@loic-sharma loic-sharma marked this pull request as ready for review September 26, 2023 18:05
@loic-sharma loic-sharma added the blocked Issue is blocked by another issue label Sep 28, 2023
@loic-sharma
Copy link
Member Author

loic-sharma commented Sep 28, 2023 •
edited

⚠️ Do not merge this until #135722 is fixed

EDIT: #135725 was landed as a workaround for #135722.

@loic-sharma loic-sharma added autosubmit Merge PR when tree becomes green via auto submit App and removed blocked Issue is blocked by another issue labels Oct 11, 2023
@auto-submit auto-submit bot merged commit c6aeab9 into flutter:master Oct 11, 2023
134 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
dc067f9
@loic-sharma loic-sharma deleted the windows_arm64_benchmarks branch October 11, 2023 17:04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
4d23f3b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
af22bba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
e3169b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
545b937
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
a27d3cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
3872467
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
250ad26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
2fc76b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
1c7c3d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
ff67781
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
c6aeab930 [Windows] Add Arm64 benchmarks (flutter/flutter#135514)
5f38e16
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@yaakovschectman yaakovschectman Awaiting requested review from yaakovschectman

Assignees
No one assigned
Labels
a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loic-sharma @cbracken @loic-sharma-google