-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Form validation method #135578
Merged
+144
−2
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
03dbdfe
introduced `validateGranually` to `FormState`
SharbelOkzan 58b69f3
Removed taboo words from comments
SharbelOkzan bccf8c5
fix typos and docs formatting
SharbelOkzan 1c43aee
Use a Map reference to return validation results
SharbelOkzan 05d300b
Remove duplicated method call
SharbelOkzan 53b0e83
Remove deleted class docs
SharbelOkzan 7de28b0
added empty line to docs
SharbelOkzan 60bb5da
return List of invalid fields instead of a Map
SharbelOkzan edabb16
Merge remote-tracking branch 'upstream/master'
SharbelOkzan bfbfd5b
use Set instead of a List
SharbelOkzan 674febb
fix punctuation
SharbelOkzan 97d8e29
Merge remote-tracking branch 'upstream/master'
SharbelOkzan 904a1c9
Merge branch 'master' into master
SharbelOkzan 01e22aa
Update validateGranularly doc comments
SharbelOkzan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should have an empty new line before this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Renzo-Olivares , done. Anything else I should fix?