Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleAvatar & DataTable tests for Material 3 #135901

Merged
merged 1 commit into from Oct 9, 2023
Merged

Update CircleAvatar & DataTable tests for Material 3 #135901

merged 1 commit into from Oct 9, 2023

Conversation

TahaTesser
Copy link
Member

Updated unit tests for CircleAvatar & DataTable to have M2 and M3 versions.

More info in #127064

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 3, 2023
QuncCccccc
QuncCccccc approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for continuing to add more tests! LGTM!

packages/flutter/test/material/data_table_test.dart Outdated Show resolved Hide resolved
@TahaTesser TahaTesser force-pushed the update_avatar_data_table_tests branch from 02102eb to 6f356e2 Compare October 9, 2023 09:22
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot merged commit 9ab091f into flutter:master Oct 9, 2023
67 checks passed
@TahaTesser TahaTesser deleted the update_avatar_data_table_tests branch October 9, 2023 10:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2023
@engine-flutter-autoroll
9ab091f92 Update CircleAvatar & DataTable tests for Material 3 (f…
e5dbe7d 
…lutter/flutter#135901)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 9, 2023
@engine-flutter-autoroll
Roll Flutter from 5207a309e8d8 to f52fe4f7e55d (18 revisions) (#5093)
1c31deb 
flutter/flutter@5207a30...f52fe4f

2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/painting #2 (flutter/flutter#136169)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (flutter/flutter#136195)
2023-10-09 tessertaha@gmail.com Fix `flutter drive` instructions in `Macrobenchmark` README (flutter/flutter#135990)
2023-10-09 tessertaha@gmail.com Update `CircleAvatar` & `DataTable` tests for Material 3 (flutter/flutter#135901)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (flutter/flutter#136187)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (flutter/flutter#136186)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (flutter/flutter#136182)
2023-10-09 leroux_bruno@yahoo.fr Update BottomSheet test for M3 + fix an issue in elevation resolution (flutter/flutter#136071)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (flutter/flutter#136175)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (flutter/flutter#136168)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (flutter/flutter#136158)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (flutter/flutter#136156)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (flutter/flutter#136150)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (flutter/flutter#136147)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (flutter/flutter#136145)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (flutter/flutter#136142)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (flutter/flutter#136141)
2023-10-07 polinach@google.com Allow leaks around tap down/up, while flackiness is not fixed. (flutter/flutter#136133)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@TahaTesser @Mairramer
Update CircleAvatar & DataTable tests for Material 3 (flutter#135901
ff8b5b4 
)

Updated unit tests for `CircleAvatar` & `DataTable` to have M2 and M3 versions.

More info in flutter#127064
@TahaTesser TahaTesser mentioned this pull request Oct 25, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Oct 27, 2023
@TahaTesser
Update DataTable test when data row is pressed for Material 3 (#137230
64f31b2 
)

This updates one of them M3 test to use golden test from #135901
Keeping it consistent with this [update](#136809 (comment))
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 5207a309e8d8 to f52fe4f7e55d (18 revisions) (flutte…
e7c48a7 
…r#5093)

flutter/flutter@5207a30...f52fe4f

2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/painting flutter#2 (flutter/flutter#136169)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (flutter/flutter#136195)
2023-10-09 tessertaha@gmail.com Fix `flutter drive` instructions in `Macrobenchmark` README (flutter/flutter#135990)
2023-10-09 tessertaha@gmail.com Update `CircleAvatar` & `DataTable` tests for Material 3 (flutter/flutter#135901)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (flutter/flutter#136187)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (flutter/flutter#136186)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (flutter/flutter#136182)
2023-10-09 leroux_bruno@yahoo.fr Update BottomSheet test for M3 + fix an issue in elevation resolution (flutter/flutter#136071)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (flutter/flutter#136175)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (flutter/flutter#136168)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (flutter/flutter#136158)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (flutter/flutter#136156)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (flutter/flutter#136150)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (flutter/flutter#136147)
2023-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (flutter/flutter#136145)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (flutter/flutter#136142)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (flutter/flutter#136141)
2023-10-07 polinach@google.com Allow leaks around tap down/up, while flackiness is not fixed. (flutter/flutter#136133)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TahaTesser @QuncCccccc