Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover more test/material tests with leak tracking. #136093

Merged
merged 4 commits into from Oct 10, 2023
Merged

Cover more test/material tests with leak tracking. #136093

merged 4 commits into from Oct 10, 2023

Conversation

ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Oct 6, 2023 •
edited

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/material tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates material/chip_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/chip_theme_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/dropdown_form_field_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/dropdown_menu_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/dropdown_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/elevated_button_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/persistent_bottom_sheet_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/snack_bar_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/tab_bar_theme_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/text_field_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/text_form_field_test.dart to use testWidgetsWithLeakTracking;
  • Updates material/tooltip_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 6, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

polina-c
polina-c requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 10, 2023
@ksokolovskyi
Copy link
Contributor Author

@polina-c, thanks a lot for the review!

@polina-c polina-c merged commit 5064f78 into flutter:master Oct 10, 2023
67 checks passed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/material tests with leak tracking. (flutter#136093)
8f347f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
cb8fd6c 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
35e4aa4 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
52ad8ac 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
d3eadee 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
44d0e97 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
5101ac8 
…/flutter#136093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
06a0165 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
9708179 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
9173efc 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
4dbd90f 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
ee4a696 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
58aaa50 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
46125c0 
…/flutter#136093)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
5064f782c Cover more test/material tests with leak tracking. (flutter…
1145310 
…/flutter#136093)
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksokolovskyi @polina-c