Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimePickerDialog should dispose created ChangeNotifiers. #136261

Merged
merged 1 commit into from Oct 10, 2023
Merged

TimePickerDialog should dispose created ChangeNotifiers. #136261

merged 1 commit into from Oct 10, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

Tests

  • Updates material/time_picker_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 10, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 10, 2023
@polina-c polina-c merged commit 0a69470 into flutter:master Oct 10, 2023
67 checks passed
@ksokolovskyi
Copy link
Contributor Author

@polina-c, thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
6bedc2b 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
ad9d82a 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
0d4bbdf 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
abec41d 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
7a0ba0f 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
b6a9043 
…lutter/flutter#136261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
e476481 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
76aa007 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
cc67982 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
be1d18a 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
303c6a1 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
c8218be 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
0376159 
…lutter/flutter#136261)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
0a6947049 TimePickerDialog should dispose created ChangeNotifiers. (f…
879fdd7 
…lutter/flutter#136261)
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak: TimePickerDialog does not dispose several ChangeNotifiers.
2 participants
@ksokolovskyi @polina-c