Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] allow tool integration tests to quit on SIGINT #136271

Merged
merged 1 commit into from Oct 10, 2023
Merged

[flutter_tools] allow tool integration tests to quit on SIGINT #136271

merged 1 commit into from Oct 10, 2023

Conversation

christopherfujino
Copy link
Member

fixes #136270

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 10, 2023
eliasyishak
eliasyishak approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but curious how using FakeSignals allows for the integration tests to be killed with ctrl+c?

Also is this test exempt?

@christopherfujino
Copy link
Member Author

christopherfujino commented Oct 10, 2023 •
edited

Code LGTM, but curious how using FakeSignals allows for the integration tests to be killed with ctrl+c?

Now when we run this code: https://github.com/christopherfujino/flutter/blob/allow-integration-tests-to-be-killed-with-ctrl-c/packages/flutter_tools/lib/src/resident_runner.dart#L1684, we don't actually trap SIGINT, we just call a dummy .addHandler() method on the FakeSignals.

Also is this test exempt?

it's test code :). We only need a test exemption if the bot flags it as needing test code.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit auto-submit bot merged commit 0fa01b2 into flutter:master Oct 10, 2023
121 checks passed
@christopherfujino christopherfujino deleted the allow-integration-tests-to-be-killed-with-ctrl-c branch October 10, 2023 21:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
801de03 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
d088c6d 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
be210c7 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
acc067d 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
02ec605 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
b4a4b92 
…INT (flutter/flutter#136271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
d7df19b 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
01e9b50 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
bce3db7 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
7e1bf7a 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
2eb5adc 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
c1299f8 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
240df16 
…INT (flutter/flutter#136271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
0fa01b215 [flutter_tools] allow tool integration tests to quit on SIG…
62ba32b 
…INT (flutter/flutter#136271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasyishak eliasyishak eliasyishak approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_tools] tool integration tests cannot be killed with a signal
2 participants
@christopherfujino @eliasyishak