Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ColorScheme.fromSwatch docs for Material 3 #136816

Merged
merged 1 commit into from Oct 23, 2023
Merged

Update ColorScheme.fromSwatch docs for Material 3 #136816

merged 1 commit into from Oct 23, 2023

Conversation

TahaTesser
Copy link
Member

part of Clarify ColorScheme fromSwatch/fromSeed usage

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 18, 2023
HansMuller
HansMuller approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023
@auto-submit auto-submit bot merged commit 5e8b5f4 into flutter:master Oct 23, 2023
61 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 23, 2023
@engine-flutter-autoroll
5e8b5f4ea Update ColorScheme.fromSwatch docs for Material 3 (flutte…
e2888dc 
…r/flutter#136816)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 23, 2023
@engine-flutter-autoroll
Roll Flutter from 823e08353dd8 to 5e8b5f4ea293 (13 revisions) (#5208)
be5c798 
flutter/flutter@823e083...5e8b5f4

2023-10-23 tessertaha@gmail.com Update `ColorScheme.fromSwatch` docs for Material 3 (flutter/flutter#136816)
2023-10-23 47866232+chunhtai@users.noreply.github.com Reland "Fixes ability to call nextFocus() on a node to focus its desc� (flutter/flutter#136898)
2023-10-23 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (flutter/flutter#134921)
2023-10-23 engine-flutter-autoroll@skia.org Roll Packages from be915be to 4bf5114 (12 revisions) (flutter/flutter#137062)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8820a419c800 to 1dc66e8f2fba (1 revision) (flutter/flutter#137055)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2abdeb650f8 to 8820a419c800 (1 revision) (flutter/flutter#137051)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39f78ce1884d to e2abdeb650f8 (1 revision) (flutter/flutter#137050)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4899344c34d9 to 39f78ce1884d (1 revision) (flutter/flutter#137048)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d05b061e245 to 4899344c34d9 (1 revision) (flutter/flutter#137046)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from cde34b8182b1 to 9d05b061e245 (1 revision) (flutter/flutter#137044)
2023-10-22 tvolkert@users.noreply.github.com Add timeline events for post frame callbacks (flutter/flutter#136435)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8d702c0e0d7 to cde34b8182b1 (1 revision) (flutter/flutter#137038)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3c7a50bc83f to b8d702c0e0d7 (1 revision) (flutter/flutter#137035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@TahaTesser TahaTesser deleted the update_from_swatch_docs branch October 24, 2023 07:50
@HansMuller HansMuller mentioned this pull request Nov 1, 2023
Open
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 823e08353dd8 to 5e8b5f4ea293 (13 revisions) (flutte…
1f8c8d3 
…r#5208)

flutter/flutter@823e083...5e8b5f4

2023-10-23 tessertaha@gmail.com Update `ColorScheme.fromSwatch` docs for Material 3 (flutter/flutter#136816)
2023-10-23 47866232+chunhtai@users.noreply.github.com Reland "Fixes ability to call nextFocus() on a node to focus its desc� (flutter/flutter#136898)
2023-10-23 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (flutter/flutter#134921)
2023-10-23 engine-flutter-autoroll@skia.org Roll Packages from be915be to 4bf5114 (12 revisions) (flutter/flutter#137062)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8820a419c800 to 1dc66e8f2fba (1 revision) (flutter/flutter#137055)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2abdeb650f8 to 8820a419c800 (1 revision) (flutter/flutter#137051)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39f78ce1884d to e2abdeb650f8 (1 revision) (flutter/flutter#137050)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4899344c34d9 to 39f78ce1884d (1 revision) (flutter/flutter#137048)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d05b061e245 to 4899344c34d9 (1 revision) (flutter/flutter#137046)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from cde34b8182b1 to 9d05b061e245 (1 revision) (flutter/flutter#137044)
2023-10-22 tvolkert@users.noreply.github.com Add timeline events for post frame callbacks (flutter/flutter#136435)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8d702c0e0d7 to cde34b8182b1 (1 revision) (flutter/flutter#137038)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3c7a50bc83f to b8d702c0e0d7 (1 revision) (flutter/flutter#137035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TahaTesser @HansMuller