Add ProcessTextService #137145
Merged
Add ProcessTextService #137145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
camsim99
approved these changes
Oct 25, 2023
| /// The `readOnly` parameter indicates that the transformed text, it if exists, | ||
| /// will be used as read-only. | ||
| /// See https://developer.android.com/reference/android/content/Intent#EXTRA_PROCESS_TEXT_READONLY. | ||
| Future<String?> processTextAction(String id, String text, bool readOnly); |
There was a problem hiding this comment.
Is it purposeful that this is separated from the default service in the sense that the behavior here is intended to be customizable? Assuming so, a nit is maybe the link can be mentioned in the default service since this seems specific to Android?
| abstract class ProcessTextService { | ||
| /// Returns a [Future] that resolves to a [List] of [ProcessTextAction]s | ||
| /// containing all text processing actions available. | ||
| Future<List<ProcessTextAction>> queryTextActions(); |
There was a problem hiding this comment.
Nit: maybe note that if there are none available, an empty list will be returned.
bleroux
force-pushed
the
process_text_service
branch
from
02d1b8d
to
87fc98b
Compare
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 26, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 26, 2023
flutter/flutter@5dd2a4e...c555599 2023-10-26 engine-flutter-autoroll@skia.org Roll Packages from f751ffb to fea24c5 (4 revisions) (flutter/flutter#137339) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23649a0529e5 to 61ae5ef94e9c (1 revision) (flutter/flutter#137337) 2023-10-26 15619084+vashworth@users.noreply.github.com Run test with older version of Xcode (flutter/flutter#137293) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8525b9fdddf to 23649a0529e5 (1 revision) (flutter/flutter#137333) 2023-10-26 leroux_bruno@yahoo.fr Add ProcessTextService (flutter/flutter#137145) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6bea17e39d3 to f8525b9fdddf (1 revision) (flutter/flutter#137330) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec29ea930f58 to b6bea17e39d3 (1 revision) (flutter/flutter#137329) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a01fae53ded to ec29ea930f58 (1 revision) (flutter/flutter#137326) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a91eb44c5b to 2a01fae53ded (1 revision) (flutter/flutter#137320) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f844ab933364 to 10a91eb44c5b (1 revision) (flutter/flutter#137317) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6428ed576841 to f844ab933364 (1 revision) (flutter/flutter#137314) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions) (flutter/flutter#137310) 2023-10-26 50643541+Mairramer@users.noreply.github.com fix:: trigger onTapOutside only if has focus (flutter/flutter#136291) 2023-10-25 goderbauer@google.com Fix structure of pkg:integration_test (flutter/flutter#137283) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#5237) flutter/flutter@5dd2a4e...c555599 2023-10-26 engine-flutter-autoroll@skia.org Roll Packages from f751ffb to fea24c5 (4 revisions) (flutter/flutter#137339) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23649a0529e5 to 61ae5ef94e9c (1 revision) (flutter/flutter#137337) 2023-10-26 15619084+vashworth@users.noreply.github.com Run test with older version of Xcode (flutter/flutter#137293) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8525b9fdddf to 23649a0529e5 (1 revision) (flutter/flutter#137333) 2023-10-26 leroux_bruno@yahoo.fr Add ProcessTextService (flutter/flutter#137145) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6bea17e39d3 to f8525b9fdddf (1 revision) (flutter/flutter#137330) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec29ea930f58 to b6bea17e39d3 (1 revision) (flutter/flutter#137329) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a01fae53ded to ec29ea930f58 (1 revision) (flutter/flutter#137326) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a91eb44c5b to 2a01fae53ded (1 revision) (flutter/flutter#137320) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f844ab933364 to 10a91eb44c5b (1 revision) (flutter/flutter#137317) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6428ed576841 to f844ab933364 (1 revision) (flutter/flutter#137314) 2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions) (flutter/flutter#137310) 2023-10-26 50643541+Mairramer@users.noreply.github.com fix:: trigger onTapOutside only if has focus (flutter/flutter#136291) 2023-10-25 goderbauer@google.com Fix structure of pkg:integration_test (flutter/flutter#137283) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ProcessTextServiceon the framework side to communicate with the engine to query and run text processing actions (on the engine side, only Android is supported currently, see flutter/engine#44579).Related Issue
Non-UI framework side for #139361
Tests
Adds 3 tests.