Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases #137550

TahaTesser · 2023-10-30T16:32:35Z

This PR removes ButtonBar usage from framework_test.dart class and update other references in preparation for ButtonBar deprecation

related to #127955

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…eferences from other clases

Piinks

…remove references from other clases (#137550)" This reverts commit b1f5d96.

… remove references from other clases" (#137731) Reverts #137550 Initiated by: Piinks This change reverts the following previous change: Original Description: This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation related to #127955

…d remove references from other clases (flutter/flutter#137550)

…eferences from other clases (flutter#137550) This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation related to flutter#127955

…remove references from other clases (#137550) (#137753) This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation related to #127955 reland #137550

…remove references from other clases (flutter#137550) (flutter#137753) This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation related to flutter#127955 reland flutter#137550

…d remove references from other clases (flutter/flutter#137550)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 30, 2023

Update framework_test.dart to remove ButtonBar usage and remove r…

9748230

…eferences from other clases

TahaTesser force-pushed the remove_buttonbar_references branch from 010f05a to 9748230 Compare October 31, 2023 09:23

TahaTesser requested a review from Piinks October 31, 2023 21:27

Piinks approved these changes Nov 1, 2023

View reviewed changes

Piinks added c: tech-debt Technical debt, code quality, testing, etc. autosubmit Merge PR when tree becomes green via auto submit App labels Nov 1, 2023

auto-submit bot merged commit b1f5d96 into flutter:master Nov 1, 2023
64 checks passed

TahaTesser deleted the remove_buttonbar_references branch November 1, 2023 22:06

Piinks added a commit that referenced this pull request Nov 1, 2023

Revert "Update framework_test.dart to remove ButtonBar usage and …

7bedcfc

…remove references from other clases (#137550)" This reverts commit b1f5d96.

Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 1, 2023

auto-submit bot mentioned this pull request Nov 1, 2023

Reverts "Update framework_test.dart to remove ButtonBar usage and remove references from other clases" #137731

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 1, 2023

auto-submit bot pushed a commit that referenced this pull request Nov 1, 2023

Revert "Update framework_test.dart to remove ButtonBar usage and …

7b9cae5

…remove references from other clases (#137550)" This reverts commit b1f5d96.

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 39f297419211 (24 revisions) flutter/packages#5297

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

d76699d

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 41e9235181c2 (26 revisions) flutter/packages#5299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

08537d5

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 8d2fe7dc6f3b (28 revisions) flutter/packages#5300

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

6f9c91b

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 2cca57623187 (29 revisions) flutter/packages#5301

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

4cf7d94

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 06a66670d2ce (30 revisions) flutter/packages#5302

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

339ce2f

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 55eb5e11db99 (31 revisions) flutter/packages#5303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

2e91f47

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 615dd968e79b (32 revisions) flutter/packages#5304

Closed

engine-flutter-autoroll mentioned this pull request Nov 2, 2023

Roll Flutter from 29b25165cab8 to 90c73055b2a4 (38 revisions) flutter/packages#5309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

e35137a

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

01db5d8

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

07a3ca0

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

e394e56

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

cf89ceb

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

4123834

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

de65159

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

ffd5b2f

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

3e3183c

…d remove references from other clases (flutter/flutter#137550)

HansMuller mentioned this pull request Nov 3, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

ac6fb87

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

a32d099

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

fdcb076

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

cce7e6b

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

75b62ec

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

0ac4d4a

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

f2e8bd9

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

d9f84d5

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

d842a21

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

4e13ae2

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

8ea7ffe

…d remove references from other clases (flutter/flutter#137550)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

6b16d3a

…d remove references from other clases (flutter/flutter#137550)

TahaTesser mentioned this pull request Nov 13, 2023

Reland "Update framework_test.dart to remove ButtonBar usage and remove references from other clases (#137550) #137753

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

b1f5d96a8 Update framework_test.dart to remove ButtonBar usage an…

b93f597

…d remove references from other clases (flutter/flutter#137550)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases #137550

Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases #137550

TahaTesser commented Oct 30, 2023 •

edited

Piinks left a comment

Update framework_test.dart to remove ButtonBar usage and remove references from other clases #137550

Update framework_test.dart to remove ButtonBar usage and remove references from other clases #137550

Conversation

TahaTesser commented Oct 30, 2023 • edited

Pre-launch Checklist

Piinks left a comment

Choose a reason for hiding this comment

Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases #137550

Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases #137550

TahaTesser commented Oct 30, 2023 •

edited