Fix text selection in `SearchAnchor/SearchBar` #137636

Renzo-Olivares · 2023-10-31T19:21:27Z

This changes fixes text selection gestures on the search field when using SearchAnchor.

Before this change text selection gestures did not work due to an IgnorePointer in the widget tree.

This change:

Removes the IgnorePointer so the underlying TextField can receive pointer events.
Introduces TextField.onTapAlwaysCalled and TextSelectionGestureDetector.onUserTapAlwaysCalled, so a user provided on tap callback can be called on consecutive taps. This is so that the user provided on tap callback for SearchAnchor/SearchBar that was previously only handled by InkWell will still work if a tap occurs in the TextFields hit box. The TextFields default behavior is maintained outside of the context of SearchAnchor/SearchBar.

Fixes #128332 and #134965

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

QuncCccccc

This looks good to me! Just left some questions:)

QuncCccccc · 2023-11-08T00:32:21Z

packages/flutter/lib/src/material/search_anchor.dart

+                    padding: effectivePadding,
+                    child: TextField(
+                      autofocus: widget.autoFocus,
+                      onTap: () {


Can we just do onTap: widget.onTap?

QuncCccccc · 2023-11-08T01:27:48Z

packages/flutter/lib/src/material/search_anchor.dart

@@ -831,6 +827,7 @@ class _ViewContentState extends State<_ViewContent> {
                          top: false,
                          bottom: false,
                          child: SearchBar(
+                            autoFocus: true,
                            constraints: widget.showFullScreenView ? BoxConstraints(minHeight: _SearchViewDefaultsM3.fullScreenBarHeight) : null,
                            focusNode: _focusNode,


Should we just remove _focusNode and the dispose part because I think it's unused?

QuncCccccc · 2023-11-08T17:28:17Z

packages/flutter/lib/src/material/text_field.dart

@@ -69,6 +69,13 @@ class _TextFieldSelectionGestureDetectorBuilder extends TextSelectionGestureDete
  void onSingleTapUp(TapDragUpDetails details) {
    super.onSingleTapUp(details);
    _state._requestKeyboard();
+  }


Seems _state.widget.onTap?.call(); is removed from onSingleTapUp. Just wonder if this is intended?

This is intended, it has been moved to onUserTap so there can be some differentiation between the framework onTap callback and a user provided onTap callback. This is a non-breaking change because onUserTap will still be called with onSingleTapUp in TextSelectionGestureDetector as it was before this change. Extenders of TextSelectionGestureDetectorBuilder will be okay because TextSelectionGestureDetector retains its previous behavior as the default (A user can still choose to put _state.widget.onTap?.call() in onSingleTapUp and it will work as expected).

QuncCccccc

LGTM! Thanks so much for this fix and all the unit tests😲!

…g the focus change as an internal change instead of a focus change as a result of a tab

…tter#137636)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: text input Entering text in a text field or keyboard related problems labels Oct 31, 2023

Renzo-Olivares force-pushed the fix-search-text-selection branch from 16b47c0 to d54ad44 Compare November 6, 2023 17:17

Renzo-Olivares marked this pull request as ready for review November 6, 2023 18:30

Renzo-Olivares changed the title ~~Fix text selection in SearchAnchor~~ Fix text selection in SearchAnchor/SearchBar Nov 6, 2023

Renzo-Olivares requested a review from QuncCccccc November 6, 2023 18:39

Renzo-Olivares mentioned this pull request Nov 7, 2023

SearchBar fails to show keyboard on Android after coming back from the background #134965

Closed

2 tasks

QuncCccccc approved these changes Nov 8, 2023

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023

Renzo-Olivares added 16 commits November 9, 2023 13:00

Fix test formatting and disable IgnorePointer

763571e

Remove IgnorePointer and fix all tests except onTap test

8beeb30

onTapAlwaysCalled

e240835

clean up

8d9a29d

more clean up

a5c4a39

Add regression tests for SearchAnchor text selection

3cb9150

fix tests

d4f32c6

clean up

c11aabd

clean up onUserTapAlwaysCalled

3b07c04

Fix analyzer

2e4e98f

Should use autoFocus instead of requestFocus so editable text can fla…

a350870

…g the focus change as an internal change instead of a focus change as a result of a tab

fix docs

e370f4d

update docs

f4d95c4

update more docs

40abc5f

fix analyzer

844ced2

update

399ccfb

Renzo-Olivares force-pushed the fix-search-text-selection branch from a235b09 to 399ccfb Compare November 9, 2023 21:00

Renzo-Olivares added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 9, 2023

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

f9452a8

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 10, 2023

Roll Flutter from f66215027e14 to 33c0f27464e8 (22 revisions) flutter/packages#5366

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

963ffee

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 10, 2023

Roll Flutter from f66215027e14 to 9a76efc8e329 (23 revisions) flutter/packages#5367

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

6e1fd39

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 10, 2023

Roll Flutter from f66215027e14 to d42d6399244e (24 revisions) flutter/packages#5368

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

80f662f

…tter#137636)

HansMuller mentioned this pull request Nov 10, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll mentioned this pull request Nov 11, 2023

Roll Flutter from f66215027e14 to e33d4b86270e (42 revisions) flutter/packages#5371

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

50da60a

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 11, 2023

Roll Flutter from f66215027e14 to e33d4b86270e (42 revisions) flutter/packages#5372

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

a3b49e3

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 12, 2023

Roll Flutter from f66215027e14 to e33d4b86270e (42 revisions) flutter/packages#5373

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

31f307e

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 13, 2023

Roll Flutter from f66215027e14 to 4e77e7b10c4a (44 revisions) flutter/packages#5391

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

94a012e

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 13, 2023

Roll Flutter from f66215027e14 to f70a01c69165 (45 revisions) flutter/packages#5392

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

5fd9b36

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 13, 2023

Roll Flutter from f66215027e14 to 749daa1af755 (46 revisions) flutter/packages#5393

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

f6a319f

…tter#137636)

engine-flutter-autoroll mentioned this pull request Nov 13, 2023

Roll Flutter from f66215027e14 to a681ff618ccd (48 revisions) flutter/packages#5394

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

81bb259

…tter#137636)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

44bd4be

…tter#137636)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

3086625

…tter#137636)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

7b659e5

…tter#137636)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

89e91f2

…tter#137636)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

b11bd8d

…tter#137636)

Renzo-Olivares mentioned this pull request Jan 10, 2024

Cannot move the cursor position of the SearchAnchor #139886

Closed

2 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

3225aa581 Fix text selection in SearchAnchor/SearchBar (flutter/flu…

4619c80

…tter#137636)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix text selection in `SearchAnchor/SearchBar` #137636

Fix text selection in `SearchAnchor/SearchBar` #137636

Renzo-Olivares commented Oct 31, 2023 •

edited

QuncCccccc left a comment

QuncCccccc Nov 8, 2023

QuncCccccc Nov 8, 2023

QuncCccccc Nov 8, 2023

Renzo-Olivares Nov 8, 2023 •

edited

QuncCccccc left a comment

Fix text selection in SearchAnchor/SearchBar #137636

Fix text selection in SearchAnchor/SearchBar #137636

Conversation

Renzo-Olivares commented Oct 31, 2023 • edited

Pre-launch Checklist

QuncCccccc left a comment

Choose a reason for hiding this comment

QuncCccccc Nov 8, 2023

Choose a reason for hiding this comment

QuncCccccc Nov 8, 2023

Choose a reason for hiding this comment

QuncCccccc Nov 8, 2023

Choose a reason for hiding this comment

Renzo-Olivares Nov 8, 2023 • edited

Choose a reason for hiding this comment

QuncCccccc left a comment

Choose a reason for hiding this comment

Fix text selection in `SearchAnchor/SearchBar` #137636

Fix text selection in `SearchAnchor/SearchBar` #137636

Renzo-Olivares commented Oct 31, 2023 •

edited

Renzo-Olivares Nov 8, 2023 •

edited