Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollActivity should dispatch creation and disposal events. #137961

Merged
merged 1 commit into from Nov 6, 2023
Merged

ScrollActivity should dispatch creation and disposal events. #137961

merged 1 commit into from Nov 6, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

Tests

  • Updates scroll_activity_test.dart to test ScrollActivity object creation and disposal dispatching.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Nov 6, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Nov 6, 2023
@polina-c polina-c merged commit 4880aab into flutter:master Nov 6, 2023
66 of 67 checks passed
@ksokolovskyi
Copy link
Contributor Author

@polina-c, thanks a lot for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023
@engine-flutter-autoroll
4880aab11 ScrollActivity should dispatch creation and disposal events. (
7439e21 
flutter/flutter#137961)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023
@engine-flutter-autoroll
4880aab11 ScrollActivity should dispatch creation and disposal events. (
8c15ff6 
flutter/flutter#137961)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023
@engine-flutter-autoroll
4880aab11 ScrollActivity should dispatch creation and disposal events. (
0d23b91 
flutter/flutter#137961)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 7, 2023
@engine-flutter-autoroll
Roll Flutter from f5a983535131 to 5a6a3224fe15 (15 revisions) (#5345)
a83b40d 
flutter/flutter@f5a9835...5a6a322

2023-11-07 engine-flutter-autoroll@skia.org Roll Packages from 49eac1f to be18d28 (3 revisions) (flutter/flutter#137999)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (flutter/flutter#138000)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (flutter/flutter#137997)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (flutter/flutter#137996)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (flutter/flutter#137987)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (flutter/flutter#137983)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (flutter/flutter#137980)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (flutter/flutter#137979)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (flutter/flutter#137944)
2023-11-06 sokolovskyi.konstantin@gmail.com SemanticsHandle should dispatch creation and disposal events. (flutter/flutter#137960)
2023-11-06 sokolovskyi.konstantin@gmail.com ScrollActivity should dispatch creation and disposal events. (flutter/flutter#137961)
2023-11-06 sokolovskyi.konstantin@gmail.com Cover text_selection tests with leak tracking. (flutter/flutter#137009)
2023-11-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#137862)
2023-11-06 42216813+eliasyishak@users.noreply.github.com Migration for `HotEvent` for Flutter hot runner (flutter/flutter#137717)
2023-11-06 jonahwilliams@google.com [benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (flutter/flutter#137902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Nov 10, 2023
Open
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from f5a983535131 to 5a6a3224fe15 (15 revisions) (flutte…
bf2a792 
…r#5345)

flutter/flutter@f5a9835...5a6a322

2023-11-07 engine-flutter-autoroll@skia.org Roll Packages from 49eac1f to be18d28 (3 revisions) (flutter/flutter#137999)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (flutter/flutter#138000)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (flutter/flutter#137997)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (flutter/flutter#137996)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (flutter/flutter#137987)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (flutter/flutter#137983)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (flutter/flutter#137980)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (flutter/flutter#137979)
2023-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (flutter/flutter#137944)
2023-11-06 sokolovskyi.konstantin@gmail.com SemanticsHandle should dispatch creation and disposal events. (flutter/flutter#137960)
2023-11-06 sokolovskyi.konstantin@gmail.com ScrollActivity should dispatch creation and disposal events. (flutter/flutter#137961)
2023-11-06 sokolovskyi.konstantin@gmail.com Cover text_selection tests with leak tracking. (flutter/flutter#137009)
2023-11-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#137862)
2023-11-06 42216813+eliasyishak@users.noreply.github.com Migration for `HotEvent` for Flutter hot runner (flutter/flutter#137717)
2023-11-06 jonahwilliams@google.com [benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (flutter/flutter#137902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
4880aab11 ScrollActivity should dispatch creation and disposal events. (
5597816 
flutter/flutter#137961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksokolovskyi @polina-c