TextField context menu should fade on scroll on mobile devices #138313

Renzo-Olivares · 2023-11-12T11:32:52Z

This change affects Android and iOS devices using the TextField's context menu. After this change the context menu will fade out when scrolling the text and fade in when the scroll ends.

If the scroll ends and the selection is outside of the view, then the toolbar will be scheduled to show in a future scroll end. This toolbar scheduling can be invalidated if the TextEditingValue changed anytime between the scheduling and when the toolbar is ready to be shown.

This change also fixes a regression where the TextField context menu would not fade when the selection handles where not visible.

When using the native browser context menu this behavior is not controlled by Flutter.

Screen.Recording.2023-11-13.at.1.36.49.PM.mov

Fixes #52425
Fixes #105804
Fixes #52426

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

packages/flutter/lib/src/widgets/editable_text.dart

Renzo-Olivares · 2023-11-20T21:58:31Z

packages/flutter/lib/src/widgets/editable_text.dart

+        hideToolbar(false);
+      }
+    } else if (notification is ScrollEndNotification) {
+      final Rect paintBounds = renderEditable.paintBounds;


Does anyone know if renderEditable.getTransformTo(null) == Matrix4.zero() is an accurate way of telling if a render object is in the current viewport? From the documentation of applyPaintTransform which is called during getTransformTo, this sounds like it is accurate

Some RenderObjects will provide a zeroed out matrix in this method, indicating that the child should not paint anything or respond to hit tests currently. A parent may supply a non-zero matrix even though it does not paint its child currently, for example if the parent is a [RenderOffstage] with offstage set to true. In both of these cases, the parent must return false from [paintsChild].

and from defaultApplyPaintTransform which is called from applyPaintTransform.

/// Applies the transform that would be applied when painting the given child /// to the given matrix. /// /// Render children whose [TextParentData.offset] is null zeros out the /// `transform` to indicate they're invisible thus should not be painted.

LongCatIsLooong · 2023-11-21T23:45:17Z

packages/flutter/lib/src/widgets/editable_text.dart

+      }
+    } else if (notification is ScrollEndNotification) {
+      final bool selectionIsVisible = renderEditable.selectionStartInViewport.value || renderEditable.selectionEndInViewport.value;
+      final bool renderEditableInView = renderEditable.getTransformTo(null) != Matrix4.zero();


I'm not sure I understand this line, the zero matrix isn't special as a perspective transform matrix?

I had this question #138313 (comment) related to that. I think it may be in accurate after thinking some more about it, but what do you think?

LongCatIsLooong · 2023-11-21T23:47:33Z

packages/flutter/lib/src/widgets/editable_text.dart

+  bool _toolbarVisibleAtScrollStart = false;
+  bool _showToolbarOnScreenScheduled = false;
+  bool _internalScrolling = false;
+  final bool _webContextMenuEnabled = kIsWeb && BrowserContextMenu.enabled;


can BrowserContextMenu.enabled change?

Oh good catch, I can make this a getter.

LongCatIsLooong · 2023-11-21T23:48:59Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -3536,11 +3553,67 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
    }
  }

+  final bool _platformSupportsFadeOnScroll = defaultTargetPlatform == TargetPlatform.android


I'd recommend using an exhaustive switch instead, in case more supported platforms are added in the future.

LongCatIsLooong · 2023-11-22T00:01:37Z

packages/flutter/lib/src/widgets/editable_text.dart

+        }
+      } else if (_toolbarVisibleAtScrollStart) {
+        _showToolbarOnScreenScheduled = true;
+        _valueWhenShowToolbarOnScreenScheduled = _value;


You don't need the boolean since the extra bit can be represented by setting _valueWhenShowToolbarOnScreenScheduled to null?

Also this is a bit hard to read.

That makes sense. Thanks for the suggestion, should look cleaner now.

LongCatIsLooong · 2023-11-22T00:03:37Z

packages/flutter/lib/src/widgets/editable_text.dart

+    // did not change between the time the toolbar was first
+    // scheduled to be shown to when it is ready to be shown.
+    if (notification is ScrollStartNotification) {
+      _toolbarVisibleAtScrollStart = _selectionOverlay != null && _selectionOverlay!.toolbarIsVisible;


nit: ?.toolbarIsVisible ?? false

LongCatIsLooong · 2023-11-22T00:04:36Z

packages/flutter/lib/src/widgets/editable_text.dart

+      if (_toolbarVisibleAtScrollStart) {
+        hideToolbar(false);
+      }
+    } else if (notification is ScrollEndNotification) {


do you need to enter the clause if toolbarVisibleAtScrollStart is false?

Good point we do not. I can add a check.

Piinks · 2023-11-27T17:13:25Z

packages/flutter/lib/src/widgets/editable_text.dart

+    TargetPlatform.android => true,
+    TargetPlatform.iOS => true,
+    TargetPlatform.fuchsia => false,
+    TargetPlatform.linux => false,
+    TargetPlatform.macOS => false,
+    TargetPlatform.windows => false,


Nit:

Suggested change

TargetPlatform.android => true,

TargetPlatform.iOS => true,

TargetPlatform.fuchsia => false,

TargetPlatform.linux => false,

TargetPlatform.macOS => false,

TargetPlatform.windows => false,

TargetPlatform.android ||

TargetPlatform.iOS => true,

TargetPlatform.fuchsia ||

TargetPlatform.linux ||

TargetPlatform.macOS ||

TargetPlatform.windows => false,

Piinks · 2023-11-27T17:15:16Z

packages/flutter/lib/src/widgets/editable_text.dart

+      }
+
+      final Rect renderEditableBounds = MatrixUtils.transformRect(renderEditable.getTransformTo(null), renderEditable.paintBounds);
+      final Rect viewportRect = _calculateViewportRect();


Is this the Viewport as in the scrollable RenderViewport rect?

Piinks · 2023-11-27T17:15:55Z

packages/flutter/lib/src/widgets/editable_text.dart

+    _handleContextMenuOnScroll(notification);
+  }
+
+  Rect _calculateViewportRect() {


If this is the scrollable RenderViewport, I think you could get the rect from RenderAbstractViewport.of(context)

My intention here was to get a rect that closest represents the visible portion of the flutter view. I want to know if the RenderEditable is visible on the screen. Would RenderAbstractViewport.of(context) still work if we have a TextField within a horizontal scrollable nested within a vertical scrollable?

In that case you may have to bubble up through multiple viewports to find out. Maybe calling getOffsetToReveal for each viewport will work?

Check this out from showInViewport, this is the case where we determine, this is visible we don't need to make it visible. I don't think you need to do the things in the if clause here, it's jsut an example of how we determined it was visible:

flutter/packages/flutter/lib/src/rendering/viewport.dart

Lines 1248 to 1250 in 023e5ad

if (targetOffset == null) {

// `descendant` is between leading and trailing edge and hence already

// fully shown on screen. No action necessary.

Thanks for the suggestion! Something like this works for me, but I realized RenderAbstractViewport doesn't take into account things like status bar or keyboard. In this case maybe the current implementation of calculating the approximate visible viewport rect might be more accurate, what do you think?

bool? _renderEditableIsVisible(ScrollNotification notification) { RenderAbstractViewport? closestViewport = RenderAbstractViewport.maybeOf(renderEditable); if (closestViewport == null) { return null; } while (closestViewport != null) { final RevealedOffset leadingEdgeOffset = closestViewport.getOffsetToReveal(renderEditable, 0.0); final RevealedOffset trailingEdgeOffset = closestViewport.getOffsetToReveal(renderEditable, 1.0); final double currentOffset = -notification.metrics.pixels; final RevealedOffset? targetOffset = RevealedOffset.clampOffset( leadingEdgeOffset: leadingEdgeOffset, trailingEdgeOffset: trailingEdgeOffset, currentOffset: currentOffset, ); if (targetOffset != null) { // `descendant` is between leading and trailing edge and hence already // fully shown on screen. No action necessary. return false; } closestViewport = RenderAbstractViewport.maybeOf(closestViewport.parent); } return true; }

LongCatIsLooong · 2023-11-28T07:19:39Z

packages/flutter/lib/src/widgets/editable_text.dart

+      if (_valueWhenToolbarShowScheduled != null) {
+        return;
+      }
+      final bool toolbarIsVisible = _selectionOverlay?.toolbarIsVisible ?? false;


looks like toolbarIsVisible also accounts for the spellcheck popup.

Are you using _selectionOverlay?.toolbarIsVisible to tell whether showToolbar was called?

Sorry missed this, I am using it to check if the text selection toolbar is visible. toolbarIsVisible does account for spellcheck popup, do you recommend I add a new API that would tell us if only the text selection toolbar is visible? Another route we could go is save some _showToolbarCalled member.

I think I can just use !_selectionOverlay.spellCheckToolbarIsVisible along with toolbarIsVisible to target the text selection toolbar.

LongCatIsLooong · 2023-11-28T07:25:40Z

packages/flutter/lib/src/widgets/editable_text.dart

-                            clipBehavior: widget.clipBehavior,
+                child: NotificationListener<ScrollNotification>(
+                  onNotification: (ScrollNotification notification) {
+                    _internalScrolling = true;


Looks like _internalScrolling doesn't have to be an instance variable? Making it a parameter would make it slightly easier to understand imo, as the scope of the variable is smaller.

Also why do we need to distinguish internal / parent scrolling?

I decided to distinguish between internal/parent scrolling because when using only ScrollNotificationObserver, EditableText receives internal scrolling updates too late and the context menu is hidden on TextSelectionGestureDetector.onTapDown which prevents the scroll logic from making the toolbar re-appear. onTapDown is dispatched even though the TextSelectionGestureDetector has not won the arena yet. This is due to the default behavior of TapAndDragGestureRecognizer, where it dispatches onTapDown after kPressTimeout = 100ms if no other recognizer has won the arena. When placing the NotificationListener as a direct parent of the internal Scrollable we are able to catch the ScrollNotification in time to beat the kPressTimeout.

NotificationListener doesn't cover parent Scrollables so I ended up using both. The _internalScrolling flag is mainly to prevent duplicate notifications, since ScrollNotificationObserver will still report internal scrolling notifications.

I was able to get rid of the _internalScrolling and the differentiation by just using ScrollNotificationObserver, however doing this makes EditableText unable to receive any scroll notifications unless it has a parent ScrollNotificationObserver (Scaffold has one but if someone doesn't use it they won't be able to take advantage of this feature). If we go with this route we should document these details somewhere. A pro of this solution is that we are able to conditionally listen for internal scrolling events (only listen when the toolbar is shown), versus NotificationListener where we do not have this control.

Using the previous combination of NotificationListener and ScrollNotificationObserver allows EditableText to still listen to its own internal scrollable notifications without a parent ScrollNotificationObserver. To listen to parent scroll events a user would need to place a ScrollNotificationObserver somewhere higher in the tree. I think if we go with this solution we need to document this detail somewhere. I can also remove the use of the local member _internalScrolling with this solution by checking if the notification context is the same as the internal scrollable context.

Maybe another option would be to place ScrollNotificationObserver even higher in the tree in the framework like MaterialApp or WidgetsApp? This would cover a larger range of users.

Curious to hear thoughts on this @LongCatIsLooong @Piinks

Discussed some of this offline, but leaning towards using the combination of NotificationListener and ScrollNotificationObserver so EditableText can get this functionality for it's internal scrollable without having to place a ScrollNotificationObserver as a parent.

LongCatIsLooong · 2023-11-28T07:30:35Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -2800,6 +2808,10 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
  void didChangeDependencies() {
    super.didChangeDependencies();

+    _scrollNotificationObserver?.removeListener(_handleContextMenuOnParentScroll);


Every editable field in the app now needs to add itself as a listener. Can the logic be moved to the context menu or something (I think there was a singleton class since there can be at most one menu visible), or only add itself as the listener when the menu becomes visible?

Also my understanding is this notifies listeners when any descendent scrolls, even when the scrolling scrollable and the active text field are in different subtrees. That probably shouldn't cause the toolbar to disappear as it is not scrolling at all.

Good point about every editable field having to listen, i'll try out your suggestions and see what works best. WRT to ScrollNotificationObserver notifying on every descendant scroll, I tried checking if the EditableTexts context contains the notification.context in this commit e172707. Is there a better way to do this, then looking up the tree?

The documentation states that:

Notifications bubble up through the tree, which means a given NotificationListener will receive notifications for all descendant Scrollable widgets. To focus on notifications from the nearest Scrollable descendant, check that the depth property of the notification is zero.

So I think that means only Scrollables send notifications so you can do that more efficiently by going up the Scrollable tree instead (but you may want to avoid calling Scrollable.of since it establishes a dependency).

Yeah, in this case, you would likely not want to check notification depth and limit it to 0. The depth increases for each nested scrollable.

LongCatIsLooong · 2023-12-21T18:18:02Z

packages/flutter/lib/src/widgets/editable_text.dart

+
+  bool _isInternalScrollableNotification(BuildContext? notificationContext) {
+    final ScrollableState? scrollableState = notificationContext?.findAncestorStateOfType<ScrollableState>();
+    if (_scrollableKey.currentContext == scrollableState?.context) {


return _scrollableKey.currentContext == scrollableState?.context;

LongCatIsLooong · 2023-12-21T18:23:54Z

packages/flutter/lib/src/widgets/editable_text.dart

+    final Size screenSize = MediaQuery.sizeOf(context);
+    final ui.FlutterView view = View.of(context);
+    final double obscuredVertical = (view.padding.top + view.padding.bottom + view.viewInsets.bottom) / view.devicePixelRatio;
+    final double obscuredHorizontal = (view.padding.left + view.padding.right) / view.devicePixelRatio;


nit: view.padding.horizontal

Do you have other plans to update the implementation here? Using the view dimensions is a bit strange, for example when the viewport is not fullscreen.

(Or you could move this to a different PR and always show the edit menu for now)

I don't follow, do you mean when the textfield is inside a viewport that is not the fullscreen?

My thought with the logic here is:

selectionIsVisible tells us if the selection is visible within the RenderEditable.
renderEditableBounds is the Rect for the RenderEditable, if it hasNaN it is likely not laid out.
viewportRect attempts to calculate the device entire viewport with paddings for system overlays.
renderEditableInView checks whether the viewportRect and renderEditableBounds overlap, if they do then the RenderEditable should be visible within the device viewport.

The final check is selectionIsVisible && renderEditableInView which checks if the selection is visible in the RenderEditable and if the RenderEditable is visible within the device viewport.

Ah ok thanks for the explanation! But why do you need to adjust for system overlays? If the menu is too close to system overlays shouldn't it move to the other side of the text field to keep itself visible?

I think it makes more sense to hide the overlay if the RenderEditable itself is not visible. This way the menu still adjusts to avoid the overlays if the text field is visible and hides it when its completely obscured to prevent the menu from overlapping with the system overlays. This seems consistent with the Android behavior.

Taking system overlays into account:
https://github.com/flutter/flutter/assets/948037/f45c9172-0815-4362-bcfd-01b4af02b2d6

Without taking system overlays into account:
https://github.com/flutter/flutter/assets/948037/4fe00dab-eccb-49fa-8627-ef5a2a65f8a3

Jetpack compose behavior:
https://github.com/flutter/flutter/assets/948037/76ca8bce-dc27-4e78-a8d3-4289b636c413

I see the behavior makes sense to me. But the code seems to only check for system UI obstruction, that seems oddly specific. If the text field is obstructed by the outer scroll view would the menu also disappear?

Isn't showOnScreen/showInViewport/or ensureVisible called as part of focusing on a text field and showing the context menu? If so, it should account for the case where a nested scroll view is scrolled out of view by the outer scroll view.

Yeah my implementation of trying to calculate the viewport rect didn't take into account for this case because the viewport is not always the devices fullscreen. I was able to fix this case by going back to your original suggestion @Piinks #138313 (comment) and bubbling through the viewports. I still think we should consider the calculated viewport rect for system overlays like the keyboard.

LongCatIsLooong · 2023-12-21T18:35:57Z

packages/flutter/lib/src/widgets/editable_text.dart

+      }
+      final bool toolbarIsVisible = _selectionOverlay?.toolbarIsVisible ?? false;
+      _valueWhenToolbarShowScheduled = toolbarIsVisible ? _value : null;
+      if (_valueWhenToolbarShowScheduled != null) {


nit: use && instead of nested ifs

I think I can actually remove this nested check considering _valueWhenToolbarShowScheduled is only non-null when toolbarIsVisible.

LongCatIsLooong · 2023-12-27T01:05:25Z

packages/flutter/lib/src/widgets/editable_text.dart

+    if (_isInternalScrollableNotification(notification.context)) {
+      return;
+    }
+    if (!_scrollableNotificationIsFromSameSubtree(notification.context)) {


nit: the implementation of this check is relatively expensive. Consider doing other checks first (e.g., filtering out notifications that aren't start/end.

LongCatIsLooong · 2024-01-03T22:37:36Z

packages/flutter/lib/src/cupertino/text_field.dart

@@ -164,6 +164,14 @@ class _CupertinoTextFieldSelectionGestureDetectorBuilder extends TextSelectionGe
 ///
 /// {@macro flutter.widgets.editableText.showCaretOnScreen}
 ///
+/// ## Scrolling Considerations


nit: empty new line after. Also I think it's usually 3 #'s?

I think they are using 2 #'s from looking at the other TextField/CupertinoTextField/EditableText subsections.

LongCatIsLooong · 2024-01-03T23:26:07Z

packages/flutter/lib/src/cupertino/text_field.dart

+/// When [CupertinoTextField] is placed within a [Scrollable] or within nested
+/// [Scrollable]s, consider placing a [ScrollNotificationObserver] above the
+/// root [Scrollable] to ensure proper scroll coordination for [CupertinoTextField]
+/// and its components like [TextSelectionOverlay]. If a [Scaffold] is present


nit: most of the time this is going to be the case I think? If so maybe move this to the beginning of the paragraph so that it's immediately clear that in most cases it just works.

LongCatIsLooong · 2024-01-03T23:39:27Z

packages/flutter/lib/src/widgets/editable_text.dart

+    // hidden during a scroll on supported platforms.
+    if (_platformSupportsFadeOnScroll) {
+      _scrollNotificationObserver?.removeListener(_handleContextMenuOnParentScroll);
+      _scrollNotificationObserver = ScrollNotificationObserver.maybeOf(context);


ScrollNotificationObserver is an InheritedWidget. You need to update the subscription in didChangeDependencies right?

(Also consider adding a test for that).

LongCatIsLooong · 2024-01-03T23:46:50Z

packages/flutter/lib/src/widgets/editable_text.dart

+    final Size screenSize = MediaQuery.sizeOf(context);
+    final ui.FlutterView view = View.of(context);
+    final double obscuredVertical = (view.padding.top + view.padding.bottom + view.viewInsets.bottom) / view.devicePixelRatio;
+    final double obscuredHorizontal = (view.padding.left + view.padding.right) / view.devicePixelRatio;


Ah ok thanks for the explanation! But why do you need to adjust for system overlays? If the menu is too close to system overlays shouldn't it move to the other side of the text field to keep itself visible?

LongCatIsLooong · 2024-01-03T23:52:34Z

packages/flutter/lib/src/widgets/editable_text.dart

+    // The notification context of a ScrollNotification points to the RawGestureDetector
+    // of the Scrollable. We get the ScrollableState associated with this notification
+    // by looking up the tree.
+    final BuildContext? notificationScrollableContext = notificationContext.findAncestorStateOfType<ScrollableState>()?.context;


nit: you could just compare the ScrollableState?

LongCatIsLooong · 2024-01-04T00:04:38Z

packages/flutter/lib/src/widgets/editable_text.dart

+      if (_valueWhenToolbarShowScheduled != null) {
+        return;
+      }
+      final bool toolbarIsVisible = _selectionOverlay?.toolbarIsVisible ?? false;


Are you using _selectionOverlay?.toolbarIsVisible to tell whether showToolbar was called?

Renzo-Olivares · 2024-01-11T18:26:49Z

A friendly bump

LongCatIsLooong

Sorry looks like I forgot to press the submit review button.

LongCatIsLooong · 2024-01-05T23:36:13Z

packages/flutter/lib/src/material/selectable_text.dart

@@ -163,6 +163,14 @@ class _SelectableTextSelectionGestureDetectorBuilder extends TextSelectionGestur
 /// To make [SelectableText] react to touch events, use callback [onTap] to achieve
 /// the desired behavior.
 ///
+/// ## Scrolling Considerations


nit: needs an extra line.

LongCatIsLooong · 2024-01-05T23:37:58Z

packages/flutter/lib/src/cupertino/text_field.dart

@@ -164,6 +164,18 @@ class _CupertinoTextFieldSelectionGestureDetectorBuilder extends TextSelectionGe
 ///
 /// {@macro flutter.widgets.editableText.showCaretOnScreen}
 ///
+/// ## Scrolling Considerations
+///
+/// If a [Scaffold] is used as the parent of the [Scrollable]s that contain


maybe: If this text field is not a descendant of Scaffold, then consider doing ...., because ....

LongCatIsLooong · 2024-01-05T23:42:07Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -2915,6 +2933,15 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
        hideToolbar();
      }
    }
+
+    if (_scrollNotificationObserver != null) {


You're using ScrollNotificationObserver.maybeOf(context) to get the observer so I think there's a chance for it to be null? So _scrollNotificationObserver != null doesn't seem to be equivalent to "an observer is needed".

This reverts commit e05aa1f2d69b8d0c41201fa3a555b0bd991c5a23.

This reverts commit 7c8161fce4725344f1e20dbd0713455813f5f84c.

…s a chance to update its selection visibilities

…ces (flutter/flutter#138313)

…6066) Manual roll requested by tarrinneal@google.com flutter/flutter@0b5cd50...e6ba809 2024-02-06 engine-flutter-autoroll@skia.org Roll Packages from ae3494d to 1a5a7ce (2 revisions) (flutter/flutter#142985) 2024-02-06 rmolivares@renzo-olivares.dev TextField context menu should fade on scroll on mobile devices (flutter/flutter#138313) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c1b6c98f7f0 to 808886312e2b (1 revision) (flutter/flutter#142959) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bd98bc2fcdf to 9c1b6c98f7f0 (4 revisions) (flutter/flutter#142954) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f34c658b9600 to 9bd98bc2fcdf (1 revision) (flutter/flutter#142950) 2024-02-05 147121557+ShaunByrne-UniSA@users.noreply.github.com Grey out non-selectable days in CupertinoDatePicker (flutter/flutter#136181) 2024-02-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/flutter#142944) 2024-02-05 magder@google.com Run examples_smoke_test on Linux (flutter/flutter#142736) 2024-02-05 233583+mossmana@users.noreply.github.com Update AGP version validation code to support KGP and kotlin build files. (flutter/flutter#142357) 2024-02-05 dustbin4ever@gmail.com Fixed test in language_version_test.dart that failed when shuffling, â�¦ (flutter/flutter#142904) 2024-02-05 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging (flutter/flutter#142918) 2024-02-05 engine-flutter-autoroll@skia.org Roll Packages from d37fb0a to ae3494d (3 revisions) (flutter/flutter#142915) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ces (flutter/flutter#138313)

…lutter#6066) Manual roll requested by tarrinneal@google.com flutter/flutter@0b5cd50...e6ba809 2024-02-06 engine-flutter-autoroll@skia.org Roll Packages from ae3494d to 1a5a7ce (2 revisions) (flutter/flutter#142985) 2024-02-06 rmolivares@renzo-olivares.dev TextField context menu should fade on scroll on mobile devices (flutter/flutter#138313) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c1b6c98f7f0 to 808886312e2b (1 revision) (flutter/flutter#142959) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bd98bc2fcdf to 9c1b6c98f7f0 (4 revisions) (flutter/flutter#142954) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f34c658b9600 to 9bd98bc2fcdf (1 revision) (flutter/flutter#142950) 2024-02-05 147121557+ShaunByrne-UniSA@users.noreply.github.com Grey out non-selectable days in CupertinoDatePicker (flutter/flutter#136181) 2024-02-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/flutter#142944) 2024-02-05 magder@google.com Run examples_smoke_test on Linux (flutter/flutter#142736) 2024-02-05 233583+mossmana@users.noreply.github.com Update AGP version validation code to support KGP and kotlin build files. (flutter/flutter#142357) 2024-02-05 dustbin4ever@gmail.com Fixed test in language_version_test.dart that failed when shuffling, â�¦ (flutter/flutter#142904) 2024-02-05 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging (flutter/flutter#142918) 2024-02-05 engine-flutter-autoroll@skia.org Roll Packages from d37fb0a to ae3494d (3 revisions) (flutter/flutter#142915) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 12, 2023

Renzo-Olivares force-pushed the textfield-fade-scroll branch from 6535596 to 24d482b Compare November 13, 2023 21:17

Renzo-Olivares requested a review from LongCatIsLooong November 13, 2023 21:39

LongCatIsLooong reviewed Nov 14, 2023

View reviewed changes

packages/flutter/lib/src/widgets/editable_text.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/widgets/editable_text.dart Show resolved Hide resolved

Renzo-Olivares force-pushed the textfield-fade-scroll branch from bdaed6f to a0d6aff Compare November 20, 2023 12:40

github-actions bot added the f: gestures flutter/packages/flutter/gestures repository. label Nov 20, 2023

Renzo-Olivares requested review from Piinks and LongCatIsLooong November 20, 2023 18:28

Renzo-Olivares commented Nov 20, 2023

View reviewed changes

LongCatIsLooong reviewed Nov 22, 2023

View reviewed changes

Piinks reviewed Nov 27, 2023

View reviewed changes

LongCatIsLooong reviewed Nov 28, 2023

View reviewed changes

Renzo-Olivares force-pushed the textfield-fade-scroll branch 2 times, most recently from d2277d6 to 8b25fb4 Compare November 29, 2023 00:45

Renzo-Olivares force-pushed the textfield-fade-scroll branch from 8b25fb4 to 3111a5a Compare December 13, 2023 19:23

github-actions bot added f: cupertino flutter/packages/flutter/cupertino repository and removed f: gestures flutter/packages/flutter/gestures repository. labels Dec 13, 2023

Renzo-Olivares requested a review from LongCatIsLooong December 15, 2023 01:04

LongCatIsLooong reviewed Dec 27, 2023

View reviewed changes

Renzo-Olivares force-pushed the textfield-fade-scroll branch from b603d17 to 61b1cec Compare January 2, 2024 22:32

Renzo-Olivares requested a review from LongCatIsLooong January 3, 2024 21:51

LongCatIsLooong reviewed Jan 4, 2024

View reviewed changes

Renzo-Olivares force-pushed the textfield-fade-scroll branch 2 times, most recently from dfc4638 to db15661 Compare January 5, 2024 22:05

Renzo-Olivares requested a review from LongCatIsLooong January 5, 2024 22:08

LongCatIsLooong reviewed Jan 16, 2024

View reviewed changes

Renzo-Olivares force-pushed the textfield-fade-scroll branch from ad0a63e to a74b189 Compare January 17, 2024 19:43

Renzo-Olivares added 16 commits February 5, 2024 19:44

Add getOffset to RenderAbstractViewport

b227944

Add tests for getOffset

97b92c8

updates

f09cf33

updates

828a78d

adjust renderEditable visibility logic

bf87f25

Revert "Add tests for getOffset"

d229165

This reverts commit e05aa1f2d69b8d0c41201fa3a555b0bd991c5a23.

Revert "Add getOffset to RenderAbstractViewport"

5dcc2ad

This reverts commit 7c8161fce4725344f1e20dbd0713455813f5f84c.

updates

d3bcbef

use selection rects instead of renderEditable.paintBounds

f4d47fe

Address reviewer comments

79581ea

address comments

104fb40

handle case when selection is collapsed

ebd0aac

schedule scroll end logic in post frame callback so renderEditable ha…

5010c32

…s a chance to update its selection visibilities

address review comments

5998092

clean up

d8c11de

updates

9179948

Renzo-Olivares force-pushed the textfield-fade-scroll branch from 56b314e to 9179948 Compare February 6, 2024 03:44

auto-submit bot merged commit 0903bf7 into flutter:master Feb 6, 2024
69 checks passed

engine-flutter-autoroll mentioned this pull request Feb 6, 2024

Roll Flutter from 0b5cd5073a3b to 0903bf7055d3 (11 revisions) flutter/packages#6064

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2024

0903bf705 TextField context menu should fade on scroll on mobile devi…

39c2391

…ces (flutter/flutter#138313)

engine-flutter-autoroll mentioned this pull request Feb 6, 2024

Roll Flutter from 0b5cd5073a3b to e6ba809b8a23 (12 revisions) flutter/packages#6065

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2024

0903bf705 TextField context menu should fade on scroll on mobile devi…

24d401d

…ces (flutter/flutter#138313)

engine-flutter-autoroll mentioned this pull request Feb 6, 2024

Manual roll Flutter from 0b5cd5073a3b to e6ba809b8a23 (12 revisions) flutter/packages#6066

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2024

0903bf705 TextField context menu should fade on scroll on mobile devi…

1411661

…ces (flutter/flutter#138313)

engine-flutter-autoroll mentioned this pull request Feb 6, 2024

Roll Flutter from 0b5cd5073a3b to e6ba809b8a23 (12 revisions) flutter/packages#6067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2024

0903bf705 TextField context menu should fade on scroll on mobile devi…

c999f51

…ces (flutter/flutter#138313)

HansMuller mentioned this pull request Feb 9, 2024

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

0903bf705 TextField context menu should fade on scroll on mobile devi…

7de77c6

…ces (flutter/flutter#138313)

	if (targetOffset == null) {
	// `descendant` is between leading and trailing edge and hence already
	// fully shown on screen. No action necessary.

TextField context menu should fade on scroll on mobile devices #138313

TextField context menu should fade on scroll on mobile devices #138313

Conversation

Renzo-Olivares commented Nov 12, 2023 • edited Loading

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Nov 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LongCatIsLooong Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LongCatIsLooong Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares commented Jan 11, 2024

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares commented Nov 12, 2023 •

edited

Loading

Renzo-Olivares Nov 22, 2023 •

edited

Loading

Renzo-Olivares Jan 4, 2024 •

edited

Loading

Renzo-Olivares Nov 28, 2023 •

edited

Loading

LongCatIsLooong Nov 28, 2023 •

edited

Loading

LongCatIsLooong Nov 28, 2023 •

edited

Loading

Renzo-Olivares Jan 2, 2024 •

edited

Loading