Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemanticOwner should dispatch creation and disposal events #138388

Merged
merged 3 commits into from Nov 15, 2023
Merged

SemanticOwner should dispatch creation and disposal events #138388

merged 3 commits into from Nov 15, 2023

Conversation

droidbg
Copy link
Contributor

@droidbg droidbg commented Nov 14, 2023

Description

Adds SemanticOwner creation and disposal dispatching for memory leak tracking as part of #137311

Tests

  • Updates semantics_test.dart to test SemanticOwner object creation and disposal dispatching.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Nov 14, 2023
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Nov 15, 2023
@droidbg droidbg marked this pull request as ready for review November 15, 2023 08:15
@polina-c polina-c merged commit 684980e into flutter:master Nov 15, 2023
68 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
684980e97 SemanticOwner should dispatch creation and disposal events (f…
2d9381f 
…lutter/flutter#138388)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
684980e97 SemanticOwner should dispatch creation and disposal events (f…
fc19947 
…lutter/flutter#138388)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
684980e97 SemanticOwner should dispatch creation and disposal events (f…
21e8438 
…lutter/flutter#138388)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2023
@engine-flutter-autoroll
684980e97 SemanticOwner should dispatch creation and disposal events (f…
941d80c 
…lutter/flutter#138388)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 16, 2023
@engine-flutter-autoroll
Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions) (#5412)
52a5342 
Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions)

flutter/flutter@e8c2bb1...53a57ad

2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (flutter/flutter#138543)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (flutter/flutter#138533)
2023-11-16 leroux_bruno@yahoo.fr [flutter_tools] - Add `queries` section to Android manifest file (flutter/flutter#137207)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (flutter/flutter#138532)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (flutter/flutter#138529)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (flutter/flutter#138515)
2023-11-15 42216813+eliasyishak@users.noreply.github.com Catch error for missing directory in `FontConfigManager` (flutter/flutter#138496)
2023-11-15 bernaferrari2@gmail.com Make `UnderlineInputBorder` consistent (flutter/flutter#124153)
2023-11-15 gspencergoog@users.noreply.github.com Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (flutter/flutter#136854)
2023-11-15 58529443+srujzs@users.noreply.github.com Pin package:web 0.4.0 (flutter/flutter#138428)
2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland VelocityTracker update (#132291)" (flutter/flutter#138512)
2023-11-15 yjbanov@google.com [web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (flutter/flutter#138498)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (flutter/flutter#138502)
2023-11-15 katelovett@google.com Reland VelocityTracker update (#132291) (flutter/flutter#137381)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (flutter/flutter#138499)
2023-11-15 katelovett@google.com Fix 2D tap to stop scrolling (flutter/flutter#138442)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (flutter/flutter#138494)
2023-11-15 41873024+droidbg@users.noreply.github.com SemanticOwner should dispatch creation and disposal events (flutter/flutter#138388)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (flutter/flutter#138489)
2023-11-15 engine-flutter-autoroll@skia.org Roll Packages from 428ba3e to 0cd2378 (1 revision) (flutter/flutter#138482)
2023-11-15 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (flutter/flutter#138472)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (flutter/flutter#138468)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (flutter/flutter#138463)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (flutter/flutter#138462)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (flutter/flutter#138459)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (flutter/flutter#138457)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (flutter/flutter#138456)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (flutter/flutter#138452)
2023-11-15 xubaolin@oppo.com Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136871)
2023-11-14 katelovett@google.com Add to TableCell docs (flutter/flutter#138258)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (flutter/flutter#138441)
2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.1 to 5.0.0 (flutter/flutter#138437)
2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.6 (flutter/flutter#138438)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (flutter/flutter#138429)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (flutter/flutter#138425)
2023-11-14 42216813+eliasyishak@users.noreply.github.com Unified analytics migration for `CodeSizeAnalysis` (flutter/flutter#138351)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (flutter/flutter#138421)
2023-11-14 goderbauer@google.com Run all tests in examples/ (flutter/flutter#138374)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (flutter/flutter#138420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

...
@HansMuller HansMuller mentioned this pull request Nov 17, 2023
Open
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Nov 27, 2023
@droidbg @Markzipan
SemanticOwner should dispatch creation and disposal events (flutter#1…
416d9a9 
…38388)
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions) (flutte…
d5934bb 
…r#5412)

Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions)

flutter/flutter@e8c2bb1...53a57ad

2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (flutter/flutter#138543)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (flutter/flutter#138533)
2023-11-16 leroux_bruno@yahoo.fr [flutter_tools] - Add `queries` section to Android manifest file (flutter/flutter#137207)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (flutter/flutter#138532)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (flutter/flutter#138529)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (flutter/flutter#138515)
2023-11-15 42216813+eliasyishak@users.noreply.github.com Catch error for missing directory in `FontConfigManager` (flutter/flutter#138496)
2023-11-15 bernaferrari2@gmail.com Make `UnderlineInputBorder` consistent (flutter/flutter#124153)
2023-11-15 gspencergoog@users.noreply.github.com Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (flutter/flutter#136854)
2023-11-15 58529443+srujzs@users.noreply.github.com Pin package:web 0.4.0 (flutter/flutter#138428)
2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland VelocityTracker update (#132291)" (flutter/flutter#138512)
2023-11-15 yjbanov@google.com [web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (flutter/flutter#138498)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (flutter/flutter#138502)
2023-11-15 katelovett@google.com Reland VelocityTracker update (#132291) (flutter/flutter#137381)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (flutter/flutter#138499)
2023-11-15 katelovett@google.com Fix 2D tap to stop scrolling (flutter/flutter#138442)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (flutter/flutter#138494)
2023-11-15 41873024+droidbg@users.noreply.github.com SemanticOwner should dispatch creation and disposal events (flutter/flutter#138388)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (flutter/flutter#138489)
2023-11-15 engine-flutter-autoroll@skia.org Roll Packages from 428ba3e to 0cd2378 (1 revision) (flutter/flutter#138482)
2023-11-15 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (flutter/flutter#138472)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (flutter/flutter#138468)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (flutter/flutter#138463)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (flutter/flutter#138462)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (flutter/flutter#138459)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (flutter/flutter#138457)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (flutter/flutter#138456)
2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (flutter/flutter#138452)
2023-11-15 xubaolin@oppo.com Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136871)
2023-11-14 katelovett@google.com Add to TableCell docs (flutter/flutter#138258)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (flutter/flutter#138441)
2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.1 to 5.0.0 (flutter/flutter#138437)
2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.6 (flutter/flutter#138438)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (flutter/flutter#138429)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (flutter/flutter#138425)
2023-11-14 42216813+eliasyishak@users.noreply.github.com Unified analytics migration for `CodeSizeAnalysis` (flutter/flutter#138351)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (flutter/flutter#138421)
2023-11-14 goderbauer@google.com Run all tests in examples/ (flutter/flutter#138374)
2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (flutter/flutter#138420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
684980e97 SemanticOwner should dispatch creation and disposal events (f…
04bf613 
…lutter/flutter#138388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@droidbg @polina-c