Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line parameter that turns on leak tracking. #138653

Merged
merged 7 commits into from Jan 2, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 18, 2023

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 18, 2023
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c
Copy link
Contributor Author

@godofredoc, can you review to make sure it is a right way to parameterize tests, to enable (1) use cases we discussed on Friday and (2) users to run with and without leak tracking?

@polina-c
Copy link
Contributor Author

@keyonghan

Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2023
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env variable name LGTM.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants