Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated TextTheme members #139255

Merged
merged 20 commits into from
Mar 28, 2024
Merged

Remove deprecated TextTheme members #139255

merged 20 commits into from
Mar 28, 2024

Conversation

Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Nov 29, 2023 •
edited
Loading

Part of: #143956

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 29, 2023
@Renzo-Olivares Renzo-Olivares force-pushed the texttheme-deprecations branch 2 times, most recently from 8750635 to adf1d44 Compare December 5, 2023 20:45
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. and removed a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 5, 2023
@Renzo-Olivares Renzo-Olivares force-pushed the texttheme-deprecations branch 2 times, most recently from e3aeb5c to 6814531 Compare December 11, 2023 20:59
Piinks
Piinks approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Renzo-Olivares Renzo-Olivares marked this pull request as draft January 9, 2024 21:13
@Renzo-Olivares Renzo-Olivares force-pushed the texttheme-deprecations branch 3 times, most recently from f8da980 to e40cbb2 Compare March 6, 2024 05:49
@Renzo-Olivares Renzo-Olivares marked this pull request as ready for review March 6, 2024 09:33
@Renzo-Olivares Renzo-Olivares force-pushed the texttheme-deprecations branch 2 times, most recently from 7b53a87 to fbce4a7 Compare March 18, 2024 19:07
@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 26, 2024
@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2024
@auto-submit auto-submit bot merged commit f5b65ba into flutter:master Mar 28, 2024
67 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
40e5d33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
f0b2ad6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
e9c6252
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
23b9e0c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
f8e0aee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
9174a39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
368016f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
85a4dac
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions) (#…
fbf44e2 
…6431)

Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions)

Manual roll requested by dit@google.com

flutter/flutter@dbdcead...89ea492

2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71e5ad8586b to a396dc1a03a9 (3 revisions) (flutter/flutter#145928)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 043af350ae85 to f71e5ad8586b (1 revision) (flutter/flutter#145919)
2024-03-28 103135467+sealesj@users.noreply.github.com Refactor skp_generator_tests (flutter/flutter#145871)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c9d5adb6ff8 to 043af350ae85 (2 revisions) (flutter/flutter#145917)
2024-03-28 tessertaha@gmail.com Update `TabBar` and `TabBar.secondary` to use indicator height/color M3 tokens (flutter/flutter#145753)
2024-03-28 engine-flutter-autoroll@skia.org Roll Packages from e6b3e11 to 924c7e6 (5 revisions) (flutter/flutter#145915)
2024-03-28 mdebbar@google.com Add `viewId` to `TextInputConfiguration` (flutter/flutter#145708)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9df2d3a0778e to 7c9d5adb6ff8 (3 revisions) (flutter/flutter#145909)
2024-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from c602abdbae16 to 9df2d3a0778e (10 revisions) (flutter/flutter#145903)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (#145877)" (flutter/flutter#145901)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (#145879)" (flutter/flutter#145900)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (flutter/flutter#145879)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (flutter/flutter#145877)
2024-03-28 rmolivares@renzo-olivares.dev Remove deprecated `TextTheme` members (flutter/flutter#139255)
2024-03-27 maRci002@users.noreply.github.com [WIP] Predictive back support for routes (flutter/flutter#141373)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73c145c9ac3a to c602abdbae16 (1 revision) (flutter/flutter#145865)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d65662541682 to 73c145c9ac3a (8 revisions) (flutter/flutter#145862)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7dddee939f2 to d65662541682 (2 revisions) (flutter/flutter#145851)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00dab0d9d310 to b7dddee939f2 (2 revisions) (flutter/flutter#145841)
2024-03-27 engine-flutter-autoroll@skia.org Roll Packages from ab1630b to e6b3e11 (6 revisions) (flutter/flutter#145833)
2024-03-27 103135467+sealesj@users.noreply.github.com Refactor web long running tests (flutter/flutter#145776)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from da64c6bcbbb6 to 00dab0d9d310 (1 revision) (flutter/flutter#145830)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6c6ba5aa157 to da64c6bcbbb6 (1 revision) (flutter/flutter#145811)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 064a4f5d9042 to d6c6ba5aa157 (1 revision) (flutter/flutter#145807)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cad8e7a9ad70 to 064a4f5d9042 (1 revision) (flutter/flutter#145805)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 441005698702 to cad8e7a9ad70 (1 revision) (flutter/flutter#145804)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d872d50e53f4 to 441005698702 (1 revision) (flutter/flutter#145803)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92ebd47dd8a8 to d872d50e53f4 (6 revisions) (flutter/flutter#145801)
2024-03-27 godofredoc@google.com Update localization files. (flutter/flutter#145780)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 026d8902e3b5 to 92ebd47dd8a8 (1 revision) (flutter/flutter#145788)
2024-03-26 ditman@gmail.com [web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. (flutter/flutter#145786)
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.1.0 to 4.1.1 (flutter/flutter#145787)
2024-03-26 christopherfujino@gmail.com Roll pub packages and regenerate gradle lockfiles (flutter/flutter#145727)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c7aea6f20fc to 026d8902e3b5 (1 revision) (flutter/flutter#145785)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from baede78d2352 to 5c7aea6f20fc (2 revisions) (flutter/flutter#145784)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from cffd1dcfe6a5 to baede78d2352 (2 revisions) (flutter/flutter#145778)
2024-03-26 dwzrlp@163.com Correct typo: "Free" to "Three" in comments (flutter/flutter#145689)
2024-03-26 tessertaha@gmail.com Fix disabled `DropdownMenu` doesn't defer the mouse cursor (flutter/flutter#145686)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d93a64cbc7 to cffd1dcfe6a5 (9 revisions) (flutter/flutter#145773)
2024-03-26 engine-flutter-autoroll@skia.org Roll Packages from 28d126c to ab1630b (1 revision) (flutter/flutter#145755)
2024-03-26 sokolovskyi.konstantin@gmail.com Memory leaks clean up 2 (flutter/flutter#145757)
2024-03-26 sokolovskyi.konstantin@gmail.com Fix memory leak in Overlay.wrap. (flutter/flutter#145744)
2024-03-26 jacksongardner@google.com Be tolerant of backticks around directory name in `pub` output. (flutter/flutter#145768)
2024-03-26 tessertaha@gmail.com Fix `ExpansionTile` Expanded/Collapsed announcement is interrupted by VoiceOver (flutter/flutter#143936)
...
@HansMuller HansMuller mentioned this pull request Mar 29, 2024
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
f5b65bad0 Remove deprecated TextTheme members (flutter/flutter#139255)
a41ac9f
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions) (f…
7f61172 
…lutter#6431)

Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions)

Manual roll requested by dit@google.com

flutter/flutter@dbdcead...89ea492

2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71e5ad8586b to a396dc1a03a9 (3 revisions) (flutter/flutter#145928)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 043af350ae85 to f71e5ad8586b (1 revision) (flutter/flutter#145919)
2024-03-28 103135467+sealesj@users.noreply.github.com Refactor skp_generator_tests (flutter/flutter#145871)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c9d5adb6ff8 to 043af350ae85 (2 revisions) (flutter/flutter#145917)
2024-03-28 tessertaha@gmail.com Update `TabBar` and `TabBar.secondary` to use indicator height/color M3 tokens (flutter/flutter#145753)
2024-03-28 engine-flutter-autoroll@skia.org Roll Packages from e6b3e11 to 924c7e6 (5 revisions) (flutter/flutter#145915)
2024-03-28 mdebbar@google.com Add `viewId` to `TextInputConfiguration` (flutter/flutter#145708)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9df2d3a0778e to 7c9d5adb6ff8 (3 revisions) (flutter/flutter#145909)
2024-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from c602abdbae16 to 9df2d3a0778e (10 revisions) (flutter/flutter#145903)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (#145877)" (flutter/flutter#145901)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (#145879)" (flutter/flutter#145900)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (flutter/flutter#145879)
2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (flutter/flutter#145877)
2024-03-28 rmolivares@renzo-olivares.dev Remove deprecated `TextTheme` members (flutter/flutter#139255)
2024-03-27 maRci002@users.noreply.github.com [WIP] Predictive back support for routes (flutter/flutter#141373)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73c145c9ac3a to c602abdbae16 (1 revision) (flutter/flutter#145865)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d65662541682 to 73c145c9ac3a (8 revisions) (flutter/flutter#145862)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7dddee939f2 to d65662541682 (2 revisions) (flutter/flutter#145851)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00dab0d9d310 to b7dddee939f2 (2 revisions) (flutter/flutter#145841)
2024-03-27 engine-flutter-autoroll@skia.org Roll Packages from ab1630b to e6b3e11 (6 revisions) (flutter/flutter#145833)
2024-03-27 103135467+sealesj@users.noreply.github.com Refactor web long running tests (flutter/flutter#145776)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from da64c6bcbbb6 to 00dab0d9d310 (1 revision) (flutter/flutter#145830)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6c6ba5aa157 to da64c6bcbbb6 (1 revision) (flutter/flutter#145811)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 064a4f5d9042 to d6c6ba5aa157 (1 revision) (flutter/flutter#145807)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cad8e7a9ad70 to 064a4f5d9042 (1 revision) (flutter/flutter#145805)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 441005698702 to cad8e7a9ad70 (1 revision) (flutter/flutter#145804)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from d872d50e53f4 to 441005698702 (1 revision) (flutter/flutter#145803)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92ebd47dd8a8 to d872d50e53f4 (6 revisions) (flutter/flutter#145801)
2024-03-27 godofredoc@google.com Update localization files. (flutter/flutter#145780)
2024-03-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 026d8902e3b5 to 92ebd47dd8a8 (1 revision) (flutter/flutter#145788)
2024-03-26 ditman@gmail.com [web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. (flutter/flutter#145786)
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.1.0 to 4.1.1 (flutter/flutter#145787)
2024-03-26 christopherfujino@gmail.com Roll pub packages and regenerate gradle lockfiles (flutter/flutter#145727)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c7aea6f20fc to 026d8902e3b5 (1 revision) (flutter/flutter#145785)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from baede78d2352 to 5c7aea6f20fc (2 revisions) (flutter/flutter#145784)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from cffd1dcfe6a5 to baede78d2352 (2 revisions) (flutter/flutter#145778)
2024-03-26 dwzrlp@163.com Correct typo: "Free" to "Three" in comments (flutter/flutter#145689)
2024-03-26 tessertaha@gmail.com Fix disabled `DropdownMenu` doesn't defer the mouse cursor (flutter/flutter#145686)
2024-03-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d93a64cbc7 to cffd1dcfe6a5 (9 revisions) (flutter/flutter#145773)
2024-03-26 engine-flutter-autoroll@skia.org Roll Packages from 28d126c to ab1630b (1 revision) (flutter/flutter#145755)
2024-03-26 sokolovskyi.konstantin@gmail.com Memory leaks clean up 2 (flutter/flutter#145757)
2024-03-26 sokolovskyi.konstantin@gmail.com Fix memory leak in Overlay.wrap. (flutter/flutter#145744)
2024-03-26 jacksongardner@google.com Be tolerant of backticks around directory name in `pub` output. (flutter/flutter#145768)
2024-03-26 tessertaha@gmail.com Fix `ExpansionTile` Expanded/Collapsed announcement is interrupted by VoiceOver (flutter/flutter#143936)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Renzo-Olivares @Piinks