New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo of 'not' instead of 'now' for useInheritedMediaQuery
#139940
Merged
auto-submit
merged 1 commit into
flutter:master
from
timmaffett:useInheritedMediaQuery_typo
Dec 11, 2023
Merged
fix typo of 'not' instead of 'now' for useInheritedMediaQuery
#139940
auto-submit
merged 1 commit into
flutter:master
from
timmaffett:useInheritedMediaQuery_typo
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
flutter/packages/flutter repository. See also f: labels.
label
Dec 11, 2023
goderbauer
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spotting and fixing this!
LGTM
loic-sharma
approved these changes
Dec 11, 2023
goderbauer
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Dec 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 13, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 13, 2023
Roll Flutter from 97190973d6f5 to 11a9cb7029d7 (32 revisions) flutter/flutter@9719097...11a9cb7 2023-12-13 ian@hixie.ch Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (flutter/flutter#139549) 2023-12-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.9 to 2.22.10 (flutter/flutter#140003) 2023-12-12 34871572+gmackall@users.noreply.github.com Allow plugins to use compileSdkPreview (flutter/flutter#131901) 2023-12-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139995) 2023-12-12 15619084+vashworth@users.noreply.github.com Select simulator runtime for tests based on Xcode's preferred runtime build (flutter/flutter#139919) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c527aa1a215 to 9039ac78cf03 (1 revision) (flutter/flutter#139992) 2023-12-12 pateltirth454@gmail.com [Docs] Added missing `CupertinoApp.showSemanticsDebugger` (flutter/flutter#139913) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 444281eb5c7c to 0c527aa1a215 (2 revisions) (flutter/flutter#139985) 2023-12-12 jason-simmons@users.noreply.github.com Update Gallery lockfiles for the new version of the video_player plugin (flutter/flutter#139832) 2023-12-12 engine-flutter-autoroll@skia.org Roll Packages from cb6dbcd to 80aa46a (5 revisions) (flutter/flutter#139982) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b77b1b7b42f to 444281eb5c7c (1 revision) (flutter/flutter#139979) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8e87ed193f5 to 3b77b1b7b42f (1 revision) (flutter/flutter#139977) 2023-12-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139969) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4102c7daf1d3 to f8e87ed193f5 (3 revisions) (flutter/flutter#139963) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95dfb1d4ac75 to 4102c7daf1d3 (1 revision) (flutter/flutter#139961) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40bfd2dc1519 to 95dfb1d4ac75 (1 revision) (flutter/flutter#139959) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 061ae7023f10 to 40bfd2dc1519 (2 revisions) (flutter/flutter#139958) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75cfb050cd9a to 061ae7023f10 (1 revision) (flutter/flutter#139955) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 362d0cb3ab27 to 75cfb050cd9a (1 revision) (flutter/flutter#139954) 2023-12-12 gspencergoog@users.noreply.github.com Fix dayPeriodColor handling of non-MaterialStateColors (flutter/flutter#139845) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea1a3069e057 to 362d0cb3ab27 (1 revision) (flutter/flutter#139951) 2023-12-12 xilaizhang@google.com [github actions] Automate Flutter Chery Picks (flutter/flutter#139524) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d001419b436e to ea1a3069e057 (5 revisions) (flutter/flutter#139948) 2023-12-12 christopherfujino@gmail.com [flutter_tools] catch SocketException writing to ios-deploy stdin (flutter/flutter#139784) 2023-12-11 chillers@google.com [ci.yaml] Add missing ci.yaml to runIf of android hot reload tests (flutter/flutter#139932) 2023-12-11 christopherfujino@gmail.com make the tar c command in prepare_package.dart verbose (flutter/flutter#139687) 2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c1f13e1e535 to d001419b436e (4 revisions) (flutter/flutter#139941) 2023-12-11 timmaffett@gmail.com fix typo of 'not' instead of 'now' for `useInheritedMediaQuery` (flutter/flutter#139940) 2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4c309195b79d to 5c1f13e1e535 (2 revisions) (flutter/flutter#139939) 2023-12-11 nathan.wilson1232@gmail.com Implement `switch` expressions in `examples/` and `animation/` (flutter/flutter#139882) 2023-12-11 pateltirth454@gmail.com Renamed `appbar` to `app_bar` directory in API Examples Tests (flutter/flutter#139922) 2023-12-11 gspencergoog@users.noreply.github.com Deprecate `RawKeyEvent`, `RawKeyboard`, et al. (flutter/flutter#136677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
foxtrotravi
pushed a commit
to foxtrotravi/packages
that referenced
this pull request
Dec 14, 2023
…r#5665) Roll Flutter from 97190973d6f5 to 11a9cb7029d7 (32 revisions) flutter/flutter@9719097...11a9cb7 2023-12-13 ian@hixie.ch Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (flutter/flutter#139549) 2023-12-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.9 to 2.22.10 (flutter/flutter#140003) 2023-12-12 34871572+gmackall@users.noreply.github.com Allow plugins to use compileSdkPreview (flutter/flutter#131901) 2023-12-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139995) 2023-12-12 15619084+vashworth@users.noreply.github.com Select simulator runtime for tests based on Xcode's preferred runtime build (flutter/flutter#139919) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c527aa1a215 to 9039ac78cf03 (1 revision) (flutter/flutter#139992) 2023-12-12 pateltirth454@gmail.com [Docs] Added missing `CupertinoApp.showSemanticsDebugger` (flutter/flutter#139913) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 444281eb5c7c to 0c527aa1a215 (2 revisions) (flutter/flutter#139985) 2023-12-12 jason-simmons@users.noreply.github.com Update Gallery lockfiles for the new version of the video_player plugin (flutter/flutter#139832) 2023-12-12 engine-flutter-autoroll@skia.org Roll Packages from cb6dbcd to 80aa46a (5 revisions) (flutter/flutter#139982) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b77b1b7b42f to 444281eb5c7c (1 revision) (flutter/flutter#139979) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8e87ed193f5 to 3b77b1b7b42f (1 revision) (flutter/flutter#139977) 2023-12-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139969) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4102c7daf1d3 to f8e87ed193f5 (3 revisions) (flutter/flutter#139963) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95dfb1d4ac75 to 4102c7daf1d3 (1 revision) (flutter/flutter#139961) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40bfd2dc1519 to 95dfb1d4ac75 (1 revision) (flutter/flutter#139959) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 061ae7023f10 to 40bfd2dc1519 (2 revisions) (flutter/flutter#139958) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75cfb050cd9a to 061ae7023f10 (1 revision) (flutter/flutter#139955) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 362d0cb3ab27 to 75cfb050cd9a (1 revision) (flutter/flutter#139954) 2023-12-12 gspencergoog@users.noreply.github.com Fix dayPeriodColor handling of non-MaterialStateColors (flutter/flutter#139845) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea1a3069e057 to 362d0cb3ab27 (1 revision) (flutter/flutter#139951) 2023-12-12 xilaizhang@google.com [github actions] Automate Flutter Chery Picks (flutter/flutter#139524) 2023-12-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d001419b436e to ea1a3069e057 (5 revisions) (flutter/flutter#139948) 2023-12-12 christopherfujino@gmail.com [flutter_tools] catch SocketException writing to ios-deploy stdin (flutter/flutter#139784) 2023-12-11 chillers@google.com [ci.yaml] Add missing ci.yaml to runIf of android hot reload tests (flutter/flutter#139932) 2023-12-11 christopherfujino@gmail.com make the tar c command in prepare_package.dart verbose (flutter/flutter#139687) 2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c1f13e1e535 to d001419b436e (4 revisions) (flutter/flutter#139941) 2023-12-11 timmaffett@gmail.com fix typo of 'not' instead of 'now' for `useInheritedMediaQuery` (flutter/flutter#139940) 2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4c309195b79d to 5c1f13e1e535 (2 revisions) (flutter/flutter#139939) 2023-12-11 nathan.wilson1232@gmail.com Implement `switch` expressions in `examples/` and `animation/` (flutter/flutter#139882) 2023-12-11 pateltirth454@gmail.com Renamed `appbar` to `app_bar` directory in API Examples Tests (flutter/flutter#139922) 2023-12-11 gspencergoog@users.noreply.github.com Deprecate `RawKeyEvent`, `RawKeyboard`, et al. (flutter/flutter#136677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Michal-MK
pushed a commit
to Michal-MK/flutter
that referenced
this pull request
Jan 8, 2024
…ter#139940) The doc comment for `useInheritedMediaQuery` has a typo of 'not' instead of 'now' and it is confusing at the `@Deprecated()` message clearly states it is *now* ignored. (and indeed checking the code you can verify that it *is* indeed ignored) existing code before PR: ```dart /// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery} /// Deprecated. This setting is not ignored. /// ^^^ /// The widget never introduces its own [MediaQuery]; the [View] widget takes /// care of that. /// {@endtemplate} @deprecated( 'This setting is now ignored. ' 'WidgetsApp never introduces its own MediaQuery; the View widget takes care of that. ' 'This feature was deprecated after v3.7.0-29.0.pre.' ) final bool useInheritedMediaQuery; ``` - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
Markzipan
pushed a commit
to Markzipan/flutter
that referenced
this pull request
Jan 9, 2024
…ter#139940) The doc comment for `useInheritedMediaQuery` has a typo of 'not' instead of 'now' and it is confusing at the `@Deprecated()` message clearly states it is *now* ignored. (and indeed checking the code you can verify that it *is* indeed ignored) existing code before PR: ```dart /// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery} /// Deprecated. This setting is not ignored. /// ^^^ /// The widget never introduces its own [MediaQuery]; the [View] widget takes /// care of that. /// {@endtemplate} @deprecated( 'This setting is now ignored. ' 'WidgetsApp never introduces its own MediaQuery; the View widget takes care of that. ' 'This feature was deprecated after v3.7.0-29.0.pre.' ) final bool useInheritedMediaQuery; ``` - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc comment for
useInheritedMediaQuery
has a typo of 'not' instead of 'now' and it is confusing at the@Deprecated()
message clearly states it is now ignored.(and indeed checking the code you can verify that it is indeed ignored)
existing code before PR:
Pre-launch Checklist
///
).