Use SemanticsUpdateBuilder again, remove all references to temporary SemanticsUpdateBuilderNew
#139942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
|
It'll likely fail now since we have to wait for engine to roll into framework. |
bartekpacia
force-pushed
the
chore/semantics_update_builder_migration_part4
branch
from
3e49e5d
to
639da3f
Compare
bartekpacia
added
the
autosubmit
bartekpacia
force-pushed
the
chore/semantics_update_builder_migration_part4
branch
from
639da3f
to
7165b75
Compare
|
auto label is removed for flutter/flutter/139942, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
bartekpacia
force-pushed
the
chore/semantics_update_builder_migration_part4
branch
from
7165b75
to
26c74be
Compare
|
@chunhtai Any ideas why Google Testing fails? |
bartekpacia
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/139942, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bartekpacia
force-pushed
the
chore/semantics_update_builder_migration_part4
branch
from
462f98c
to
92104e9
Compare
bartekpacia
added
the
autosubmit
bartekpacia
deleted the
chore/semantics_update_builder_migration_part4
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 16, 2023
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 16, 2023
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 17, 2023
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 17, 2023
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 18, 2023
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 18, 2023
flutter/flutter@2407f69...cdc83e5 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309) 2023-12-18 raphire08@users.noreply.github.com refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555) 2023-12-18 andrewrkolos@gmail.com Restore and fix flavors_test_macos (flutter/flutter#139841) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308) 2023-12-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291) 2023-12-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277) 2023-12-16 leroux_bruno@yahoo.fr Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274) 2023-12-16 barpac02@gmail.com Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262) 2023-12-16 xilaizhang@google.com [github actions] minor PR to test latest github actions (flutter/flutter#140252) 2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255) 2023-12-15 polinach@google.com Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240) 2023-12-15 42216813+eliasyishak@users.noreply.github.com Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236) 2023-12-15 polinach@google.com Reorganize dependencies on leak_tracker. (flutter/flutter#140233) 2023-12-15 chris@bracken.jp [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228) 2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Dec 18, 2023
) This PR completest the migration by removing `SemanticsUpdateBuilderNew` from the engine. This is mainly targeted at flutter/flutter#17988 Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` #47961 part 2: [flutter] use `SemanticsUpdateBuilderNew` flutter/flutter#138331 part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` #48882 part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again flutter/flutter#139942 **part 5: [engine] remove `SemanticsBuilderNew`** <-- we are here
Michal-MK
pushed a commit
to Michal-MK/flutter
that referenced
this pull request
Jan 8, 2024
…y `SemanticsUpdateBuilderNew` (flutter#139942) This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now. This is mainly targeted at flutter#17988 Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` flutter/engine#47961 part 2: [flutter] use `SemanticsUpdateBuilderNew` flutter#138331 part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` flutter/engine#48882 **part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here part 5: [engine] remove `SemanticsBuilderNew`
Markzipan
pushed a commit
to Markzipan/flutter
that referenced
this pull request
Jan 9, 2024
…y `SemanticsUpdateBuilderNew` (flutter#139942) This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now. This is mainly targeted at flutter#17988 Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` flutter/engine#47961 part 2: [flutter] use `SemanticsUpdateBuilderNew` flutter#138331 part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` flutter/engine#48882 **part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here part 5: [engine] remove `SemanticsBuilderNew`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
…o temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all usages of the temporary
SemanticsUpdateBuilderNewAPI in favor ofSemanticsUpdateBuilder. These two APIs are the same as of now.This is mainly targeted at #17988
Steps:
part 1: [engine] add
SemanticsUpdateBuilderNewflutter/engine#47961part 2: [flutter] use
SemanticsUpdateBuilderNew#138331part 3: [engine] update
SemanticsUpdateBuilderto be the same asSemanticsUpdateBuilderNewflutter/engine#48882part 4: [flutter] use (now updated)
SemanticsUpdateBuilderagain <-- we are herepart 5: [engine] remove
SemanticsBuilderNewflutter/engine#49139Pre-launch Checklist
///).