-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError #140122
[flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError #140122
Conversation
This is still on my radar |
e6c96ec
to
ff0c499
Compare
7f1dba0
to
671338f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nit for future reference: The title struck me as non-sequitur to the description until I read the diff.
Title could have been something like "Add lint for X." The description would explain 1) why we want this lint and then 2) that we first need to give the custom CI analyzer code the ability to run rules against only the tool codebase, hence the big change in analyze.dart.
Good catch, updated the title. |
…int Future.catchError (flutter/flutter#140122)
flutter/flutter@471a828...7c89ec8 2024-03-08 kustermann@google.com Remove `toString()` overrides in `dart:ui`/`package:flutter` in profile/release mode on wasm/vm targets (flutter/flutter#144763) 2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) (flutter/flutter#144813) 2024-03-08 65758246+Nenuphar12@users.noreply.github.com Update documentation of `AlertDialog`'s default `TextStyle` for Material 3 (flutter/flutter#144697) 2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 175069397a40 to 80cd7981043f (5 revisions) (flutter/flutter#144804) 2024-03-07 andrewrkolos@gmail.com Enable asset transformation for `flutter run -d <browser>` and `flutter test` (flutter/flutter#144734) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec4f9af3d53b to 175069397a40 (2 revisions) (flutter/flutter#144799) 2024-03-07 git@reb0.org refactor: Remove `throwOnPluginPubspecError` flag for plugin validation (flutter/flutter#144214) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 305333c50191 to ec4f9af3d53b (1 revision) (flutter/flutter#144797) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2863530ce39 to 305333c50191 (1 revision) (flutter/flutter#144793) 2024-03-07 faisal.hiyaz@gmail.com Fixed -> DropdownMenu throws exception when it is in any scrollable l� (flutter/flutter#140566) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e8ccaa3842e to c2863530ce39 (2 revisions) (flutter/flutter#144792) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 12828950890a to 9e8ccaa3842e (1 revision) (flutter/flutter#144784) 2024-03-07 fluttergithubbot@gmail.com Marks Mac_x64 module_test_ios to be flaky (flutter/flutter#144681) 2024-03-07 christopherfujino@gmail.com [flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError (flutter/flutter#140122) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) (flutter/flutter#144775) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…int Future.catchError (flutter/flutter#140122)
…r#6288) flutter/flutter@471a828...7c89ec8 2024-03-08 kustermann@google.com Remove `toString()` overrides in `dart:ui`/`package:flutter` in profile/release mode on wasm/vm targets (flutter/flutter#144763) 2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) (flutter/flutter#144813) 2024-03-08 65758246+Nenuphar12@users.noreply.github.com Update documentation of `AlertDialog`'s default `TextStyle` for Material 3 (flutter/flutter#144697) 2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 175069397a40 to 80cd7981043f (5 revisions) (flutter/flutter#144804) 2024-03-07 andrewrkolos@gmail.com Enable asset transformation for `flutter run -d <browser>` and `flutter test` (flutter/flutter#144734) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec4f9af3d53b to 175069397a40 (2 revisions) (flutter/flutter#144799) 2024-03-07 git@reb0.org refactor: Remove `throwOnPluginPubspecError` flag for plugin validation (flutter/flutter#144214) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 305333c50191 to ec4f9af3d53b (1 revision) (flutter/flutter#144797) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2863530ce39 to 305333c50191 (1 revision) (flutter/flutter#144793) 2024-03-07 faisal.hiyaz@gmail.com Fixed -> DropdownMenu throws exception when it is in any scrollable lâ�¦ (flutter/flutter#140566) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e8ccaa3842e to c2863530ce39 (2 revisions) (flutter/flutter#144792) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 12828950890a to 9e8ccaa3842e (1 revision) (flutter/flutter#144784) 2024-03-07 fluttergithubbot@gmail.com Marks Mac_x64 module_test_ios to be flaky (flutter/flutter#144681) 2024-03-07 christopherfujino@gmail.com [flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError (flutter/flutter#140122) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) (flutter/flutter#144775) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ensure tool code does not use Future.catchError or Future.onError, because it is not statically safe: dart-lang/sdk#51248.
This was proposed upstream in dart-lang/linter in dart-lang/linter#4071 and dart-lang/linter#4068, but not accepted.