Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticsProperties: default identifier and tooltip to null #140283

Merged

Conversation

bartekpacia
Copy link
Member

This PR applies the suggestion made here.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Dec 17, 2023
@bartekpacia bartekpacia force-pushed the chore/semantics_debugfillproperties branch from d718cd8 to 6c549bf Compare December 17, 2023 00:43
@bartekpacia bartekpacia marked this pull request as ready for review December 17, 2023 01:23
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2023
@auto-submit auto-submit bot merged commit a438877 into flutter:master Dec 18, 2023
67 checks passed
@bartekpacia bartekpacia deleted the chore/semantics_debugfillproperties branch December 18, 2023 21:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 19, 2023
flutter/flutter@cdc83e5...0eb7881

2023-12-19 zanderso@users.noreply.github.com Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389)
2023-12-19 barpac02@gmail.com Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103)
2023-12-19 engine-flutter-autoroll@skia.org Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362)
2023-12-19 polinach@google.com Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350)
2023-12-18 barpac02@gmail.com SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283)
2023-12-18 simonfv@gmail.com Document difference between softWrap and maxLine (flutter/flutter#139363)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332)
2023-12-18 34871572+gmackall@users.noreply.github.com Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324)
2023-12-18 engine-flutter-autoroll@skia.org Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ChopinDavid pushed a commit to wwt/flutter-packages that referenced this pull request Dec 28, 2023
…r#5722)

flutter/flutter@cdc83e5...0eb7881

2023-12-19 zanderso@users.noreply.github.com Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389)
2023-12-19 barpac02@gmail.com Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103)
2023-12-19 engine-flutter-autoroll@skia.org Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362)
2023-12-19 polinach@google.com Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350)
2023-12-18 barpac02@gmail.com SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283)
2023-12-18 simonfv@gmail.com Document difference between softWrap and maxLine (flutter/flutter#139363)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332)
2023-12-18 34871572+gmackall@users.noreply.github.com Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324)
2023-12-18 engine-flutter-autoroll@skia.org Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants