New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemanticsProperties: default identifier
and tooltip
to null
#140283
Merged
auto-submit
merged 1 commit into
flutter:master
from
bartekpacia:chore/semantics_debugfillproperties
Dec 18, 2023
Merged
SemanticsProperties: default identifier
and tooltip
to null
#140283
auto-submit
merged 1 commit into
flutter:master
from
bartekpacia:chore/semantics_debugfillproperties
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
flutter/packages/flutter repository. See also f: labels.
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
labels
Dec 17, 2023
bartekpacia
force-pushed
the
chore/semantics_debugfillproperties
branch
from
December 17, 2023 00:43
d718cd8
to
6c549bf
Compare
chunhtai
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this!
bartekpacia
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Dec 18, 2023
7 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 19, 2023
flutter/flutter@cdc83e5...0eb7881 2023-12-19 zanderso@users.noreply.github.com Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389) 2023-12-19 barpac02@gmail.com Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103) 2023-12-19 engine-flutter-autoroll@skia.org Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362) 2023-12-19 polinach@google.com Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350) 2023-12-18 barpac02@gmail.com SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283) 2023-12-18 simonfv@gmail.com Document difference between softWrap and maxLine (flutter/flutter#139363) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332) 2023-12-18 34871572+gmackall@users.noreply.github.com Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324) 2023-12-18 engine-flutter-autoroll@skia.org Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ChopinDavid
pushed a commit
to wwt/flutter-packages
that referenced
this pull request
Dec 28, 2023
…r#5722) flutter/flutter@cdc83e5...0eb7881 2023-12-19 zanderso@users.noreply.github.com Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389) 2023-12-19 barpac02@gmail.com Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103) 2023-12-19 engine-flutter-autoroll@skia.org Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362) 2023-12-19 polinach@google.com Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247) 2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350) 2023-12-18 barpac02@gmail.com SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283) 2023-12-18 simonfv@gmail.com Document difference between softWrap and maxLine (flutter/flutter#139363) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332) 2023-12-18 34871572+gmackall@users.noreply.github.com Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324) 2023-12-18 engine-flutter-autoroll@skia.org Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322) 2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).
victoreronmosele
pushed a commit
to victoreronmosele/flutter
that referenced
this pull request
Jan 6, 2024
…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).
Michal-MK
pushed a commit
to Michal-MK/flutter
that referenced
this pull request
Jan 8, 2024
…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).
Markzipan
pushed a commit
to Markzipan/flutter
that referenced
this pull request
Jan 9, 2024
…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the suggestion made here.
Pre-launch Checklist
///
).