Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 139196 selection OOB #140300

Merged
merged 1 commit into from Jan 3, 2024
Merged

Fix 139196 selection OOB #140300

merged 1 commit into from Jan 3, 2024

Conversation

LongCatIsLooong
Copy link
Contributor

Fixes #139196

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong
fix 139196
a990bf3 
Fixes a race when the down key is pressed at the same time as text input happens
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Dec 18, 2023
Renzo-Olivares
Renzo-Olivares approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@auto-submit auto-submit bot merged commit f3b6505 into flutter:master Jan 3, 2024
68 checks passed
@LongCatIsLooong LongCatIsLooong deleted the fix-139196 branch January 3, 2024 00:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
f3b6505f1 Fix 139196 selection OOB (flutter/flutter#140300)
383060a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
f3b6505f1 Fix 139196 selection OOB (flutter/flutter#140300)
0716fe0
@HansMuller HansMuller mentioned this pull request Jan 5, 2024
Open
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
@LongCatIsLooong @victoreronmosele
Fix 139196 selection OOB (flutter#140300)
e46a5ad 
Fixes flutter#139196
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@LongCatIsLooong @Michal-MK
Fix 139196 selection OOB (flutter#140300)
9297f68 
Fixes flutter#139196
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@LongCatIsLooong @Markzipan
Fix 139196 selection OOB (flutter#140300)
1f5f6d7 
Fixes flutter#139196
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
f3b6505f1 Fix 139196 selection OOB (flutter/flutter#140300)
8a3e47b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes when inputting letters and arrow keys at the same time in TextField
2 participants
@LongCatIsLooong @Renzo-Olivares