Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated ignores from tool #140467

Merged
merged 2 commits into from Dec 20, 2023
Merged

Remove outdated ignores from tool #140467

merged 2 commits into from Dec 20, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 20, 2023 •
edited

These were not ignoring anything (anymore).

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Dec 20, 2023
@github-actions github-actions bot removed the a: animation Animation APIs label Dec 20, 2023
@goderbauer goderbauer marked this pull request as ready for review December 20, 2023 21:20
christopherfujino
christopherfujino reviewed Dec 20, 2023
View reviewed changes
packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart
@@ -1399,9 +1399,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
Uri get uri => Uri.parse('http://localhost:8181');
}

// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sparks joy

christopherfujino
christopherfujino approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023
@auto-submit auto-submit bot merged commit 68e346e into flutter:master Dec 20, 2023
123 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2023
@engine-flutter-autoroll
68e346e41 Remove outdated ignores from tool (flutter/flutter#140467)
c2d3acc
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 21, 2023
@engine-flutter-autoroll
Roll Flutter from da0cd69659c5 to 11def8eff455 (16 revisions) (#5732)
c394168 
flutter/flutter@da0cd69...11def8e

2023-12-21 mit@google.com Update README.md (flutter/flutter#140382)
2023-12-21 flar@google.com Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502)
2023-12-21 polinach@google.com Integrate testWidgets with leak tracking. (flutter/flutter#138057)
2023-12-21 36861262+QuncCccccc@users.noreply.github.com Fix import pattern (flutter/flutter#140425)
2023-12-20 godofredoc@google.com Update job permissions (flutter/flutter#140476)
2023-12-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#140472)
2023-12-20 goderbauer@google.com Remove outdated ignores from tool (flutter/flutter#140467)
2023-12-20 goderbauer@google.com Remove outdated ignores from framework (flutter/flutter#140465)
2023-12-20 31859944+LongCatIsLooong@users.noreply.github.com Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469)
2023-12-20 reidbaker@google.com Part 1/n migration steps for kotlin migration (flutter/flutter#140452)
2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468)
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462)
2023-12-20 chris@bracken.jp Eliminate Cirrus build status badge (flutter/flutter#140461)
2023-12-20 zanderso@users.noreply.github.com Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438)
2023-12-20 engine-flutter-autoroll@skia.org Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450)
2023-12-20 leroux_bruno@yahoo.fr _TabBarViewState should not recreate page controller (flutter/flutter#135500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ChopinDavid pushed a commit to wwt/flutter-packages that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll @ChopinDavid
Roll Flutter from da0cd69659c5 to 11def8eff455 (16 revisions) (flutte…
4e8ac77 
…r#5732)

flutter/flutter@da0cd69...11def8e

2023-12-21 mit@google.com Update README.md (flutter/flutter#140382)
2023-12-21 flar@google.com Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502)
2023-12-21 polinach@google.com Integrate testWidgets with leak tracking. (flutter/flutter#138057)
2023-12-21 36861262+QuncCccccc@users.noreply.github.com Fix import pattern (flutter/flutter#140425)
2023-12-20 godofredoc@google.com Update job permissions (flutter/flutter#140476)
2023-12-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#140472)
2023-12-20 goderbauer@google.com Remove outdated ignores from tool (flutter/flutter#140467)
2023-12-20 goderbauer@google.com Remove outdated ignores from framework (flutter/flutter#140465)
2023-12-20 31859944+LongCatIsLooong@users.noreply.github.com Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469)
2023-12-20 reidbaker@google.com Part 1/n migration steps for kotlin migration (flutter/flutter#140452)
2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468)
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462)
2023-12-20 chris@bracken.jp Eliminate Cirrus build status badge (flutter/flutter#140461)
2023-12-20 zanderso@users.noreply.github.com Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438)
2023-12-20 engine-flutter-autoroll@skia.org Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450)
2023-12-20 leroux_bruno@yahoo.fr _TabBarViewState should not recreate page controller (flutter/flutter#135500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
@goderbauer @CoderDake
Remove outdated ignores from tool (flutter#140467)
8f1dd99 
These were not ignoring anything (anymore).
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
@goderbauer @victoreronmosele
Remove outdated ignores from tool (flutter#140467)
e0c8218 
These were not ignoring anything (anymore).
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@goderbauer @Michal-MK
Remove outdated ignores from tool (flutter#140467)
50d34ff 
These were not ignoring anything (anymore).
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@goderbauer @Markzipan
Remove outdated ignores from tool (flutter#140467)
a5b02af 
These were not ignoring anything (anymore).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
68e346e41 Remove outdated ignores from tool (flutter/flutter#140467)
4a1ef6d
@goderbauer goderbauer deleted the ignore-clean-flutter-test branch March 8, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goderbauer @christopherfujino