Remove hack from PageView. #141138

polina-c · 2024-01-08T21:55:56Z

The change is breaking, because now controller is nullable.

Packages to fix:

G3 http://cl/597367314
fading_edge_scrollview: Prepare for nullable PageView.controller. mponkin/fading_edge_scrollview#26

flutter-dashboard · 2024-01-08T21:56:00Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2024-01-08T22:26:02Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

This reverts commit 09da7ce.

goderbauer

fly-by comment

packages/flutter/lib/src/widgets/page_view.dart

…page-view

polina-c · 2024-01-10T20:40:32Z

examples/api/test/widgets/page_view/page_view.0_test.dart

@@ -49,7 +49,7 @@ void main() {

    // Verify that page view index is also updated with same index to page indicator.
    final PageView pageView = tester.widget<PageView>(find.byType(PageView));
-    expect(pageView.controller.page, 1);
+    expect(pageView.controller!.page, 1);


TODO: Document migration path if in general the change is ok.

It is strange google testing is not triggered.
TODO: test in Google separately.

If nothing in Google and no customer_test is failing this wouldn't need a migration.

One failure in Google: http://cl/597367314 😄

…page-view

goderbauer

LGTM

Levi-Lesches · 2024-01-11T22:19:42Z

Maybe I'm missing something here, but why use ! in the workaround? If a controller wasn't provided that would fail, and if a controller was provided, then you should use that variable instead of pageView.controller. Shouldn't the official advice be ?. instead?

polina-c · 2024-01-11T22:23:07Z

Maybe I'm missing something here, but why use ! in the workaround? If a controller wasn't provided that would fail, and if a controller was provided, then you should use that variable instead of pageView.controller. Shouldn't the official advice be ?. instead?

If you want to control the state of widget, you need to provide controller, so it is not null. And, normally, if you provide the controller, you already have it, so you do not need to get it from widget.

If you do not want to control the state of widget, you do not need to access the controller.

Does it help?

auto-submit · 2024-01-12T00:46:48Z

auto label is removed for flutter/flutter/141138, due to - The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This reverts commit 2da87e6.

Reverts #141138 Initiated by: itsjustkevin This change reverts the following previous change: Original Description: Fixes #141119 The change is breaking, because now controller is nullable. Migration path: flutter/website#10033 Packages to fix:

flutter/flutter@7dc856a...1a2c315 2024-01-14 sokolovskyi.konstantin@gmail.com BoxPainter should dispatch creation and disposal events. (flutter/flutter#141526) 2024-01-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from a0ac66ecaa2b to f20657354d8b (1 revision) (flutter/flutter#141518) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from b06478b70a2f to a0ac66ecaa2b (1 revision) (flutter/flutter#141498) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 205ed6882a8f to b06478b70a2f (3 revisions) (flutter/flutter#141496) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8e5d4776908 to 205ed6882a8f (1 revision) (flutter/flutter#141492) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 418c9e918a22 to b8e5d4776908 (7 revisions) (flutter/flutter#141489) 2024-01-12 everythingoutdated@gmail.com Added newline at end of `.gitignore` files (flutter/flutter#141270) 2024-01-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.0.0 to 4.1.0 (flutter/flutter#141480) 2024-01-12 anis.alibegic@gmail.com Fixed a lot of typos (flutter/flutter#141431) 2024-01-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove hack from PageView." (flutter/flutter#141479) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 01e353544dd7 to 418c9e918a22 (2 revisions) (flutter/flutter#141474) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ac8215c70ae to 01e353544dd7 (1 revision) (flutter/flutter#141470) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef2cf86c35a5 to 0ac8215c70ae (2 revisions) (flutter/flutter#141464) 2024-01-12 christopherfujino@gmail.com unpin web_socket_channel and roll pub packages (flutter/flutter#141424) 2024-01-12 barpac02@gmail.com FlutterExtension: make fields non-static (flutter/flutter#141463) 2024-01-12 jhy03261997@gmail.com [deep link] Update a gradle task to add flag check and intent filter check to the AppLinkSettings (flutter/flutter#141231) 2024-01-12 barpac02@gmail.com Expose versionCode and versionName from local.properties in FlutterExtension (flutter/flutter#141417) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from a56f346dbbf9 to ef2cf86c35a5 (1 revision) (flutter/flutter#141456) 2024-01-12 jonahwilliams@google.com When Impeller is enabled for flutter tester choose correct shader target. (flutter/flutter#141391) 2024-01-12 polinach@google.com Remove hack from PageView. (flutter/flutter#141138) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d0f9329c5ce4 to a56f346dbbf9 (6 revisions) (flutter/flutter#141451) 2024-01-12 50643541+Mairramer@users.noreply.github.com Adds support for StepStyle visual property bundle to the Step widget (flutter/flutter#140825) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44a0a6ee4d39 to d0f9329c5ce4 (1 revision) (flutter/flutter#141435) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes #141119 Original PR: #141138 Revert: #141479 Reason for revert: https://fusion2.corp.google.com/presubmit/597877179/OCL:597877179:BASE:597883748:1705084754455:88d992fc/targets Fix: cl/599347719

…r#5895) flutter/flutter@7dc856a...1a2c315 2024-01-14 sokolovskyi.konstantin@gmail.com BoxPainter should dispatch creation and disposal events. (flutter/flutter#141526) 2024-01-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from a0ac66ecaa2b to f20657354d8b (1 revision) (flutter/flutter#141518) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from b06478b70a2f to a0ac66ecaa2b (1 revision) (flutter/flutter#141498) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 205ed6882a8f to b06478b70a2f (3 revisions) (flutter/flutter#141496) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8e5d4776908 to 205ed6882a8f (1 revision) (flutter/flutter#141492) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 418c9e918a22 to b8e5d4776908 (7 revisions) (flutter/flutter#141489) 2024-01-12 everythingoutdated@gmail.com Added newline at end of `.gitignore` files (flutter/flutter#141270) 2024-01-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.0.0 to 4.1.0 (flutter/flutter#141480) 2024-01-12 anis.alibegic@gmail.com Fixed a lot of typos (flutter/flutter#141431) 2024-01-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove hack from PageView." (flutter/flutter#141479) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 01e353544dd7 to 418c9e918a22 (2 revisions) (flutter/flutter#141474) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ac8215c70ae to 01e353544dd7 (1 revision) (flutter/flutter#141470) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef2cf86c35a5 to 0ac8215c70ae (2 revisions) (flutter/flutter#141464) 2024-01-12 christopherfujino@gmail.com unpin web_socket_channel and roll pub packages (flutter/flutter#141424) 2024-01-12 barpac02@gmail.com FlutterExtension: make fields non-static (flutter/flutter#141463) 2024-01-12 jhy03261997@gmail.com [deep link] Update a gradle task to add flag check and intent filter check to the AppLinkSettings (flutter/flutter#141231) 2024-01-12 barpac02@gmail.com Expose versionCode and versionName from local.properties in FlutterExtension (flutter/flutter#141417) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from a56f346dbbf9 to ef2cf86c35a5 (1 revision) (flutter/flutter#141456) 2024-01-12 jonahwilliams@google.com When Impeller is enabled for flutter tester choose correct shader target. (flutter/flutter#141391) 2024-01-12 polinach@google.com Remove hack from PageView. (flutter/flutter#141138) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d0f9329c5ce4 to a56f346dbbf9 (6 revisions) (flutter/flutter#141451) 2024-01-12 50643541+Mairramer@users.noreply.github.com Adds support for StepStyle visual property bundle to the Step widget (flutter/flutter#140825) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44a0a6ee4d39 to d0f9329c5ce4 (1 revision) (flutter/flutter#141435) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update page_view.dart

1873b5b

polina-c requested a review from HansMuller January 8, 2024 21:56

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 8, 2024

polina-c added a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker and removed framework flutter/packages/flutter repository. See also f: labels. labels Jan 8, 2024

Update page_view.dart

09da7ce

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 8, 2024

polina-c marked this pull request as draft January 8, 2024 22:24

polina-c added 2 commits January 8, 2024 14:46

Revert "Update page_view.dart"

cd68992

This reverts commit 09da7ce.

Update page_view.dart

dd40347

goderbauer reviewed Jan 8, 2024

View reviewed changes

packages/flutter/lib/src/widgets/page_view.dart Show resolved Hide resolved

packages/flutter/lib/src/widgets/page_view.dart Outdated Show resolved Hide resolved

polina-c added 2 commits January 9, 2024 18:31

Update page_view.dart

6725d30

Update tabs_test.dart

2d733a6

github-actions bot added the f: material design flutter/packages/flutter/material repository. label Jan 10, 2024

polina-c added 5 commits January 9, 2024 19:00

Update page_view.dart

dc2338f

Update page_view_test.dart

85a47bf

Merge branch 'master' of https://github.com/flutter/flutter into fix-…

ac70389

…page-view

Merge branch 'master' of https://github.com/flutter/flutter into fix-…

1748c59

…page-view

Update page_view.0_test.dart

a010e6a

github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jan 10, 2024

polina-c commented Jan 10, 2024

View reviewed changes

polina-c and others added 6 commits January 10, 2024 13:11

Update page_view_test.dart

f0d09ad

Update page_view_test.dart

bf97fa9

Merge branch 'master' into fix-page-view

a1f622b

Merge branch 'master' of https://github.com/flutter/flutter into fix-…

d7cdb33

…page-view

Update page_view_test.dart

6853aa9

Merge branch 'fix-page-view' of github.com:polina-c/flutter into fix-…

583ee91

…page-view

goderbauer approved these changes Jan 11, 2024

View reviewed changes

Merge branch 'master' into fix-page-view

85693d6

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024

Merge branch 'master' into fix-page-view

087765e

polina-c merged commit 2da87e6 into flutter:master Jan 12, 2024
66 checks passed

polina-c deleted the fix-page-view branch January 12, 2024 17:47

itsjustkevin added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 12, 2024

auto-submit bot pushed a commit that referenced this pull request Jan 12, 2024

Revert "Remove hack from PageView. (#141138)"

af57ca7

This reverts commit 2da87e6.

auto-submit bot mentioned this pull request Jan 12, 2024

Reverts "Remove hack from PageView." #141479

Merged

2 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 12, 2024

engine-flutter-autoroll mentioned this pull request Jan 13, 2024

Roll Flutter from 7dc856ab8423 to 0d7758e4b5ef (21 revisions) flutter/packages#5888

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 13, 2024

2da87e610 Remove hack from PageView. (flutter/flutter#141138)

6c28113

engine-flutter-autoroll mentioned this pull request Jan 13, 2024

Roll Flutter from 7dc856ab8423 to 0d7758e4b5ef (21 revisions) flutter/packages#5889

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 13, 2024

2da87e610 Remove hack from PageView. (flutter/flutter#141138)

9e721af

engine-flutter-autoroll mentioned this pull request Jan 14, 2024

Roll Flutter from 7dc856ab8423 to 947d7cad8d1d (22 revisions) flutter/packages#5893

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2024

2da87e610 Remove hack from PageView. (flutter/flutter#141138)

198e82e

engine-flutter-autoroll mentioned this pull request Jan 14, 2024

Roll Flutter from 7dc856ab8423 to 947d7cad8d1d (22 revisions) flutter/packages#5894

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2024

2da87e610 Remove hack from PageView. (flutter/flutter#141138)

e8099e2

engine-flutter-autoroll mentioned this pull request Jan 14, 2024

Roll Flutter from 7dc856ab8423 to 1a2c3151fef2 (23 revisions) flutter/packages#5895

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2024

2da87e610 Remove hack from PageView. (flutter/flutter#141138)

6d83e49

polina-c restored the fix-page-view branch January 14, 2024 18:52

polina-c mentioned this pull request Jan 14, 2024

Reland "Remove hack from PageView." #141533

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove hack from PageView. #141138

Remove hack from PageView. #141138

polina-c commented Jan 8, 2024 •

edited

Loading

flutter-dashboard bot commented Jan 8, 2024

flutter-dashboard bot commented Jan 8, 2024

goderbauer left a comment

polina-c Jan 10, 2024

polina-c Jan 10, 2024 •

edited

Loading

goderbauer Jan 10, 2024

polina-c Jan 10, 2024 •

edited

Loading

goderbauer left a comment

Levi-Lesches commented Jan 11, 2024

polina-c commented Jan 11, 2024 •

edited

Loading

auto-submit bot commented Jan 12, 2024

Remove hack from PageView. #141138

Remove hack from PageView. #141138

Conversation

polina-c commented Jan 8, 2024 • edited Loading

flutter-dashboard bot commented Jan 8, 2024

flutter-dashboard bot commented Jan 8, 2024

goderbauer left a comment

Choose a reason for hiding this comment

polina-c Jan 10, 2024

Choose a reason for hiding this comment

polina-c Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

goderbauer Jan 10, 2024

Choose a reason for hiding this comment

polina-c Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

Levi-Lesches commented Jan 11, 2024

polina-c commented Jan 11, 2024 • edited Loading

auto-submit bot commented Jan 12, 2024

polina-c commented Jan 8, 2024 •

edited

Loading

polina-c Jan 10, 2024 •

edited

Loading

polina-c Jan 10, 2024 •

edited

Loading

polina-c commented Jan 11, 2024 •

edited

Loading