Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual compile reland #143262

Merged
merged 8 commits into from
Feb 13, 2024
Merged

Conversation

eyebrowsoffire
Copy link
Contributor

This is an attempt at a reland of #141396

The main changes here that are different than the original PR is fixes to wire up the flutter test command properly with the web renderer.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 10, 2024
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the 2 commits on top of the previously reverted PR. They look good to me!

@eyebrowsoffire eyebrowsoffire marked this pull request as ready for review February 13, 2024 01:42
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot merged commit 5a9fa1e into flutter:master Feb 13, 2024
133 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@camsim99
Copy link
Contributor

@eyebrowsoffire I suspect that this PR may be blocking the Flutter --> packages roller based on @gspencergoog's findings (see discussion on Discord) on the web test failures in palette_generator (here's an example of a bad build: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_web%20web_dart_unit_test_shard_2%20master/5866/overview).

I think we should revert this PR, but let me know if you think this is a misfire.

@eyebrowsoffire
Copy link
Contributor Author

@camsim99 Thanks for flagging this. I took a look at the issue, and it appears that those failing tests in the flutter/packages seem to be depending on an actual bug in our code. Not specifying a web renderer in flutter test --platform=chrome should default to the auto selector, but in reality the flutter web platform was previously erroneously serving the files for the html renderer if nothing was specified. I think maybe the best thing here would be to forward fix the packages repo to explicitly specify the web renderer when running flutter test. I will put together a forward fix for that.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants