Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing switch expressions in widgets/ #143293

Merged
merged 7 commits into from Feb 13, 2024
Merged

Implementing switch expressions in widgets/ #143293

merged 7 commits into from Feb 13, 2024

Conversation

nate-thegrate
Copy link
Member

This PR is the 7ᵗʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793)

This pull request covers everything in packages/flutter/lib/src/widgets/. Most of it should be really straightforward, but there was some refactoring in the getOffsetToReveal() function in two_dimensional_viewport.dart. I'll add some comments to describe those changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Feb 12, 2024
goderbauer
goderbauer reviewed Feb 12, 2024
View reviewed changes
packages/flutter/lib/src/widgets/banner.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/banner.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/banner.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/two_dimensional_viewport.dart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piinks Can you take a look at the changes to this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here LGTM! Thank you for your continued contributions!

nate-thegrate and others added 2 commits February 12, 2024 17:36
@nate-thegrate @goderbauer
sort by BannerLocation value
a61fe19 
based on review from @goderbauer

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
@nate-thegrate
a much better order for _translationX()
891ede5
goderbauer
goderbauer approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot merged commit 8eea4f1 into flutter:master Feb 13, 2024
66 checks passed
@nate-thegrate nate-thegrate deleted the switch-expressions-7 branch February 13, 2024 22:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
a11f66d 
…utter#143293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
5c72666 
…utter#143293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
b72367a 
…utter#143293)
@nate-thegrate nate-thegrate mentioned this pull request Feb 14, 2024
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
cfeb19d 
…utter#143293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
fd3c685 
…utter#143293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
33dd37b 
…utter#143293)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
d3e327b 
…utter#143293)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
8eea4f175 Implementing switch expressions in widgets/ (flutter/fl…
28afeef 
…utter#143293)
@HansMuller HansMuller mentioned this pull request Feb 16, 2024
Open
auto-submit bot pushed a commit that referenced this pull request Feb 16, 2024
@nate-thegrate
Implementing switch expressions [refactoring flutter/lib/src/] (#…
944cd11 
…143496)

This PR is the 8�ʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293)

I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring.

This pull request is just the complicated stuff. � I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
@nate-thegrate nate-thegrate mentioned this pull request Feb 17, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Feb 20, 2024
@nate-thegrate
Implementing switch expressions: everything in flutter/lib/src/ (#…
7a4c246 
…143634)

This PR is the 9�ʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496)

I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)
@nate-thegrate nate-thegrate mentioned this pull request Mar 23, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Mar 29, 2024
@nate-thegrate
Implementing switch expressions in flutter_tools/ (#145632)
a17d4b3 
This pull request is step 12 in the journey to make this entire repository more readable.

(previous PRs: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496, #143634, #143812, #144580)

We're getting close to the end! �
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nate-thegrate @goderbauer @Piinks