Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement _suspendedNode fix #143556

Merged
merged 1 commit into from Feb 20, 2024
Merged

Implement _suspendedNode fix #143556

merged 1 commit into from Feb 20, 2024

Conversation

nate-thegrate
Copy link
Member

Previously we merged #142930, to solve issue #87061.

Since then, I discovered that the keyboard input wasn't being captured after the app had been paused and resumed. After some digging, I realized that the problem was due to a line in editable_text.dart that called the focusNode.consumeKeyboardToken() method.

Luckily, it's a very easy fix: we just use requestFocus() instead of applyFocusChangesIfNeeded(). @gspencergoog could you take a look when you have a chance?

@nate-thegrate nate-thegrate marked this pull request as ready for review February 16, 2024 00:54
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Feb 16, 2024
gspencergoog
gspencergoog approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2024
@auto-submit auto-submit bot merged commit fc07b24 into flutter:master Feb 20, 2024
66 checks passed
@nate-thegrate nate-thegrate deleted the focusmanager-fix branch February 20, 2024 22:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2024
@engine-flutter-autoroll
fc07b241a Implement _suspendedNode fix (flutter/flutter#143556)
3566220
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2024
@engine-flutter-autoroll
fc07b241a Implement _suspendedNode fix (flutter/flutter#143556)
b2273d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2024
@engine-flutter-autoroll
fc07b241a Implement _suspendedNode fix (flutter/flutter#143556)
c5f22d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2024
@engine-flutter-autoroll
fc07b241a Implement _suspendedNode fix (flutter/flutter#143556)
0aa268c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2024
@engine-flutter-autoroll
fc07b241a Implement _suspendedNode fix (flutter/flutter#143556)
95fce6b
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 22, 2024
@engine-flutter-autoroll
Manual roll Flutter from 5129806e6c63 to efee280cfa93 (47 revisions) (#…
078c2a3 
…6180)

Manual roll Flutter from 5129806e6c63 to efee280cfa93 (47 revisions)

Manual roll requested by dit@google.com

flutter/flutter@5129806...efee280

2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf5c003085fd to 7eeb697687d5 (16 revisions) (flutter/flutter#143911)
2024-02-22 katelovett@google.com Update PR template for dart fix (flutter/flutter#143879)
2024-02-22 katelovett@google.com Re-use methods to calculate leading and trailing garbage in RenderSliverMultiBoxAdaptor (flutter/flutter#143884)
2024-02-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (flutter/flutter#143896)
2024-02-21 jonahwilliams@google.com [Impeller] Make impeller goldens test blocking. (flutter/flutter#143864)
2024-02-21 jonahwilliams@google.com Disable color filter sepia test for Impeller. (flutter/flutter#143861)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52ffcaadea41 to bf5c003085fd (12 revisions) (flutter/flutter#143875)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4128895d79a1 to 52ffcaadea41 (1 revision) (flutter/flutter#143862)
2024-02-21 katelovett@google.com Deprecate redundant itemExtent in RenderSliverFixedExtentBoxAdaptor methods (flutter/flutter#143412)
2024-02-21 reidbaker@google.com Add aab as alias for appbundle (flutter/flutter#143855)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e16f43eeaaa4 to 4128895d79a1 (1 revision) (flutter/flutter#143856)
2024-02-21 engine-flutter-autoroll@skia.org Roll Packages from 8bba41b to 48048f6 (2 revisions) (flutter/flutter#143853)
2024-02-21 tessertaha@gmail.com Update `hourMinuteTextStyle` defaults for Material 3 Time Picker (flutter/flutter#143749)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93063f61943a to e16f43eeaaa4 (2 revisions) (flutter/flutter#143827)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from ed49634486e9 to 93063f61943a (1 revision) (flutter/flutter#143826)
2024-02-21 tessertaha@gmail.com `CalendarDatePicker` doesn't announce selected date on desktop (flutter/flutter#143583)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9100d326475a to ed49634486e9 (2 revisions) (flutter/flutter#143824)
2024-02-21 tessertaha@gmail.com Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle`  for Material 3 Time Picker (flutter/flutter#143739)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from efc69946cb1e to 9100d326475a (2 revisions) (flutter/flutter#143820)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 700250436e3f to efc69946cb1e (2 revisions) (flutter/flutter#143816)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3557277c575c to 700250436e3f (1 revision) (flutter/flutter#143814)
2024-02-21 jonahwilliams@google.com more fixes to unstable impeller goldens. (flutter/flutter#143811)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb12a8cc97a1 to 3557277c575c (2 revisions) (flutter/flutter#143807)
2024-02-21 kevmoo@users.noreply.github.com [flutter_tools] enable wasm compile on beta channel (flutter/flutter#143779)
2024-02-21 simonfv@gmail.com Fix initialization of time in repeat on AnimationController (flutter/flutter#142887)
2024-02-21 jonahwilliams@google.com Disable debug banner to stabilize impeller goldens. (flutter/flutter#143794)
2024-02-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (flutter/flutter#143801)
2024-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add UI Benchmarks (#143542)" (flutter/flutter#143798)
2024-02-20 31859944+LongCatIsLooong@users.noreply.github.com Avoid applying partial dartfixes on CI (flutter/flutter#143551)
2024-02-20 bernaferrari2@gmail.com Add UI Benchmarks (flutter/flutter#143542)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ae2c10e8071 to cb12a8cc97a1 (1 revision) (flutter/flutter#143791)
2024-02-20 nate.w5687@gmail.com Implement `_suspendedNode` fix (flutter/flutter#143556)
2024-02-20 xubaolin@oppo.com Change `ItemExtentBuilder`'s return value nullable (flutter/flutter#142428)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27828054f07a to 1ae2c10e8071 (6 revisions) (flutter/flutter#143783)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e16a260265ad to 27828054f07a (1 revision) (flutter/flutter#143769)
2024-02-20 jonahwilliams@google.com [gold] Always provide host ABI to gold config (flutter/flutter#143621)
2024-02-20 andrewrkolos@gmail.com instead of exiting the tool, print a warning when using --flavor with an incompatible device (flutter/flutter#143735)
2024-02-20 nate.w5687@gmail.com Implementing `switch` expressions: everything in `flutter/lib/src/` (flutter/flutter#143634)
2024-02-20 31859944+LongCatIsLooong@users.noreply.github.com Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (flutter/flutter#143281)
2024-02-20 34871572+gmackall@users.noreply.github.com Delete local.properties that shouldn't have been pushed (flutter/flutter#143774)
2024-02-20 polinach@google.com Clean leaks. (flutter/flutter#142818)
2024-02-20 36861262+QuncCccccc@users.noreply.github.com Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#138521)
2024-02-20 greg@zulip.com Explain when and why to use CrossAxisAlignment.baseline (flutter/flutter#143632)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a41da3701923 to e16a260265ad (2 revisions) (flutter/flutter#143763)
...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Manual roll Flutter from 5129806e6c63 to efee280cfa93 (47 revisions) (f…
2e81f1d 
…lutter#6180)

Manual roll Flutter from 5129806e6c63 to efee280cfa93 (47 revisions)

Manual roll requested by dit@google.com

flutter/flutter@5129806...efee280

2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf5c003085fd to 7eeb697687d5 (16 revisions) (flutter/flutter#143911)
2024-02-22 katelovett@google.com Update PR template for dart fix (flutter/flutter#143879)
2024-02-22 katelovett@google.com Re-use methods to calculate leading and trailing garbage in RenderSliverMultiBoxAdaptor (flutter/flutter#143884)
2024-02-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (flutter/flutter#143896)
2024-02-21 jonahwilliams@google.com [Impeller] Make impeller goldens test blocking. (flutter/flutter#143864)
2024-02-21 jonahwilliams@google.com Disable color filter sepia test for Impeller. (flutter/flutter#143861)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52ffcaadea41 to bf5c003085fd (12 revisions) (flutter/flutter#143875)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4128895d79a1 to 52ffcaadea41 (1 revision) (flutter/flutter#143862)
2024-02-21 katelovett@google.com Deprecate redundant itemExtent in RenderSliverFixedExtentBoxAdaptor methods (flutter/flutter#143412)
2024-02-21 reidbaker@google.com Add aab as alias for appbundle (flutter/flutter#143855)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e16f43eeaaa4 to 4128895d79a1 (1 revision) (flutter/flutter#143856)
2024-02-21 engine-flutter-autoroll@skia.org Roll Packages from 8bba41b to 48048f6 (2 revisions) (flutter/flutter#143853)
2024-02-21 tessertaha@gmail.com Update `hourMinuteTextStyle` defaults for Material 3 Time Picker (flutter/flutter#143749)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93063f61943a to e16f43eeaaa4 (2 revisions) (flutter/flutter#143827)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from ed49634486e9 to 93063f61943a (1 revision) (flutter/flutter#143826)
2024-02-21 tessertaha@gmail.com `CalendarDatePicker` doesn't announce selected date on desktop (flutter/flutter#143583)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9100d326475a to ed49634486e9 (2 revisions) (flutter/flutter#143824)
2024-02-21 tessertaha@gmail.com Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle`  for Material 3 Time Picker (flutter/flutter#143739)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from efc69946cb1e to 9100d326475a (2 revisions) (flutter/flutter#143820)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 700250436e3f to efc69946cb1e (2 revisions) (flutter/flutter#143816)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3557277c575c to 700250436e3f (1 revision) (flutter/flutter#143814)
2024-02-21 jonahwilliams@google.com more fixes to unstable impeller goldens. (flutter/flutter#143811)
2024-02-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb12a8cc97a1 to 3557277c575c (2 revisions) (flutter/flutter#143807)
2024-02-21 kevmoo@users.noreply.github.com [flutter_tools] enable wasm compile on beta channel (flutter/flutter#143779)
2024-02-21 simonfv@gmail.com Fix initialization of time in repeat on AnimationController (flutter/flutter#142887)
2024-02-21 jonahwilliams@google.com Disable debug banner to stabilize impeller goldens. (flutter/flutter#143794)
2024-02-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (flutter/flutter#143801)
2024-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add UI Benchmarks (#143542)" (flutter/flutter#143798)
2024-02-20 31859944+LongCatIsLooong@users.noreply.github.com Avoid applying partial dartfixes on CI (flutter/flutter#143551)
2024-02-20 bernaferrari2@gmail.com Add UI Benchmarks (flutter/flutter#143542)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ae2c10e8071 to cb12a8cc97a1 (1 revision) (flutter/flutter#143791)
2024-02-20 nate.w5687@gmail.com Implement `_suspendedNode` fix (flutter/flutter#143556)
2024-02-20 xubaolin@oppo.com Change `ItemExtentBuilder`'s return value nullable (flutter/flutter#142428)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27828054f07a to 1ae2c10e8071 (6 revisions) (flutter/flutter#143783)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e16a260265ad to 27828054f07a (1 revision) (flutter/flutter#143769)
2024-02-20 jonahwilliams@google.com [gold] Always provide host ABI to gold config (flutter/flutter#143621)
2024-02-20 andrewrkolos@gmail.com instead of exiting the tool, print a warning when using --flavor with an incompatible device (flutter/flutter#143735)
2024-02-20 nate.w5687@gmail.com Implementing `switch` expressions: everything in `flutter/lib/src/` (flutter/flutter#143634)
2024-02-20 31859944+LongCatIsLooong@users.noreply.github.com Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (flutter/flutter#143281)
2024-02-20 34871572+gmackall@users.noreply.github.com Delete local.properties that shouldn't have been pushed (flutter/flutter#143774)
2024-02-20 polinach@google.com Clean leaks. (flutter/flutter#142818)
2024-02-20 36861262+QuncCccccc@users.noreply.github.com Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#138521)
2024-02-20 greg@zulip.com Explain when and why to use CrossAxisAlignment.baseline (flutter/flutter#143632)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a41da3701923 to e16a260265ad (2 revisions) (flutter/flutter#143763)
...
@HansMuller HansMuller mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nate-thegrate @cbracken @loic-sharma @gspencergoog