Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in TextEditingController docs #143717

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Feb 19, 2024

This follows up on #143452, to slightly further address #95978.

The double- rather than triple-slash on the blank line caused it to be ignored by dartdoc, so that the two paragraphs it's intended to separate were getting joined as one paragraph instead.

Also expand this constructor's summary line slightly to mention its distinctive feature compared with the other constructor, and make other small fixes that I noticed in other docs on this class.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This follows up on flutter#143452, to slightly further address flutter#95978.

The double- rather than triple-slash on the blank line caused it
to be ignored by dartdoc, so that the two paragraphs it's intended
to separate were getting joined as one paragraph instead.

Also expand this constructor's summary line slightly to mention its
distinctive feature compared with the other constructor, and make
other small fixes that I noticed in other docs on this class.
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 19, 2024
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙏

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2024
@auto-submit auto-submit bot merged commit 2d422a3 into flutter:master Feb 20, 2024
65 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 20, 2024
flutter/flutter@064c340...5129806

2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0abe2b9d6c7c to 781f308c6555 (1 revision) (flutter/flutter#143750)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92aad0d0fcee to 0abe2b9d6c7c (1 revision) (flutter/flutter#143745)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2335115f08d3 to 92aad0d0fcee (2 revisions) (flutter/flutter#143736)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e96c18b6c5ee to 2335115f08d3 (1 revision) (flutter/flutter#143731)
2024-02-20 greg@zulip.com Small fixes in TextEditingController docs (flutter/flutter#143717)
2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b41494f009f4 to e96c18b6c5ee (1 revision) (flutter/flutter#143722)
2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 714215d42e57 to b41494f009f4 (1 revision) (flutter/flutter#143713)
2024-02-19 git@reb0.org Reland (2): "Fix how Gradle resolves Android plugin" (flutter/flutter#142498)
2024-02-19 engine-flutter-autoroll@skia.org Roll Packages from 0af905d to 84ff11d (1 revision) (flutter/flutter#143710)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gnprice gnprice deleted the pr-texteditingcontroller-doc branch February 20, 2024 17:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…#6164)

flutter/flutter@064c340...5129806

2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0abe2b9d6c7c to 781f308c6555 (1 revision) (flutter/flutter#143750)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92aad0d0fcee to 0abe2b9d6c7c (1 revision) (flutter/flutter#143745)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2335115f08d3 to 92aad0d0fcee (2 revisions) (flutter/flutter#143736)
2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e96c18b6c5ee to 2335115f08d3 (1 revision) (flutter/flutter#143731)
2024-02-20 greg@zulip.com Small fixes in TextEditingController docs (flutter/flutter#143717)
2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b41494f009f4 to e96c18b6c5ee (1 revision) (flutter/flutter#143722)
2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 714215d42e57 to b41494f009f4 (1 revision) (flutter/flutter#143713)
2024-02-19 git@reb0.org Reland (2): "Fix how Gradle resolves Android plugin" (flutter/flutter#142498)
2024-02-19 engine-flutter-autoroll@skia.org Roll Packages from 0af905d to 84ff11d (1 revision) (flutter/flutter#143710)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants