Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not intended to land] Dummy benchmark for platform view scroll and ads banner #143805

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Feb 21, 2024

Not intended to land. Just a dummy benchmark while working on platform view performance issues.

Based on https://github.com/lucalooz/flutter_ads_list_perf from #129632, except that I don't use real AdMob (since it's a non-flutter-org repo).

Also I used 320x50 standard banner size, so I can fit 7-8 banners on screen, which should be enough (i guess?).

Feel free to use it when working on platform view performance.
Under devicelab, run

../../bin/dart bin/run.dart --local-engine=ios_profile_unopt --local-engine-host host_profile_unopt -t platform_views_scroll_perf_ios_ad_banners__timeline_summary

@github-actions github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Feb 21, 2024
@hellohuanlin hellohuanlin changed the title dummy benchmark for ad banner scroll [Not intend to land]Just a dummy benchmark while working on platform view perf issues Feb 21, 2024
@hellohuanlin hellohuanlin changed the title [Not intend to land]Just a dummy benchmark while working on platform view perf issues [Not intend to land] Dummy benchmark for platform view scroll and ads banner Feb 21, 2024
@hellohuanlin hellohuanlin changed the title [Not intend to land] Dummy benchmark for platform view scroll and ads banner [Not intended to land] Dummy benchmark for platform view scroll and ads banner Feb 21, 2024
@hellohuanlin
Copy link
Contributor Author

Closing in favor of #145224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: scrolling Viewports, list views, slivers, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant