Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] Fix missing stack trace from daemon #144113

Merged
merged 1 commit into from Feb 27, 2024

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented Feb 26, 2024

When the daemon throws an exception, the receiving client is unable to surface stack traces from the daemon.

This is because it is sent with the trace key here:

But the client tries to read it with the stackTrace key here:

final String stackTrace = data['stackTrace'] as String? ?? '';

Thanks to @mraleph for spotting this!

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

b/326825892

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 26, 2024
@jiahaog
Copy link
Member Author

jiahaog commented Feb 26, 2024

Overwrote the Google Testing status because the failing test was already failing and unrelated to this PR.

Copy link
Contributor

@chingjun chingjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@jiahaog jiahaog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024
@auto-submit auto-submit bot merged commit c30f998 into flutter:master Feb 27, 2024
121 checks passed
@jiahaog jiahaog deleted the daemon-st branch February 27, 2024 14:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 27, 2024
flutter/flutter@b77560e...c30f998

2024-02-27 jiahaog@users.noreply.github.com [flutter_tools] Fix missing stack trace from daemon (flutter/flutter#144113)
2024-02-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (flutter/flutter#144208)
2024-02-26 polinach@google.com Move debugShowWidgetInspectorOverride (flutter/flutter#144029)
2024-02-26 nate.w5687@gmail.com Allow `Listenable.merge()` to use any iterable (flutter/flutter#143675)
2024-02-26 54558023+keyonghan@users.noreply.github.com Mark firebase_release_smoke_test as `bringup: true` (flutter/flutter#144186)
2024-02-26 git@reb0.org refactor: Differentiate pubspec and resolution errors for plugins (flutter/flutter#142035)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (flutter/flutter#144159)
2024-02-26 nate.w5687@gmail.com Implementing `switch` expressions in `rendering/` (flutter/flutter#143812)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (flutter/flutter#144147)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (flutter/flutter#144145)
2024-02-26 15619084+vashworth@users.noreply.github.com Update copyDirectory to allow links to not be followed (flutter/flutter#144040)
2024-02-26 engine-flutter-autoroll@skia.org Roll Packages from 7df2085 to 353086c (7 revisions) (flutter/flutter#144144)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
…r#6211)

flutter/flutter@b77560e...c30f998

2024-02-27 jiahaog@users.noreply.github.com [flutter_tools] Fix missing stack trace from daemon (flutter/flutter#144113)
2024-02-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (flutter/flutter#144208)
2024-02-26 polinach@google.com Move debugShowWidgetInspectorOverride (flutter/flutter#144029)
2024-02-26 nate.w5687@gmail.com Allow `Listenable.merge()` to use any iterable (flutter/flutter#143675)
2024-02-26 54558023+keyonghan@users.noreply.github.com Mark firebase_release_smoke_test as `bringup: true` (flutter/flutter#144186)
2024-02-26 git@reb0.org refactor: Differentiate pubspec and resolution errors for plugins (flutter/flutter#142035)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (flutter/flutter#144159)
2024-02-26 nate.w5687@gmail.com Implementing `switch` expressions in `rendering/` (flutter/flutter#143812)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (flutter/flutter#144147)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (flutter/flutter#144145)
2024-02-26 15619084+vashworth@users.noreply.github.com Update copyDirectory to allow links to not be followed (flutter/flutter#144040)
2024-02-26 engine-flutter-autoroll@skia.org Roll Packages from 7df2085 to 353086c (7 revisions) (flutter/flutter#144144)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants