Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. #144423

Merged

Conversation

eyebrowsoffire
Copy link
Contributor

We should avoid hitting gstatic in the benchmarks and just use local canvaskit/skwasm instead.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@auto-submit auto-submit bot merged commit 203ec8b into flutter:master Feb 29, 2024
132 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 1, 2024
Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions)

flutter/flutter@e92bca3...ba719bc

2024-03-01 tessertaha@gmail.com Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317)
2024-03-01 tessertaha@gmail.com Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319)
2024-03-01 leroux_bruno@yahoo.fr InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459)
2024-03-01 leroux_bruno@yahoo.fr Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448)
2024-03-01 goderbauer@google.com Remove master from API docs (flutter/flutter#144425)
2024-03-01 goderbauer@google.com Enable missing-code-block-language (flutter/flutter#144443)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436)
2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424)
2024-02-29 jhy03261997@gmail.com Reland [a11y] Fix date picker cannot focus on the edit field  (flutter/flutter#144198)
2024-02-29 goderbauer@google.com Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431)
2024-02-29 chingjun@google.com Make daemon server work on ipv6-only machines. (flutter/flutter#144359)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079)
2024-02-29 amirpanahandeh@yahoo.com Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375)
2024-02-29 jacksongardner@google.com Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419)
2024-02-29 chingjun@google.com Fix a crash in remote device daemon. (flutter/flutter#144358)
2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178)
2024-02-29 31859944+LongCatIsLooong@users.noreply.github.com Add `FocusNode.focusabilityListenable` (flutter/flutter#144280)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416)
2024-02-29 jonahwilliams@google.com [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410)
2024-02-29 goderbauer@google.com Bump dartdocs to 8.0.6 (flutter/flutter#144413)
2024-02-29 goderbauer@google.com Use dartpad's main channel for master/main docs (flutter/flutter#144329)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395)
2024-02-29 engine-flutter-autoroll@skia.org Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
…r#6235)

Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions)

flutter/flutter@e92bca3...ba719bc

2024-03-01 tessertaha@gmail.com Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317)
2024-03-01 tessertaha@gmail.com Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319)
2024-03-01 leroux_bruno@yahoo.fr InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459)
2024-03-01 leroux_bruno@yahoo.fr Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448)
2024-03-01 goderbauer@google.com Remove master from API docs (flutter/flutter#144425)
2024-03-01 goderbauer@google.com Enable missing-code-block-language (flutter/flutter#144443)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436)
2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424)
2024-02-29 jhy03261997@gmail.com Reland [a11y] Fix date picker cannot focus on the edit field  (flutter/flutter#144198)
2024-02-29 goderbauer@google.com Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431)
2024-02-29 chingjun@google.com Make daemon server work on ipv6-only machines. (flutter/flutter#144359)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079)
2024-02-29 amirpanahandeh@yahoo.com Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375)
2024-02-29 jacksongardner@google.com Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419)
2024-02-29 chingjun@google.com Fix a crash in remote device daemon. (flutter/flutter#144358)
2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178)
2024-02-29 31859944+LongCatIsLooong@users.noreply.github.com Add `FocusNode.focusabilityListenable` (flutter/flutter#144280)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416)
2024-02-29 jonahwilliams@google.com [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410)
2024-02-29 goderbauer@google.com Bump dartdocs to 8.0.6 (flutter/flutter#144413)
2024-02-29 goderbauer@google.com Use dartpad's main channel for master/main docs (flutter/flutter#144329)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395)
2024-02-29 engine-flutter-autoroll@skia.org Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6235)

Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions)

flutter/flutter@e92bca3...ba719bc

2024-03-01 tessertaha@gmail.com Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317)
2024-03-01 tessertaha@gmail.com Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319)
2024-03-01 leroux_bruno@yahoo.fr InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459)
2024-03-01 leroux_bruno@yahoo.fr Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448)
2024-03-01 goderbauer@google.com Remove master from API docs (flutter/flutter#144425)
2024-03-01 goderbauer@google.com Enable missing-code-block-language (flutter/flutter#144443)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436)
2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424)
2024-02-29 jhy03261997@gmail.com Reland [a11y] Fix date picker cannot focus on the edit field  (flutter/flutter#144198)
2024-02-29 goderbauer@google.com Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431)
2024-02-29 chingjun@google.com Make daemon server work on ipv6-only machines. (flutter/flutter#144359)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079)
2024-02-29 amirpanahandeh@yahoo.com Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375)
2024-02-29 jacksongardner@google.com Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419)
2024-02-29 chingjun@google.com Fix a crash in remote device daemon. (flutter/flutter#144358)
2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429)
2024-02-29 36861262+QuncCccccc@users.noreply.github.com Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178)
2024-02-29 31859944+LongCatIsLooong@users.noreply.github.com Add `FocusNode.focusabilityListenable` (flutter/flutter#144280)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416)
2024-02-29 jonahwilliams@google.com [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410)
2024-02-29 goderbauer@google.com Bump dartdocs to 8.0.6 (flutter/flutter#144413)
2024-02-29 goderbauer@google.com Use dartpad's main channel for master/main docs (flutter/flutter#144329)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395)
2024-02-29 engine-flutter-autoroll@skia.org Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants