Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make DevFSContent descendants immutable #144664

Merged
merged 1 commit into from
Mar 6, 2024
Merged

make DevFSContent descendants immutable #144664

merged 1 commit into from
Mar 6, 2024

Conversation

andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Mar 6, 2024 •
edited
Loading

DevFSBytesContent (and it's descendant DevFSStringContent) have setters that change the underlying content. These are unused outside of tests, so this PR removes them. Amongst other things, this could help me refactor #144660 into something that has fewer pitfalls.

This is purely a refactoring.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 6, 2024
@andrewkolos andrewkolos force-pushed the make-dev-fs-content-descdendants-immutable branch from 711569b to eca9995 Compare March 6, 2024 04:50
@andrewkolos andrewkolos marked this pull request as ready for review March 6, 2024 05:36
christopherfujino
christopherfujino reviewed Mar 6, 2024
View reviewed changes
packages/flutter_tools/lib/src/devfs.dart
_isModified = true;
_modificationTime = DateTime.now();
}

/// Return true only once so that the content is written to the device only once.
@override
bool get isModified {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a footgun, but that's unrelated to this refactor, which LGTM

christopherfujino
christopherfujino approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@auto-submit auto-submit bot merged commit cc33f44 into flutter:master Mar 6, 2024
120 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll
cc33f44e4 make DevFSContent descendants immutable (flutter/flutter#14…
4cd413b 
…4664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll
cc33f44e4 make DevFSContent descendants immutable (flutter/flutter#14…
c91e70a 
…4664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll
cc33f44e4 make DevFSContent descendants immutable (flutter/flutter#14…
6a2bb99 
…4664)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll
Roll Flutter from 8f84f3f32ddc to 471a82856d86 (27 revisions) (#6281)
903f03a 
flutter/flutter@8f84f3f...471a828

2024-03-07 leroux_bruno@yahoo.fr [flutter_test] Use defaultTargetPlatform for key events simulation (flutter/flutter#143579)
2024-03-07 engine-flutter-autoroll@skia.org Roll Packages from 9b88dbc to 6701c9e (3 revisions) (flutter/flutter#144772)
2024-03-07 matej.knopp@gmail.com Fix frameworks added to bundle multiple times instead of lipo (flutter/flutter#144688)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) (flutter/flutter#144766)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) (flutter/flutter#144765)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) (flutter/flutter#144756)
2024-03-07 leroux_bruno@yahoo.fr [flutter_test] Change KeyEventSimulator default transit mode (flutter/flutter#143847)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) (flutter/flutter#144747)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) (flutter/flutter#144746)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) (flutter/flutter#144743)
2024-03-07 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `editable_gesture_test.dart` (flutter/flutter#144691)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) (flutter/flutter#144741)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2adf7471d3d to 53ddbdfc24e5 (1 revision) (flutter/flutter#144735)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31bbe61dfa0d to b2adf7471d3d (1 revision) (flutter/flutter#144732)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5bbac1a5c576 to 31bbe61dfa0d (3 revisions) (flutter/flutter#144724)
2024-03-06 magder@google.com Run macOS test on `dev/integration_tests/ui` (flutter/flutter#142735)
2024-03-06 kustermann@google.com Use wasm-compatible conditional import in timeline.dart, avoid emitting timeline events in SchedulerBinding (flutter/flutter#144682)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44405aedba13 to 5bbac1a5c576 (2 revisions) (flutter/flutter#144714)
2024-03-06 54558023+keyonghan@users.noreply.github.com Bring back firebase tests to prod (flutter/flutter#144703)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20037e385bda to 44405aedba13 (3 revisions) (flutter/flutter#144710)
2024-03-06 goderbauer@google.com Fix code sample failing in smoke test (flutter/flutter#144709)
2024-03-06 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `errorColor` from `ThemeData` (flutter/flutter#144078)
2024-03-06 andrewrkolos@gmail.com make DevFSContent descendants immutable (flutter/flutter#144664)
2024-03-06 jonahwilliams@google.com [Impeller] measure GPU memory usage. (flutter/flutter#144575)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aad0e93899b to 20037e385bda (1 revision) (flutter/flutter#144707)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6efe0dd88fe to 9aad0e93899b (2 revisions) (flutter/flutter#144702)
2024-03-06 34871572+gmackall@users.noreply.github.com Update android templates to use target sdk 34 (flutter/flutter#144641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@andrewkolos andrewkolos deleted the make-dev-fs-content-descdendants-immutable branch April 29, 2024 18:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
cc33f44e4 make DevFSContent descendants immutable (flutter/flutter#14…
ca62a13 
…4664)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 8f84f3f32ddc to 471a82856d86 (27 revisions) (flutte…
4baee8e 
…r#6281)

flutter/flutter@8f84f3f...471a828

2024-03-07 leroux_bruno@yahoo.fr [flutter_test] Use defaultTargetPlatform for key events simulation (flutter/flutter#143579)
2024-03-07 engine-flutter-autoroll@skia.org Roll Packages from 9b88dbc to 6701c9e (3 revisions) (flutter/flutter#144772)
2024-03-07 matej.knopp@gmail.com Fix frameworks added to bundle multiple times instead of lipo (flutter/flutter#144688)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) (flutter/flutter#144766)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) (flutter/flutter#144765)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) (flutter/flutter#144756)
2024-03-07 leroux_bruno@yahoo.fr [flutter_test] Change KeyEventSimulator default transit mode (flutter/flutter#143847)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) (flutter/flutter#144747)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) (flutter/flutter#144746)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) (flutter/flutter#144743)
2024-03-07 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `editable_gesture_test.dart` (flutter/flutter#144691)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) (flutter/flutter#144741)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2adf7471d3d to 53ddbdfc24e5 (1 revision) (flutter/flutter#144735)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31bbe61dfa0d to b2adf7471d3d (1 revision) (flutter/flutter#144732)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5bbac1a5c576 to 31bbe61dfa0d (3 revisions) (flutter/flutter#144724)
2024-03-06 magder@google.com Run macOS test on `dev/integration_tests/ui` (flutter/flutter#142735)
2024-03-06 kustermann@google.com Use wasm-compatible conditional import in timeline.dart, avoid emitting timeline events in SchedulerBinding (flutter/flutter#144682)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44405aedba13 to 5bbac1a5c576 (2 revisions) (flutter/flutter#144714)
2024-03-06 54558023+keyonghan@users.noreply.github.com Bring back firebase tests to prod (flutter/flutter#144703)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20037e385bda to 44405aedba13 (3 revisions) (flutter/flutter#144710)
2024-03-06 goderbauer@google.com Fix code sample failing in smoke test (flutter/flutter#144709)
2024-03-06 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `errorColor` from `ThemeData` (flutter/flutter#144078)
2024-03-06 andrewrkolos@gmail.com make DevFSContent descendants immutable (flutter/flutter#144664)
2024-03-06 jonahwilliams@google.com [Impeller] measure GPU memory usage. (flutter/flutter#144575)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aad0e93899b to 20037e385bda (1 revision) (flutter/flutter#144707)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6efe0dd88fe to 9aad0e93899b (2 revisions) (flutter/flutter#144702)
2024-03-06 34871572+gmackall@users.noreply.github.com Update android templates to use target sdk 34 (flutter/flutter#144641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@eliasyishak eliasyishak Awaiting requested review from eliasyishak

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewkolos @christopherfujino