Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in editable_gesture_test.dart #144691

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix memory leak in editable_gesture_test.dart #144691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 12 additions & 10 deletions packages/flutter/test/rendering/editable_gesture_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,21 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';

void main() {
final TestWidgetsFlutterBinding binding = _GestureBindingSpy();

testWidgets('attach and detach correctly handle gesture',
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
(_) async {
testWidgets('attach and detach correctly handle gesture', (_) async {
expect(WidgetsBinding.instance, binding);
final TextSelectionDelegate delegate = FakeEditableTextState();
final ViewportOffset offset = ViewportOffset.zero();
addTearDown(offset.dispose);
final RenderEditable editable = RenderEditable(
backgroundCursorColor: Colors.grey,
selectionColor: Colors.black,
textDirection: TextDirection.ltr,
cursorColor: Colors.red,
offset: ViewportOffset.zero(),
offset: offset,
ValentinVignal marked this conversation as resolved.
Show resolved Hide resolved
textSelectionDelegate: delegate,
text: const TextSpan(
text: 'test',
Expand All @@ -36,13 +34,17 @@ void main() {
affinity: TextAffinity.upstream,
),
);
addTearDown(editable.dispose);
editable.layout(BoxConstraints.loose(const Size(1000.0, 1000.0)));

final PipelineOwner owner = PipelineOwner(onNeedVisualUpdate: () { });
final _PointerRouterSpy spy = GestureBinding.instance.pointerRouter as _PointerRouterSpy;
final PipelineOwner owner = PipelineOwner(onNeedVisualUpdate: () {});
addTearDown(owner.dispose);
final _PointerRouterSpy spy =
GestureBinding.instance.pointerRouter as _PointerRouterSpy;
editable.attach(owner);
// This should register pointer into GestureBinding.instance.pointerRouter.
editable.handleEvent(const PointerDownEvent(), BoxHitTestEntry(editable, const Offset(10,10)));
editable.handleEvent(const PointerDownEvent(),
BoxHitTestEntry(editable, const Offset(10, 10)));
GestureBinding.instance.pointerRouter.route(const PointerDownEvent());
expect(spy.routeCount, greaterThan(0));
editable.detach();
Expand All @@ -57,7 +59,7 @@ class _GestureBindingSpy extends AutomatedTestWidgetsFlutterBinding {
PointerRouter get pointerRouter => _testPointerRouter;
}

class FakeEditableTextState extends Fake implements TextSelectionDelegate { }
class FakeEditableTextState extends Fake implements TextSelectionDelegate {}

class _PointerRouterSpy extends PointerRouter {
int routeCount = 0;
Expand Down