Add a flutter run option that can override the default target platform #14537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Feb 8, 2018
| @@ -34,6 +34,8 @@ abstract class RunCommandBase extends FlutterCommand { | |||
| 'forwards the host port to a device port.'); | |||
| argParser.addOption('route', | |||
| help: 'Which route to load when running the app.'); | |||
| argParser.addOption('target-platform', | |||
There was a problem hiding this comment.
Maybe we should explain in help what happens when target platform is android-arm64 and the device is an ios or an 32 bit android device?
There was a problem hiding this comment.
Added some help text
jason-simmons
force-pushed
the
bug_14526
branch
from
34a565e
to
8cd849d
Compare
amirh
approved these changes
Feb 8, 2018
| argParser.addOption('target-platform', | ||
| allowed: <String>['android-arm', 'android-arm64'], | ||
| help: 'Override the default target platform when building the app for an ' | ||
| 'Android device.\nIgnored on iOS.'); |
There was a problem hiding this comment.
nit: maybe also mention what happens on a 32 bit android device
By default flutter run will build a 64-bit APK if the attached Android device is 64-bit. Specifying --target-platform=android-arm will deploy a 32-bit APK to a 64-bit device. Fixes flutter#14526
jason-simmons
force-pushed
the
bug_14526
branch
from
8cd849d
to
5c8ade3
Compare
srawlins
added a commit
to srawlins/flutter
that referenced
this pull request
Feb 9, 2018
* master: (88 commits) Upgrade dartdoc to 0.16.0. (flutter#14602) Reduce noise in xcodebuild stdout (flutter#14586) Add annotations to ignore analyzer errors on pre-dev.22 SDKs (flutter#14599) Roll engine to 337764e (flutter#14597) Roll engine with rolled dart (flutter#14538) Upgrade packages (flutter#14588) Change GlobalObjectKey.toString to strip away State<StatefulWidget>. (flutter#14558) Disable selection of the Android ARM64 target platform based on the attached device (flutter#14581) Add a flutter run option that can override the default target platform (flutter#14537) Fix message channel usage in few tests. (flutter#14557) Update documentation on how to test flutter_tools (flutter#14567) Fix text_style_text.dart to be Dart 2 compliant. (flutter#14559) Hide the NDK warning that should never happen with a regexp (flutter#14503) Fix iOS build which broke after the change to fuse --strong option into --preview-dart-2. Mark run_machine_concurrent_hot_reload as flaky (flutter#14563) Fuse --strong into --preview-dart-2 option. Partially fix Dart 2 issues in animated_icons.test. (flutter#14531) Strong mode fixes in tests (flutter#14520) Fix typo. Fix issues. ...
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
flutter#14537) By default flutter run will build a 64-bit APK if the attached Android device is 64-bit. Specifying --target-platform=android-arm will deploy a 32-bit APK to a 64-bit device. Fixes flutter#14526
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2019
…(LineMetrics.left) (flutter#14537)" (flutter/engine#14569)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2019
…(LineMetrics.left) (flutter#14537)" (flutter/engine#14569)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2019
…(LineMetrics.left) (flutter#14537)" (flutter/engine#14569)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2019
…(LineMetrics.left) (flutter#14537)" (flutter/engine#14569)
chingjun
pushed a commit
that referenced
this pull request
Dec 19, 2019
* 988b8f1 Fix FontLoader does not remove the cache in web engine (flutter/engine#14536) * 0aacac7 Roll src/third_party/skia 21df075cab00..e6a2ad81ab40 (1 commits) (flutter/engine#14552) * 417dd7e Roll fuchsia/sdk/core/mac-amd64 from esDH2... to NHgyx... (flutter/engine#14554) * f2e841d [Web] Fix pointer binding (flutter/engine#14378) * 105eb66 Roll src/third_party/skia e6a2ad81ab40..8fec4140f614 (17 commits) (flutter/engine#14557) * 1ecfdcb [web] Calculate align offset for each paragraph line (LineMetrics.left) (flutter/engine#14537) * dda3619 Roll src/third_party/dart 270966b16044..171059d27689 (19 commits) (flutter/engine#14558) * 9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326) * f2dbeb8 Reland Wire up Opacity on Fuchsia (flutter/engine#14559) * 2f536e5 Roll fuchsia/sdk/core/linux-amd64 from jsuQq... to VdBKA... (flutter/engine#14560) * 4312d37 Revert "[fuchsia] Add diagnostics directory to the set of remote dirs (#14470)" (flutter/engine#14566) * 5c77ea1 Roll src/third_party/skia 8fec4140f614..9e0afb791ac2 (4 commits) (flutter/engine#14563) * a09ff7c Roll src/third_party/dart 171059d27689..aa6709974dea (11 commits) (flutter/engine#14567) * 0f90e65 Revert "[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537)" (flutter/engine#14569)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default flutter run will build a 64-bit APK if the attached Android device
is 64-bit. Specifying --target-platform=android-arm will deploy a 32-bit APK
to a 64-bit device.
Fixes #14526