-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draggable feedback positioning #145647
Merged
justinmc
merged 13 commits into
flutter:master
from
whynotmake-it:draggable-feedback-positioning
May 1, 2024
Merged
Draggable feedback positioning #145647
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
85c121e
use overlay coordinate space for draggable feedback
timcreatedit 34f6e2a
use late
JesperBllnbm daed8ad
added test for non-transformed draggable
timcreatedit 1092da2
added tests for scaled and unscaled apps
timcreatedit bdcd94e
added expected header to new test file and formatted it
timcreatedit 429479c
finish gestures in tests
timcreatedit 8310223
moved tests to correct file
timcreatedit 3df4223
finished gestures on tests in draggable_test.dart
timcreatedit 5127004
added test for rotation
timcreatedit 81d0112
added test for dragAnchorStrategy
timcreatedit 088c051
Merge branch 'master' into draggable-feedback-positioning
timcreatedit ae6934f
Merge branch 'draggable-feedback-positioning' of github.com:whynotmak…
timcreatedit 2cbad86
removed unneccessary import
timcreatedit File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to me that we're subtracting dragStartPoint both from a point in global space (
_lastOffset = globalPosition - dragStartPoint;
) and from a point in local/overlay space (_overlayOffset = overlaySpaceOffset - dragStartPoint;
). Wouldn't it be in the wrong coordinate space in one of those operations?I guess based on your test and your video demo it works, though, so maybe I'm misunderstanding what dragStartPoint is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question at first. This transformation is definitely correct for the purposes of
_overlayOffset
and I've added another test to verify that. However, it might be incorrect for_lastOffset
, which we purposefully haven't touched. We wanted this PR to focus on the visual feedback only, since we thought that would be least likely to break existing Flutter code. Adjusting_lastOffset_
can be done in another PR, where we could then make sure allDraggable
callbacks use the Overlay space instead of global coordinates as they do now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sounds good. I agree that it looks like dragStartPoint is not in the same coordinate space as globalPosition, but _overlayOffset should be right.