Fix leaking curved animation. #146644
Merged
Fix leaking curved animation. #146644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
polina-c
added
the
a: leak tracking
jacob314
reviewed
Apr 11, 2024
| @@ -189,7 +190,7 @@ void main() { | |||
| expect(element.dirty, isTrue); | |||
| }, skip: isBrowser); // TODO(yjbanov): cupertino does not work on the Web yet: https://github.com/flutter/flutter/issues/41920 | |||
|
|
|||
| testWidgets('RangeSlider relayout upon system fonts changes', (WidgetTester tester) async { | |||
| testWidgets('RangeSlider relayout upon system fonts changes more than once', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
don't understand why this test name changed
There was a problem hiding this comment.
There are two tests with the same name in this file.
polina-c
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 12, 2024
flutter/flutter@557fbf5...53cba24 2024-04-12 magder@google.com Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 chris@bracken.jp [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 jhy03261997@gmail.com Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 polinach@google.com Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 103135467+sealesj@users.noreply.github.com Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 engine-flutter-autoroll@skia.org Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…r#6509) flutter/flutter@557fbf5...53cba24 2024-04-12 magder@google.com Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 chris@bracken.jp [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 jhy03261997@gmail.com Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 polinach@google.com Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 103135467+sealesj@users.noreply.github.com Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 engine-flutter-autoroll@skia.org Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…r#6509) flutter/flutter@557fbf5...53cba24 2024-04-12 magder@google.com Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 chris@bracken.jp [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 jhy03261997@gmail.com Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 polinach@google.com Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 103135467+sealesj@users.noreply.github.com Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 engine-flutter-autoroll@skia.org Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.