-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland fix TextField helper top padding on M3 #146754
Reland fix TextField helper top padding on M3 #146754
Conversation
Google testing started 🤞 |
@justinmc Google testing failed but did it failed on the contrast test that led to the previous revert? |
@Renzo-Olivares If you have some bandwith can you have a look to the Google testing failure on this PR. For context, this is a reland which was reverted due to an accessibility test failure, see #145087 (comment). In the meantime, #146637 landed so Justin and I wonder if this accessibility test is still failing? |
Google test failures are expected due to the visual change, but we need to figure out whether the accessibility failure is still there or not. I will plan to go through those next week and see. |
I don't see the accessibility test failure, and I've checked all of the failing image diff tests and they're all expected. Let's try merging this. |
@justinmc Thanks a lot for checking this and above all for pointing the right direction in #145087 (comment). 🙏 |
@justinmc Looks like you added the auto submit label but forgot to approve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sorry I thought I had already approved 😊 . I'll plan to merge this tomorrow morning to be sure I'm available in case it breaks anything.
* master: plugin_ffi template comment fix (flutter#148378) Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455) Reland fix TextField helper top padding on M3 (flutter#146754) Removing duplicate assert on `VisualDensity` constructor (flutter#148281) Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450) Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448) Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445)
* master: (2580 commits) plugin_ffi template comment fix (flutter#148378) Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455) Reland fix TextField helper top padding on M3 (flutter#146754) Removing duplicate assert on `VisualDensity` constructor (flutter#148281) Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450) Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448) Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445) Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter#148441) Fix leaky tests. (flutter#148434) Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter#148430) Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter#148428) Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter#147901) Fix memory leaks in `_PopupMenuRoute` (flutter#148373) Add `clipBehavior` to `DrawerThemeData` (flutter#148061) Reland Native ios context menu (flutter#143002) (flutter#148238) (flutter#148265) Roll Packages from fd714bd7d516 to 87a02e393be0 (8 revisions) (flutter#148419) Stop running module_test_ios in devicelab and x64 Macs (flutter#148264) Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter#148369) Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter#148367) Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter#148365) ...
flutter/flutter@39651e8...0d22d91 2024-05-16 102401667+Dimilkalathiya@users.noreply.github.com fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 6655696+guidezpl@users.noreply.github.com ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 fluttergithubbot@gmail.com Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 dacoharkes@google.com plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 bruno.leroux@gmail.com Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 52160996+FMorschel@users.noreply.github.com Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 polinach@google.com Fix leaky tests. (flutter/flutter#148434) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 jhy03261997@gmail.com Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 jmccandless@google.com Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 engine-flutter-autoroll@skia.org Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 magder@google.com Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#6748) flutter/flutter@39651e8...0d22d91 2024-05-16 102401667+Dimilkalathiya@users.noreply.github.com fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 6655696+guidezpl@users.noreply.github.com ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 fluttergithubbot@gmail.com Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 dacoharkes@google.com plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 bruno.leroux@gmail.com Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 52160996+FMorschel@users.noreply.github.com Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 polinach@google.com Fix leaky tests. (flutter/flutter#148434) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 jhy03261997@gmail.com Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 jmccandless@google.com Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 engine-flutter-autoroll@skia.org Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 magder@google.com Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#6748) flutter/flutter@39651e8...0d22d91 2024-05-16 102401667+Dimilkalathiya@users.noreply.github.com fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 6655696+guidezpl@users.noreply.github.com ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 fluttergithubbot@gmail.com Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 dacoharkes@google.com plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 bruno.leroux@gmail.com Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 52160996+FMorschel@users.noreply.github.com Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 polinach@google.com Fix leaky tests. (flutter/flutter#148434) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 jhy03261997@gmail.com Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 32538273+ValentinVignal@users.noreply.github.com Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 jmccandless@google.com Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 engine-flutter-autoroll@skia.org Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 magder@google.com Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Update one comment which is obsolete since #146754
This is a reland of #145087 which was reverted in #145168.
#146637 was merged and might help here.
Description
InputDecorator
adds a 8.0 gap beetween the container and the helper text.From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.
This PR sets the correct values for M3 without changing the value for M2.
If this change is accepted, a future step will be to make this value configurable, probably by
InputDecorationTheme
.Related Issue
Fixes #144984
Tests
Updates a value used by several existing tests.