fixes some gesture not getting disposed #147112

Dimilkalathiya · 2024-04-20T08:48:35Z

part of #141198

Fixes some gestures not getting disposed

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Dimilkalathiya · 2024-04-20T08:52:04Z

cc: @polina-c found some gesture leaks while testing curve animation leaks

polina-c

Thank you!!!

…7112)

flutter/flutter@98685a0...1a905d5 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125) 2024-04-20 102401667+Dimilkalathiya@users.noreply.github.com fixes some gesture not getting disposed (flutter/flutter#147112) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095) 2024-04-19 sokolovskyi.konstantin@gmail.com Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091) 2024-04-19 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147030) 2024-04-19 sokolovskyi.konstantin@gmail.com Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724) 2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090) 2024-04-19 jago84@gmail.com [material] Fix info text (flutter/flutter#147040) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for animated_padding.0.dart API example. (flutter/flutter#146718) 2024-04-19 103135467+sealesj@users.noreply.github.com Refactor android preview tool integration tests (flutter/flutter#146518) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for dismissible.0.dart API example. (flutter/flutter#146723) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079) 2024-04-19 42216813+eliasyishak@users.noreply.github.com Update docs around ga3 ga4 mismatch (flutter/flutter#147075) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for preferred_size.0.dart API example. (flutter/flutter#146725) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061) 2024-04-19 engine-flutter-autoroll@skia.org Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#6583) flutter/flutter@98685a0...1a905d5 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128) 2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125) 2024-04-20 102401667+Dimilkalathiya@users.noreply.github.com fixes some gesture not getting disposed (flutter/flutter#147112) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099) 2024-04-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095) 2024-04-19 sokolovskyi.konstantin@gmail.com Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091) 2024-04-19 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147030) 2024-04-19 sokolovskyi.konstantin@gmail.com Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724) 2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090) 2024-04-19 jago84@gmail.com [material] Fix info text (flutter/flutter#147040) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for animated_padding.0.dart API example. (flutter/flutter#146718) 2024-04-19 103135467+sealesj@users.noreply.github.com Refactor android preview tool integration tests (flutter/flutter#146518) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for dismissible.0.dart API example. (flutter/flutter#146723) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079) 2024-04-19 42216813+eliasyishak@users.noreply.github.com Update docs around ga3 ga4 mismatch (flutter/flutter#147075) 2024-04-19 sokolovskyi.konstantin@gmail.com Add test for preferred_size.0.dart API example. (flutter/flutter#146725) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061) 2024-04-19 engine-flutter-autoroll@skia.org Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

some gesture not getting disposed

84f4839

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: gestures flutter/packages/flutter/gestures repository. labels Apr 20, 2024

fixes serial_tap_test.dart leaks

841b151

Dimilkalathiya changed the title ~~some gesture not getting disposed~~ fixes some gesture not getting disposed Apr 20, 2024

polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 20, 2024

polina-c approved these changes Apr 20, 2024

View reviewed changes

polina-c merged commit 158a9a8 into flutter:master Apr 20, 2024
74 checks passed

engine-flutter-autoroll mentioned this pull request Apr 20, 2024

Roll Flutter from 98685a099fdd to 158a9a81774c (26 revisions) flutter/packages#6582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2024

158a9a817 fixes some gesture not getting disposed (flutter/flutter#14…

d90cd6f

…7112)

engine-flutter-autoroll mentioned this pull request Apr 21, 2024

Roll Flutter from 98685a099fdd to 1a905d508de1 (30 revisions) flutter/packages#6583

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2024

158a9a817 fixes some gesture not getting disposed (flutter/flutter#14…

b7a518b

…7112)

gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024

fixes some gesture not getting disposed (flutter#147112)

f015f99

HansMuller mentioned this pull request Apr 26, 2024

Flutter Framework Team: Notable Commits #121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes some gesture not getting disposed #147112

fixes some gesture not getting disposed #147112

Dimilkalathiya commented Apr 20, 2024

Dimilkalathiya commented Apr 20, 2024

polina-c left a comment

fixes some gesture not getting disposed #147112

fixes some gesture not getting disposed #147112

Conversation

Dimilkalathiya commented Apr 20, 2024

Pre-launch Checklist

Dimilkalathiya commented Apr 20, 2024

polina-c left a comment

Choose a reason for hiding this comment