Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for character_activator.0.dart API example. #147384

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add tests for character_activator.0.dart API example. #147384

merged 2 commits into from
Apr 26, 2024

Conversation

ksokolovskyi
Copy link
Contributor

This PR contributes to #130459

Description

  • Adds examples/api/lib/widgets/shortcuts/character_activator.0.dart test
  • Fixes the description of the examples/api/lib/widgets/shortcuts/character_activator.0.dart example

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 25, 2024
Renzo-Olivares
Renzo-Olivares approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

dkwingsmt
dkwingsmt approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2024
@auto-submit auto-submit bot merged commit 9230b0e into flutter:master Apr 26, 2024
138 checks passed
@ksokolovskyi
Copy link
Contributor Author

@Renzo-Olivares @dkwingsmt thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2024
@engine-flutter-autoroll
9230b0e82 Add tests for character_activator.0.dart API example. (flut…
126842a 
…ter/flutter#147384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2024
@engine-flutter-autoroll
9230b0e82 Add tests for character_activator.0.dart API example. (flut…
0223acc 
…ter/flutter#147384)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 27, 2024
@engine-flutter-autoroll
Roll Flutter from 2e806700b928 to f9933b6994e4 (17 revisions) (#6620)
f5a4517 
flutter/flutter@2e80670...f9933b6

2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5205e3683a0a to 20fb62ba1455 (1 revision) (flutter/flutter#147449)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e14649ea0c80 to 5205e3683a0a (1 revision) (flutter/flutter#147448)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87f489c1bed4 to e14649ea0c80 (1 revision) (flutter/flutter#147446)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cecf5aa8a778 to 87f489c1bed4 (1 revision) (flutter/flutter#147445)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8af10eba3ef3 to cecf5aa8a778 (1 revision) (flutter/flutter#147444)
2024-04-27 chris@bracken.jp [macOS] Eliminate flutter_gallery_macos__start_up benchmark (flutter/flutter#147442)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc055398f42a to 8af10eba3ef3 (1 revision) (flutter/flutter#147441)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from c410180e5bba to bc055398f42a (7 revisions) (flutter/flutter#147440)
2024-04-26 sokolovskyi.konstantin@gmail.com Add tests for character_activator.0.dart API example. (flutter/flutter#147384)
2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.2 to 3.25.3 (flutter/flutter#147437)
2024-04-26 andrewrkolos@gmail.com Add integration test for asset transformation feature (flutter/flutter#145715)
2024-04-26 Dhankechakishan@gmail.com Added missing tests for Table api example `table.0.dart`. (flutter/flutter#147318)
2024-04-26 andrewrkolos@gmail.com Catch any `FileSystemException` thrown when trying to read the template manifest during `flutter create` (flutter/flutter#145620)
2024-04-26 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoFullscreenDialogTransition` leaks (flutter/flutter#147168)
2024-04-26 leroux_bruno@yahoo.fr Fix helperMaxLines and errorMaxLines documentation (flutter/flutter#147409)
2024-04-26 gspencergoog@users.noreply.github.com Refactor route focus node creation (flutter/flutter#147390)
2024-04-26 engine-flutter-autoroll@skia.org Roll Packages from fde908d to dd01140 (5 revisions) (flutter/flutter#147420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 2e806700b928 to f9933b6994e4 (17 revisions) (flutte…
e76da26 
…r#6620)

flutter/flutter@2e80670...f9933b6

2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5205e3683a0a to 20fb62ba1455 (1 revision) (flutter/flutter#147449)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e14649ea0c80 to 5205e3683a0a (1 revision) (flutter/flutter#147448)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87f489c1bed4 to e14649ea0c80 (1 revision) (flutter/flutter#147446)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cecf5aa8a778 to 87f489c1bed4 (1 revision) (flutter/flutter#147445)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8af10eba3ef3 to cecf5aa8a778 (1 revision) (flutter/flutter#147444)
2024-04-27 chris@bracken.jp [macOS] Eliminate flutter_gallery_macos__start_up benchmark (flutter/flutter#147442)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc055398f42a to 8af10eba3ef3 (1 revision) (flutter/flutter#147441)
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from c410180e5bba to bc055398f42a (7 revisions) (flutter/flutter#147440)
2024-04-26 sokolovskyi.konstantin@gmail.com Add tests for character_activator.0.dart API example. (flutter/flutter#147384)
2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.2 to 3.25.3 (flutter/flutter#147437)
2024-04-26 andrewrkolos@gmail.com Add integration test for asset transformation feature (flutter/flutter#145715)
2024-04-26 Dhankechakishan@gmail.com Added missing tests for Table api example `table.0.dart`. (flutter/flutter#147318)
2024-04-26 andrewrkolos@gmail.com Catch any `FileSystemException` thrown when trying to read the template manifest during `flutter create` (flutter/flutter#145620)
2024-04-26 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoFullscreenDialogTransition` leaks (flutter/flutter#147168)
2024-04-26 leroux_bruno@yahoo.fr Fix helperMaxLines and errorMaxLines documentation (flutter/flutter#147409)
2024-04-26 gspencergoog@users.noreply.github.com Refactor route focus node creation (flutter/flutter#147390)
2024-04-26 engine-flutter-autoroll@skia.org Roll Packages from fde908d to dd01140 (5 revisions) (flutter/flutter#147420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksokolovskyi @Renzo-Olivares @dkwingsmt