-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for scaffold.of.#.dart API examples. #147637
Add tests for scaffold.of.#.dart API examples. #147637
Conversation
e5f1ced
to
b2723ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your valuable additions!
For consistency with other example tests and also with framework ones, please apply the following minor changes:
- remove the group.
- format all
testWidgets
to fit on one line (line 12 is ok), do it even when the test description is longer (for instance line 21). In framework test, this is done for readability. If the test description is very long tes, it can be split into several lines (but finding a shorter description is generally better).
It would be great to do the same for your similar open PRs, thanks!
@bleroux thanks a lot for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
a065a2b
to
6f7978f
Compare
@TahaTesser could you please look at this PR when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bleroux @TahaTesser thanks a lot for the review and merge! |
flutter/flutter@adf279f...02a6c91 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 engine-flutter-autoroll@skia.org Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#6776) flutter/flutter@adf279f...02a6c91 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 engine-flutter-autoroll@skia.org Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 sokolovskyi.konstantin@gmail.com Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR contributes to #130459
Description
examples/api/lib/material/scaffold/scaffold.of.0.dart
examples/api/lib/material/scaffold/scaffold.of.1.dart
Pre-launch Checklist
///
).