Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update #147679

Merged
merged 5 commits into from May 2, 2024
Merged

Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update #147679

merged 5 commits into from May 2, 2024

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 1, 2024 •
edited

Description

This introduces a list of packages that we will explicitly not pin. It is to be used for things where the package isn't actually published, but is a transitive dependency of another package included in the SDK. This happens with the macros package, for instance, which depends on the private, unpublished, _macros package where the SDK does some tricky things to depend on it (it depends on "any", but ships it as part of the SDK).

Also ran flutter update-packages --force-update to update all of the pubspec files.

Related Issues

Tests

  • Added a test that makes sure that explicitly unpinned packages don't show up in the pinned list.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels May 1, 2024
@gspencergoog gspencergoog changed the title Add explicitly excluded packages. Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update May 1, 2024
christopherfujino
christopherfujino approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino reviewed May 1, 2024
View reviewed changes
packages/flutter_tools/lib/src/update_packages_pins.dart

/// These are packages that are explicitly excluded from appearing in the list
/// of pinned packages added to each pubspec.yaml.
const List<String> kExplicitlyExcludedPackages = <String>[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @andrewkolos this is a thing

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented May 1, 2024

auto label is removed for flutter/flutter/147679, due to - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented May 2, 2024

auto label is removed for flutter/flutter/147679, due to - The status or check suite Linux tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit auto-submit bot merged commit 2e78ed0 into flutter:master May 2, 2024
138 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2024
@engine-flutter-autoroll
2e78ed0ff Allow explicit exclusion of packages from pinned packages i…
50dff80 
…n `flutter update-packages --force-update` (flutter/flutter#147679)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 2, 2024
@engine-flutter-autoroll
Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions) (#6637)
1856a6e 
Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions)

flutter/flutter@d33bb8f...bf7191f

2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b989d239e281 to 1fb36ac9d718 (2 revisions) (flutter/flutter#147713)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c9c2ce8369e to b989d239e281 (1 revision) (flutter/flutter#147711)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58b031c096ea to 3c9c2ce8369e (2 revisions) (flutter/flutter#147703)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc28057dbd4d to 58b031c096ea (1 revision) (flutter/flutter#147701)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfc6787eedc3 to fc28057dbd4d (1 revision) (flutter/flutter#147700)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cbef71f4f54 to bfc6787eedc3 (1 revision) (flutter/flutter#147699)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90ce9e5959fc to 7cbef71f4f54 (1 revision) (flutter/flutter#147696)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78dced50c467 to 90ce9e5959fc (1 revision) (flutter/flutter#147695)
2024-05-02 andrewrkolos@gmail.com add verbose logging to select hot reload/hot restart tests (flutter/flutter#147673)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3087ec1adddd to 78dced50c467 (3 revisions) (flutter/flutter#147693)
2024-05-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#147692)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) (flutter/flutter#147688)
2024-05-02 gspencergoog@users.noreply.github.com Allow explicit exclusion of packages from pinned packages in `flutter update-packages --force-update` (flutter/flutter#147679)
2024-05-02 31859944+LongCatIsLooong@users.noreply.github.com Implement getDryBaseline for Stack and Overlay (flutter/flutter#146253)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) (flutter/flutter#147681)
2024-05-02 polinach@google.com Update selectable_text_test.dart (flutter/flutter#147677)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) (flutter/flutter#147678)
2024-05-01 31859944+LongCatIsLooong@users.noreply.github.com Implement computeDryBaseline for `RenderWrap` (flutter/flutter#146260)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) (flutter/flutter#147675)
2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.0 to 4.3.1 (flutter/flutter#147674)
2024-05-01 ian@hixie.ch Remove obsolete performance analysis tools. (flutter/flutter#147663)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) (flutter/flutter#147670)
2024-05-01 120297255+PurplePolyhedron@users.noreply.github.com fix DropdownMenu overflow (flutter/flutter#147233)
2024-05-01 yjbanov@google.com [web] remove platform_messages_integration test (flutter/flutter#147654)
2024-05-01 rmolivares@renzo-olivares.dev Fix `TextField` horizontal drag conflicts (flutter/flutter#147341)
2024-05-01 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#147472)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Draggable feedback positioning (#145647)" (flutter/flutter#147658)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) (flutter/flutter#147655)
2024-05-01 yjbanov@google.com add lang attribute to the a11y_assessments app (flutter/flutter#147586)
2024-05-01 hi@timcreated.it Draggable feedback positioning (flutter/flutter#145647)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ce67714ce4c to 0014e0353aa9 (13 revisions) (flutter/flutter#147649)
2024-05-01 sokolovskyi.konstantin@gmail.com Add test for animated_fractionally_sized_box.0.dart API example. (flutter/flutter#146721)
2024-05-01 engine-flutter-autoroll@skia.org Roll Packages from cc47b06 to aea93d2 (5 revisions) (flutter/flutter#147647)
2024-05-01 73608287+ellet0@users.noreply.github.com Update reorderable_list.dart to use Dart 3 return switch statement for consistency (flutter/flutter#147505)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions) (flutte…
9b966c3 
…r#6637)

Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions)

flutter/flutter@d33bb8f...bf7191f

2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b989d239e281 to 1fb36ac9d718 (2 revisions) (flutter/flutter#147713)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c9c2ce8369e to b989d239e281 (1 revision) (flutter/flutter#147711)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58b031c096ea to 3c9c2ce8369e (2 revisions) (flutter/flutter#147703)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc28057dbd4d to 58b031c096ea (1 revision) (flutter/flutter#147701)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfc6787eedc3 to fc28057dbd4d (1 revision) (flutter/flutter#147700)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cbef71f4f54 to bfc6787eedc3 (1 revision) (flutter/flutter#147699)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90ce9e5959fc to 7cbef71f4f54 (1 revision) (flutter/flutter#147696)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78dced50c467 to 90ce9e5959fc (1 revision) (flutter/flutter#147695)
2024-05-02 andrewrkolos@gmail.com add verbose logging to select hot reload/hot restart tests (flutter/flutter#147673)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3087ec1adddd to 78dced50c467 (3 revisions) (flutter/flutter#147693)
2024-05-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#147692)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) (flutter/flutter#147688)
2024-05-02 gspencergoog@users.noreply.github.com Allow explicit exclusion of packages from pinned packages in `flutter update-packages --force-update` (flutter/flutter#147679)
2024-05-02 31859944+LongCatIsLooong@users.noreply.github.com Implement getDryBaseline for Stack and Overlay (flutter/flutter#146253)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) (flutter/flutter#147681)
2024-05-02 polinach@google.com Update selectable_text_test.dart (flutter/flutter#147677)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) (flutter/flutter#147678)
2024-05-01 31859944+LongCatIsLooong@users.noreply.github.com Implement computeDryBaseline for `RenderWrap` (flutter/flutter#146260)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) (flutter/flutter#147675)
2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.0 to 4.3.1 (flutter/flutter#147674)
2024-05-01 ian@hixie.ch Remove obsolete performance analysis tools. (flutter/flutter#147663)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) (flutter/flutter#147670)
2024-05-01 120297255+PurplePolyhedron@users.noreply.github.com fix DropdownMenu overflow (flutter/flutter#147233)
2024-05-01 yjbanov@google.com [web] remove platform_messages_integration test (flutter/flutter#147654)
2024-05-01 rmolivares@renzo-olivares.dev Fix `TextField` horizontal drag conflicts (flutter/flutter#147341)
2024-05-01 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#147472)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Draggable feedback positioning (#145647)" (flutter/flutter#147658)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) (flutter/flutter#147655)
2024-05-01 yjbanov@google.com add lang attribute to the a11y_assessments app (flutter/flutter#147586)
2024-05-01 hi@timcreated.it Draggable feedback positioning (flutter/flutter#145647)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ce67714ce4c to 0014e0353aa9 (13 revisions) (flutter/flutter#147649)
2024-05-01 sokolovskyi.konstantin@gmail.com Add test for animated_fractionally_sized_box.0.dart API example. (flutter/flutter#146721)
2024-05-01 engine-flutter-autoroll@skia.org Roll Packages from cc47b06 to aea93d2 (5 revisions) (flutter/flutter#147647)
2024-05-01 73608287+ellet0@users.noreply.github.com Update reorderable_list.dart to use Dart 3 return switch statement for consistency (flutter/flutter#147505)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The flutter update-packages --force-upgrade command fails and it can't find _macros package
2 participants
@gspencergoog @christopherfujino