-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks in context menu #147822
Fix memory leaks in context menu #147822
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cc @polina-c |
I couldn't enable the leak tracking in some tests as they would fail because of |
Thanks. Options are:
|
Let's see if #146999 can get merged first If not, I'll try to write a test |
47d853c
to
d4e72ec
Compare
@polina-c I modified the tests in test: Update the tests |
Part of #141198
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.