Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Getter for floatingActionButtonLocation in ScaffoldState #148082

Closed
wants to merge 2 commits into from

Conversation

piedcipher
Copy link
Member

@piedcipher piedcipher commented May 9, 2024

Adds Getter for floatingActionButtonLocation in ScaffoldState.

Fixes #147804

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 9, 2024
@goderbauer goderbauer requested a review from Piinks May 10, 2024 21:05
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @piedcipher thanks for sending a PR! I don't know that we need to add this though. The FAB location has a clear default, unless the user provides another value. I don't know that we need to expose it on the ScaffoldState.

WDYT about waiting to see if we get more feedback on the issue that indicates there is a need for this?

@@ -2136,6 +2136,11 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto
final RestorableBool _drawerOpened = RestorableBool(false);
final RestorableBool _endDrawerOpened = RestorableBool(false);

/// The current position of [FloatingActionButton] in [Scaffold].
///
/// defaults to [_kDefaultFloatingActionButtonLocation].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc reference would lead no where since it is a private constant.

@piedcipher
Copy link
Member Author

Hey @piedcipher thanks for sending a PR! I don't know that we need to add this though. The FAB location has a clear default, unless the user provides another value. I don't know that we need to expose it on the ScaffoldState.

WDYT about waiting to see if we get more feedback on the issue that indicates there is a need for this?

Right better to wait here. Closing this one for now.

@piedcipher piedcipher closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getter for floatingActionButtonLocation in ScaffoldState
2 participants