Add test for text_editing_controller.0.dart API example. #148872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
victorsanni
reviewed
May 23, 2024
| expect(controller.text, input.toLowerCase()); | ||
| expect( | ||
| controller.selection, | ||
| const TextSelection.collapsed(offset: input.length), |
There was a problem hiding this comment.
Isn't this default behavior? I would keep this test for the lower case functionality and write a separate test that tries to move the selection?
There was a problem hiding this comment.
@victorsanni thanks for the review!
You are right, it is the default behavior, so I added a separate test to verify that caret is positioned at the end of the input.
victorsanni
approved these changes
May 24, 2024
victorsanni
added
the
autosubmit
|
@victorsanni @MitchellGoodwin thanks a lot for the review and merge! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 25, 2024
flutter/flutter@8dd0831...cb26a01 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070) 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068) 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057) 2024-05-24 wyattliang@gmail.com fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670) 2024-05-24 jhy03261997@gmail.com [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055) 2024-05-24 jhy03261997@gmail.com [a11y] Slider should respect bold text setting (flutter/flutter#149053) 2024-05-24 sokolovskyi.konstantin@gmail.com Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051) 2024-05-24 sokolovskyi.konstantin@gmail.com Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045) 2024-05-24 gawronlucas@gmail.com Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298) 2024-05-24 engine-flutter-autoroll@skia.org Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
) This PR contributes to flutter#130459 ### Description - Adds test for `examples/api/lib/widgets/editable_text/text_editing_controller.0.dart`
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…r#6794) flutter/flutter@8dd0831...cb26a01 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070) 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068) 2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057) 2024-05-24 wyattliang@gmail.com fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670) 2024-05-24 jhy03261997@gmail.com [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055) 2024-05-24 jhy03261997@gmail.com [a11y] Slider should respect bold text setting (flutter/flutter#149053) 2024-05-24 sokolovskyi.konstantin@gmail.com Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051) 2024-05-24 sokolovskyi.konstantin@gmail.com Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045) 2024-05-24 gawronlucas@gmail.com Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298) 2024-05-24 engine-flutter-autoroll@skia.org Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #130459
Description
examples/api/lib/widgets/editable_text/text_editing_controller.0.dartPre-launch Checklist
///).