-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a default case to unblock engine roll. #149353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ issue filed for follow-up
@@ -401,6 +401,9 @@ void _defineTests() { | |||
case SemanticsAction.showOnScreen: | |||
case SemanticsAction.tap: | |||
semanticsOwner.performAction(expectedId, action); | |||
// Add the default case temporarily to unblock engine roll. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make these TODOs in the style I did here? https://github.com/flutter/flutter/pull/149274/files
It will make it easier for me to undo later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -571,6 +571,9 @@ void main() { | |||
case SemanticsAction.showOnScreen: | |||
case SemanticsAction.tap: | |||
semanticsOwner.performAction(expectedId, action); | |||
// Add the default case temporarily to unblock engine roll. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Force-merging to unblock the engine roll. |
This reverts commit 557a959.
Similar to #149274