-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputDecorator M3 tests migration - prefixIcon/suffixIcon #149437
InputDecorator M3 tests migration - prefixIcon/suffixIcon #149437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Thanks for migrating all of these. I'm a fan of the small, focused tests like you wrote. It makes it easier to track down what's wrong when there's a failure.
Exactly! I had to go through failures on very very long tests and it was painful (for instance, having to fix several failures before reaching the one that was really interesting). So when possible I try to keep the scope as narrow as possible. |
Description
This PR adds several tests tp check M3 specification compliance for
InputDecorator.prefixIcon
andInputDecorator.suffixIcon
.This is somewhat repetitive but it helped me to catch several styling and positionning issues, I added TODOs because I will file the fixes once this PR is merged (just in case the fixes break some Google tests).
Related Issue
Part of #139076