[web] Change `--web-renderer` default from `auto` to `canvaskit` #149773

mdebbar · 2024-06-05T22:03:27Z

When --web-renderer is omitted, keep the value null until it later materializes to either canvaskit or skwasm.
No more hardcoded defaults anywhere. We use WebRendererMode.defaultForJs/defaultForWasm instead.
When in --wasm mode, the JS fallback is now canvaskit instead of auto.
Add test for defaulting to skwasm when --wasm is enabled.

) Changes the documentation of the default renderer on web. The default renderer is changing from `auto` to `canvaskit`. _This PR is mostly moving things around with no new content being added._ The PR making the code changes: flutter/flutter#149773 The issue: flutter/flutter#149826 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.

eyebrowsoffire

LGTM! One small nit.

eyebrowsoffire · 2024-06-06T18:09:42Z

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

@@ -964,7 +990,7 @@ void main() {
      JsCompilerConfig(optimizationLevel: 0),
      JsCompilerConfig(noFrequencyBasedMinification: true),
      JsCompilerConfig(sourceMaps: false),
-      JsCompilerConfig(renderer: WebRendererMode.canvaskit),
+      JsCompilerConfig(renderer: WebRendererMode.skwasm),


We should do WebRendererMode.auto or WebRendererMode.html here for this test, I think. JsCompilerConfig with a skwasm renderer mode, while it won't throw at this particular layer it isn't a logically valid or supported combination, so it's weird to use it in the test.

The only reason I used skwasm instead of html is because I didn't want to change it again when we remove the html renderer.

But I see what you're saying. I'll use html for now, and later remove this line entirely when there's no more html renderer.

eyebrowsoffire

I meant to approve earlier.

…skit` (flutter/flutter#149773)

flutter/flutter@32081aa...14df7be 2024-06-11 109111084+yaakovschectman@users.noreply.github.com Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045) 2024-06-11 32538273+ValentinVignal@users.noreply.github.com Add tests for scaffold drawer and end drawer (flutter/flutter#149383) 2024-06-11 36861262+QuncCccccc@users.noreply.github.com Add high-contrast theme (flutter/flutter#149779) 2024-06-11 goderbauer@google.com Manual Pub Roll (flutter/flutter#150025) 2024-06-10 chris@bracken.jp [docs] Per-platform desktop triage instructions (flutter/flutter#150019) 2024-06-10 greg@zulip.com Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976) 2024-06-10 34871572+gmackall@users.noreply.github.com Unpin `camera_android` and remove its only usage (flutter/flutter#150017) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes a bug where NavigatorState.pop does not consider any possible sâ�¦ (flutter/flutter#150014) 2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021) 2024-06-10 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007) 2024-06-10 kustermann@google.com Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996) 2024-06-10 engine-flutter-autoroll@skia.org Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997) 2024-06-10 ditman@gmail.com [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500) 2024-06-10 greg@zulip.com Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941) 2024-06-10 ttorii20@gmail.com Update hasTrailingSpaces (flutter/flutter#149698) 2024-06-10 mdebbar@google.com [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773) 2024-06-10 jason-simmons@users.noreply.github.com Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926) 2024-06-10 mit@google.com Remove package:platform from issue template (flutter/flutter#149995) 2024-06-10 15619084+vashworth@users.noreply.github.com Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#6907) flutter/flutter@32081aa...14df7be 2024-06-11 109111084+yaakovschectman@users.noreply.github.com Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045) 2024-06-11 32538273+ValentinVignal@users.noreply.github.com Add tests for scaffold drawer and end drawer (flutter/flutter#149383) 2024-06-11 36861262+QuncCccccc@users.noreply.github.com Add high-contrast theme (flutter/flutter#149779) 2024-06-11 goderbauer@google.com Manual Pub Roll (flutter/flutter#150025) 2024-06-10 chris@bracken.jp [docs] Per-platform desktop triage instructions (flutter/flutter#150019) 2024-06-10 greg@zulip.com Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976) 2024-06-10 34871572+gmackall@users.noreply.github.com Unpin `camera_android` and remove its only usage (flutter/flutter#150017) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes a bug where NavigatorState.pop does not consider any possible sâ�¦ (flutter/flutter#150014) 2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021) 2024-06-10 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007) 2024-06-10 kustermann@google.com Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996) 2024-06-10 engine-flutter-autoroll@skia.org Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997) 2024-06-10 ditman@gmail.com [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500) 2024-06-10 greg@zulip.com Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941) 2024-06-10 ttorii20@gmail.com Update hasTrailingSpaces (flutter/flutter#149698) 2024-06-10 mdebbar@google.com [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773) 2024-06-10 jason-simmons@users.noreply.github.com Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926) 2024-06-10 mit@google.com Remove package:platform from issue template (flutter/flutter#149995) 2024-06-10 15619084+vashworth@users.noreply.github.com Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[web] Change --web-renderer default from auto to canvaskit

4eb9a64

mdebbar requested a review from eyebrowsoffire June 5, 2024 22:03

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 5, 2024

mdebbar mentioned this pull request Jun 6, 2024

[web] Change --web-renderer default from auto to canvaskit flutter/website#10714

Merged

3 tasks

eyebrowsoffire reviewed Jun 6, 2024

View reviewed changes

eyebrowsoffire approved these changes Jun 6, 2024

View reviewed changes

mdebbar mentioned this pull request Jun 7, 2024

[Future][web] Change --web-renderer default from auto to canvaskit flutter/website#10722

Draft

3 tasks

mdebbar added 2 commits June 7, 2024 11:15

address review comments

42ef8fb

Merge branch 'main' into renderer_default_canvaskit

c891210

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2024

auto-submit bot merged commit ee10d2f into flutter:master Jun 10, 2024
128 checks passed

engine-flutter-autoroll mentioned this pull request Jun 11, 2024

Roll Flutter from 32081aab69f8 to aad70e5cdb8e (20 revisions) flutter/packages#6906

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024

ee10d2fc3 [web] Change --web-renderer default from auto to `canva…

f148c39

…skit` (flutter/flutter#149773)

engine-flutter-autoroll mentioned this pull request Jun 11, 2024

Roll Flutter from 32081aab69f8 to 14df7be3f947 (21 revisions) flutter/packages#6907

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024

ee10d2fc3 [web] Change --web-renderer default from auto to `canva…

f2b4f4c

…skit` (flutter/flutter#149773)

This was referenced Jun 14, 2024

[web] Remove --web-renderer=auto and default to canvaskit #147729

Closed

[web] Remove --web-renderer=auto and default to canvaskit flutter/engine#52529

Closed

mdebbar deleted the renderer_default_canvaskit branch June 21, 2024 15:13

blendthink mentioned this pull request Jul 7, 2024

feat: Flutter SDK バージョンを 3.23.0-13.0.pre に更新 FlutterKaigi/2024#131

Merged

ditman mentioned this pull request Jul 9, 2024

[palette_generator][web] Reenable web tests. #151498

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] Change `--web-renderer` default from `auto` to `canvaskit` #149773

[web] Change `--web-renderer` default from `auto` to `canvaskit` #149773

mdebbar commented Jun 5, 2024 •

edited

Loading

eyebrowsoffire left a comment

eyebrowsoffire Jun 6, 2024

mdebbar Jun 6, 2024

eyebrowsoffire left a comment

[web] Change --web-renderer default from auto to canvaskit #149773

[web] Change --web-renderer default from auto to canvaskit #149773

Conversation

mdebbar commented Jun 5, 2024 • edited Loading

eyebrowsoffire left a comment

Choose a reason for hiding this comment

eyebrowsoffire Jun 6, 2024

Choose a reason for hiding this comment

mdebbar Jun 6, 2024

Choose a reason for hiding this comment

eyebrowsoffire left a comment

Choose a reason for hiding this comment

[web] Change `--web-renderer` default from `auto` to `canvaskit` #149773

[web] Change `--web-renderer` default from `auto` to `canvaskit` #149773

mdebbar commented Jun 5, 2024 •

edited

Loading