Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius #16272

Merged

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Apr 5, 2018

The top,left corners of InputDecoration.filled TextFields now have a default corner radius of 4.0 instead of 0.0.

Added an UnderlineInputBorder.borderRadius property whose default value is a rounded rectangle BorderRadius with top left and right corner radii of 4.0.

This is the default appearance of filled text fields before this change:

textfield_original

This is the default appearance of filled text fields after this change:

textfield_default

The same text field with:

decoration: new InputDecoration(
  filled: true,
  border: new UnderlineInputBorder(
    borderRadius: new BorderRadius.circular(12.0),
  ),
  ...
)

textfield_rounded

@Hixie
Copy link
Contributor

Hixie commented Apr 5, 2018

LGTM

@HansMuller HansMuller merged commit c7d982e into flutter:master Apr 5, 2018
@HansMuller HansMuller deleted the filled_textfield_corner_radius branch April 5, 2018 19:08
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
teriyakijack added a commit to teriyakijack/flutter that referenced this pull request Jul 17, 2018
* 'master' of https://github.com/flutter/flutter:
  Roll engine to aa9ce70 (flutter#16289)
  Rename chip's border attribute to shape for consistency. (flutter#16276)
  Added BeveledRectangleBorder ShapeBorder (flutter#16279)
  Roll engine to version be07059 (flutter#16264)
  Make Podfiles work with Cocoapods 1.5.0 (flutter#16273)
  Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius (flutter#16272)
  Handle whitespace in entry values in the AAPT badging parser (flutter#16245)
  a11y adjustments for the Bottom app bar demo (flutter#16238)
  Play butterfly video from asset instead of network (flutter#16269)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants